Range sync w/ dynamic target #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Api
scope-networking
|
Code Climate has analyzed commit 9c072ba and detected 9 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
dapplion
force-pushed
the
dapplion/range-sync-dynamic-target
branch
from
14dc53a
to
d5da742
Compare
This was referenced May 2, 2021
Closed
Add peer reporting to sync chain Move sync progress logger to the node Remove chainMaybeStuck timeout Handle Range Sync errors and return better Fix Sync Range state logic Make node notifier logs consistent Throw error in Batch methods instead of in factory Narrow error capturing in SyncChain.processBatch Update RangeSync comments Propagate info if peer has been removed from SyncChain Sync subscribe to RangeSync to update sync state Log SyncChain id to identify it Fix bug in SyncChain downloading an extra batch on finalized sync Fix block ordering in getUnfinalizedBlocksAtSlots Re-status peers after completing a SyncChain RangeSync remove peers from Head sync chains only Reduce scope of Sync instance's properties Add peersPerSyncChain metrics Stop gossip handlers if sync falls behind Accept considering Synced even if headSlot = 0 RangeSync should start and stop chains if necessary only Add lodestar_peers_per_sync_chain metrics view Add lodestar_process_chain_segment_time metric Add lodestar API for getSyncChainsDebugState Fix SyncChain priorization Fix SyncChain startSyncing promise handling Remove unused subscribeCoreTopics fn Test sync range updateChains logic Clean-up instance modules and constructor args Don't store status in peer metastore Polish module organization Don't use AbortController unnecessarily Add and fix comments - Remove IPeerManager interface - Merge Sync start into constructor - Declare Sync.close() in interface - Declare const CHECK_PING_STATUS_INTERVAL Revert onUnknownBlockRoot changes If a node witness the genesis event consider starting gossip emit internal chain event clockEpoch Make SyncChain target dynamic Add isSingleNode option Simplify remoteSyncType modules Fine tune sync state logic Add syncStatus metric
dapplion
force-pushed
the
dapplion/range-sync-dynamic-target
branch
from
f723113
to
9c072ba
Compare
wemeetagain
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Lighthouse's range sync which features:
Differs from #2111 in that SyncChain instances have dynamic targets instead of static. This solves the critical issues in #2111.
Closes #2461 Closes #2460