Use eth2-clients / slashing-protection-interchange-tests & add support for v5 slashing protection interchange #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3xtr4t3rr3str14l
requested review from
dapplion,
mpetrunic,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit 8a1a331 and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
dapplion
suggested changes
May 4, 2021
...shing-protection-interchange-tests/tests/tests/generated/duplicate_pubkey_not_slashable.json
Outdated
Show resolved
Hide resolved
3xtr4t3rr3str14l
changed the title
|
@dapplion can you re-review or dismiss your review? |
dapplion
reviewed
May 14, 2021
packages/validator/test/e2e/slashing-protection-interchange-tests/run.test.ts
Outdated
Show resolved
Hide resolved
…package) convert slashing interchange protection tests to local tests (no NPM package) remove console.log add v5 interchange support and tests .gitignore downloaded spi tests move downloadTest ensure we are downloading spi tests before running rm @chainsafe/slashing-protection-interchange-tests update yarn.lock rename index.test.ts to downloadTests.ts package.json rm old eventsource types
dapplion
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2001 and adds support for v5 interchange (as spec'd here: https://eips.ethereum.org/EIPS/eip-3076)