Altair 1.1.0-alpha.5 - Beacon Chain #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit cc659de and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Closed
dapplion
reviewed
May 24, 2021
packages/beacon-state-transition/src/allForks/util/epochContext.ts
Outdated
Show resolved
Hide resolved
dapplion
reviewed
May 24, 2021
packages/beacon-state-transition/src/altair/block/processSyncCommittee.ts
Show resolved
Hide resolved
twoeths
commented
May 24, 2021
twoeths
commented
May 25, 2021
dapplion
reviewed
May 27, 2021
| (attestation.aggregationBits as unknown) as TreeBacked<BitList>, | ||
| this.config.types.phase0.CommitteeBits | ||
| ) | ||
| : committeeIndices.filter((_, index) => !!aggregationBits[index]); |
There was a problem hiding this comment.
If this is a hot path in the state transition function we should keep using a for loop for speed
There was a problem hiding this comment.
I use zipIndexesInBitList to improve performance
There was a problem hiding this comment.
Right! I was refering to the alternative path when it's not a tree
There was a problem hiding this comment.
If aggregationBits should always be a tree then the filter is fine
dapplion
reviewed
May 27, 2021
packages/spec-test-runner/test/spec/altair/fork/upgradeState.test.ts
Outdated
Show resolved
Hide resolved
dapplion
reviewed
May 27, 2021
packages/spec-test-runner/test/spec/altair/fork_choice/get_head_minimal.test.ts
Show resolved
Hide resolved
dapplion
reviewed
May 27, 2021
packages/spec-test-runner/test/spec/altair/fork_choice/get_head_minimal.test.ts
Outdated
Show resolved
Hide resolved
dapplion
reviewed
May 27, 2021
packages/spec-test-runner/test/spec/altair/fork_choice/get_head_minimal.test.ts
Outdated
Show resolved
Hide resolved
dapplion
reviewed
May 27, 2021
...c-test-runner/test/spec/altair/operations/attesterSlashing/attester_slashing_minimal.test.ts
Outdated
Show resolved
Hide resolved
dapplion
approved these changes
May 28, 2021
wemeetagain
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Upgrade/fix our fast state transition to 1.1.0-alpha.5
Add all missing minimal spec tests
Improve the way to access
aggregationBitsas inlodestar/packages/beacon-state-transition/test/perf/util/aggregationBits.test.ts
Line 23 in efea313
Improve/fix
processSyncCommitteeto cache participant reward inEpochContextclose Altair 1.1.0-alpha.4 #2530
TODOs