Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ForkService in validator #2583

Merged
merged 3 commits into from
May 28, 2021
Merged

Conversation

dapplion
Copy link
Contributor

Motivation

Reverts #2574 which reverted #2529

The validator has all the necessary fork info already. A routine on start ensure that the validator and beacon node config are equal

private async getDomain(domainType: DomainType, epoch: Epoch): Promise<Buffer> {
// We don't fetch the Fork from the beacon node dynamically.
// The Fork object should not change during the runtime of the validator. When a new planned fork happens
// node operators would have to update the validator client software at least once.
// If we wanted to have long-term independent validator client we can review this approach.
// On start-up the validator client fetches the full config from the beacon node and ensures they match.
const forkVersion = this.config.getForkVersion(computeStartSlotAtEpoch(this.config, epoch));

@wemeetagain wemeetagain merged commit d3985e3 into master May 28, 2021
@wemeetagain wemeetagain deleted the dapplion/validator-config branch May 28, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants