Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined participants #2601

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Fix undefined participants #2601

merged 1 commit into from
Jun 1, 2021

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented May 31, 2021

Motivation

  • The new way to extract aggregationBits causes some undefined participants

Description

  • This is because we don't use up all bytes of the last extracted chunk (32 bytes in total)

Closes #2600

Steps to test or reproduce

Sync Prater

@codeclimate
Copy link

codeclimate bot commented May 31, 2021

Code Climate has analyzed commit 8cbebca and detected 0 issues on this pull request.

View more on Code Climate.

@twoeths twoeths marked this pull request as ready for review May 31, 2021 23:07
@wemeetagain wemeetagain merged commit a518307 into master Jun 1, 2021
@wemeetagain wemeetagain deleted the tuyen/fix-undefined-participant branch June 1, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@dapplion dapplion dapplion approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined participant index
3 participants
@twoeths @wemeetagain @dapplion