Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impove processAttestation for altair #2626

Merged
merged 1 commit into from Jun 4, 2021

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Jun 3, 2021

Motivation

See #2618

Description

Cache baseRewardPerIncrement in epoch context. Increases sync speed by a factor of N where N is the number of validators in the chain (a dramatic improvement).

Closes #2618

@codeclimate
Copy link

codeclimate bot commented Jun 3, 2021

Code Climate has analyzed commit 54ec19e and detected 0 issues on this pull request.

View more on Code Climate.

@dapplion
Copy link
Contributor Author

dapplion commented Jun 3, 2021

I've tested and synced at a pretty good speed. This is good enough for now to keep testing small altair testnets.

@wemeetagain okay to merge

@dapplion dapplion force-pushed the tuyen/improve-process-attestation branch 2 times, most recently from 2a2a132 to 8dea281 Compare June 3, 2021 20:33
twoeths
twoeths previously approved these changes Jun 3, 2021
@twoeths
Copy link
Contributor

twoeths commented Jun 4, 2021

Failed sim test due to #2627

@twoeths twoeths merged commit 6cf8a0e into master Jun 4, 2021
@twoeths twoeths deleted the tuyen/improve-process-attestation branch June 4, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

altair.processAttestation() performance issue
2 participants