Fix getParticipantIndices from SyncAggregate struct #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 12cf112 and detected 0 issues on this pull request. View more on Code Climate. |
dapplion
reviewed
Jun 8, 2021
| participantIndices.push(index); | ||
| } | ||
| } | ||
| return participantIndices; |
There was a problem hiding this comment.
Should we move this to a util function and unit test it?
twoeths
force-pushed
the
tuyen/fix-getParticipantIndices
branch
from
998079c
to
12cf112
Compare
wemeetagain
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
getParticipantIndicesis correct for tree backed object but not structDescription
lodestar/packages/beacon-state-transition/src/allForks/util/epochContext.ts
Line 414 in 0c4f831