Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review benchmark params #2665

Merged
merged 17 commits into from
Jun 10, 2021
Merged

Review benchmark params #2665

merged 17 commits into from
Jun 10, 2021

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Jun 9, 2021

Motivation

Benchmarks currently are very unstable, failing often

Description

  • Increase minimum time per run to not have short runs which add instability.
  • Use beforeEach return to not use scoped variables
  • Add aggregationBits perf test

@codeclimate
Copy link

codeclimate bot commented Jun 9, 2021

Code Climate has analyzed commit 62ee72c and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@github-actions github-actions bot added the CI label Jun 9, 2021
@dapplion dapplion marked this pull request as draft June 9, 2021 17:15
@dapplion dapplion marked this pull request as ready for review June 10, 2021 16:00
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wemeetagain wemeetagain merged commit 0549553 into master Jun 10, 2021
@wemeetagain wemeetagain deleted the dapplion/review-benchmark branch June 10, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants