Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-org aggregationBits utils logic #2687

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Conversation

dapplion
Copy link
Contributor

Motivation

Working on gossip validation I found the need to use this utils but the exposed API is not optimal.

Description

  • Generalize the functions types and sames for CommitteeBits and SyncCommitteeBits
  • De-duplicate code by exposing a single function that accepts TreeBacked and struct
  • Expose convenience functions zipIndexesCommitteeBits, zipIndexesSyncCommitteeBits that already include the types

@codeclimate
Copy link

codeclimate bot commented Jun 11, 2021

Code Climate has analyzed commit 945a46a and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants