Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Slow unit test - getLatestWeakSubjectivityCheckpointEpoch #2564 #2688

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

3xtr4t3rr3str14l
Copy link
Contributor

fixes #2564

@codeclimate
Copy link

codeclimate bot commented Jun 11, 2021

Code Climate has analyzed commit ccfd05e and detected 0 issues on this pull request.

View more on Code Climate.

@wemeetagain wemeetagain merged commit c727611 into master Jun 11, 2021
@wemeetagain wemeetagain deleted the P0/#2564 branch June 11, 2021 21:05
@dapplion
Copy link
Contributor

@3xtr4t3rr3str14l I don't see how this fixes the issue, you are still generating +200_000 validators to test some math.

Can you split the function to test to something like

const parameters = getParametersFromState(state)
const result = doMathWithParameters(parameters)

and test only doMathWithParameters so its not necessary to create a huge state to test math

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow unit test - getLatestWeakSubjectivityCheckpointEpoch
3 participants