De-duplicate code in altair state transition fn #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit ae03492 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
dapplion
force-pushed
the
dapplion/deduplicate-stfn-altair
branch
from
8f69a93
to
243282a
Compare
twoeths
reviewed
Jun 14, 2021
packages/beacon-state-transition/src/phase0/block/processProposerSlashing.ts
Outdated
Show resolved
Hide resolved
twoeths
reviewed
Jun 14, 2021
packages/beacon-state-transition/src/phase0/block/processAttesterSlashing.ts
Outdated
Show resolved
Hide resolved
|
Ready for review |
twoeths
approved these changes
Jun 15, 2021
This was referenced Jul 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
De-duplicate code from altair's state transition fn methods.
Description
Multiplex fork differences inside each function when the differences are small enough. This approach involves one extra function call than necessary but it should be okay in terms of performance.
Closes #2691