Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement altair v1.1.0 beta.2 #2925

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Aug 6, 2021

Motivation

To conform to altair v1.1.0 beta.2

Description

Closes #2924 #2856

@codeclimate
Copy link

codeclimate bot commented Aug 6, 2021

Code Climate has analyzed commit f11c568 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 521c4fa Previous: bea1304 Ratio
getCommitteeAssignments - req 1000 vs - 250000 vc 7.1772 ms/op 7.7644 ms/op 0.92
epoch altair - 250000 vs - 7PWei - processInactivityUpdates 2.2417 s/op 2.7679 s/op 0.81
epoch altair - 250000 vs - 7PWei - processRewardsAndPenalties 871.92 ms/op 847.30 ms/op 1.03
epoch altair - 250000 vs - 7PWei - processParticipationFlagUpdates 313.54 ms/op 340.11 ms/op 0.92
Process block - 250000 vs - 7PWei - with 0 validator exit 471.84 us/op 479.49 us/op 0.98
Process block - 250000 vs - 7PWei - with 1 validator exit 31.158 ms/op 36.390 ms/op 0.86
Process block - 250000 vs - 7PWei - with 16 validator exits 30.181 ms/op 26.682 ms/op 1.13
epoch phase0 - 250000 vs - 7PWei - prepareEpochProcessState 765.78 ms/op 848.78 ms/op 0.90
epoch phase0 - 250000 vs - 7PWei - processRewardsAndPenalties 533.25 ms/op 572.64 ms/op 0.93
epoch phase0 - 250000 vs - 7PWei - processEffectiveBalanceUpdates 144.13 ms/op 132.96 ms/op 1.08
getAttestationDeltas - 250000 vs - 7PWei 122.03 ms/op 114.20 ms/op 1.07
processSlots - 250000 vs - 7PWei - 32 empty slots 5.3792 s/op 5.3798 s/op 1.00
shuffle list - 16384 els 3.0733 ms/op 1.8159 ms/op 1.69
shuffle list - 250000 els 42.688 ms/op 24.715 ms/op 1.73
getPubkeys - persistent - req 1000 vs - 250000 vc 20.282 us/op 18.185 us/op 1.12
BLS verify - blst-native 2.0807 ms/op 2.0260 ms/op 1.03
BLS verifyMultipleSignatures 3 - blst-native 4.3470 ms/op 4.1901 ms/op 1.04
BLS verifyMultipleSignatures 8 - blst-native 9.2966 ms/op 8.8411 ms/op 1.05
BLS verifyMultipleSignatures 32 - blst-native 33.439 ms/op 36.086 ms/op 0.93
BLS aggregatePubkeys 32 - blst-native 46.777 us/op 45.802 us/op 1.02
BLS aggregatePubkeys 128 - blst-native 173.56 us/op 174.99 us/op 0.99
getAttestationsForBlock 141.08 ms/op 87.886 ms/op 1.61
validate gossip signedAggregateAndProof - struct 6.5161 ms/op 7.4572 ms/op 0.87
validate gossip signedAggregateAndProof - treeBacked 5.2689 ms/op 5.3407 ms/op 0.99
validate gossip attestation - struct 2.3614 ms/op 2.3805 ms/op 0.99
validate gossip attestation - treeBacked 2.4042 ms/op 2.5641 ms/op 0.94

by benchmarkbot/action

Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should we add support for the Union type too?

@twoeths
Copy link
Contributor Author

twoeths commented Aug 9, 2021

Thanks! Should we add support for the Union type too?

I'm working on ChainSafe/ssz#135 now

@wemeetagain wemeetagain merged commit 4505b4b into master Aug 9, 2021
@wemeetagain wemeetagain deleted the tuyen/altair-v1.1.0-beta.2 branch August 9, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Altair v1.1.0 - beta.2
3 participants