Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to beforeProcessEpoch and afterProcessEpoch #2927

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Aug 9, 2021

Motivation

Working on optimizing the state transition function caches, I find more intuitive to rename this functions to

beforeProcessEpoch()
processEpoch()
afterProcessEpoch()

Since they do more that just preparing the epoch process.

Description

  • Rename prepareEpochProcessState -> beforeProcessEpoch
  • Rename rotateEpochs -> afterProcessEpoch

@codeclimate
Copy link

codeclimate bot commented Aug 9, 2021

Code Climate has analyzed commit 96d5d18 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 4e9176f Previous: d0ffc01 Ratio
getCommitteeAssignments - req 1000 vs - 250000 vc 9.1467 ms/op 7.8031 ms/op 1.17
epoch altair - 250000 vs - 7PWei - processInactivityUpdates 2.3501 s/op 1.8623 s/op 1.26
epoch altair - 250000 vs - 7PWei - processRewardsAndPenalties 1.0191 s/op 840.01 ms/op 1.21
epoch altair - 250000 vs - 7PWei - processParticipationFlagUpdates 325.45 ms/op 302.03 ms/op 1.08
Process block - 250000 vs - 7PWei - with 0 validator exit 468.17 us/op 402.99 us/op 1.16
Process block - 250000 vs - 7PWei - with 1 validator exit 26.978 ms/op 42.090 ms/op 0.64
Process block - 250000 vs - 7PWei - with 16 validator exits 28.724 ms/op 23.059 ms/op 1.25
epoch phase0 - 250000 vs - 7PWei - beforeProcessEpoch 710.89 ms/op
epoch phase0 - 250000 vs - 7PWei - processRewardsAndPenalties 510.41 ms/op 531.49 ms/op 0.96
epoch phase0 - 250000 vs - 7PWei - processEffectiveBalanceUpdates 125.18 ms/op 104.08 ms/op 1.20
getAttestationDeltas - 250000 vs - 7PWei 116.64 ms/op 84.388 ms/op 1.38
processSlots - 250000 vs - 7PWei - 32 empty slots 5.3891 s/op 4.7108 s/op 1.14
shuffle list - 16384 els 1.9851 ms/op 1.6742 ms/op 1.19
shuffle list - 250000 els 28.192 ms/op 23.911 ms/op 1.18
getPubkeys - persistent - req 1000 vs - 250000 vc 19.674 us/op 17.650 us/op 1.11
BLS verify - blst-native 2.1947 ms/op 1.8594 ms/op 1.18
BLS verifyMultipleSignatures 3 - blst-native 4.5195 ms/op 3.8101 ms/op 1.19
BLS verifyMultipleSignatures 8 - blst-native 9.7071 ms/op 8.2137 ms/op 1.18
BLS verifyMultipleSignatures 32 - blst-native 37.945 ms/op 32.379 ms/op 1.17
BLS aggregatePubkeys 32 - blst-native 47.871 us/op 40.073 us/op 1.19
BLS aggregatePubkeys 128 - blst-native 183.44 us/op 155.41 us/op 1.18
getAttestationsForBlock 88.712 ms/op 85.200 ms/op 1.04
validate gossip signedAggregateAndProof - struct 7.6331 ms/op 6.1898 ms/op 1.23
validate gossip signedAggregateAndProof - treeBacked 5.3574 ms/op 4.5662 ms/op 1.17
validate gossip attestation - struct 2.4923 ms/op 2.1206 ms/op 1.18
validate gossip attestation - treeBacked 2.5317 ms/op 2.1627 ms/op 1.17

by benchmarkbot/action

@wemeetagain wemeetagain merged commit a54a1ea into master Aug 9, 2021
@wemeetagain wemeetagain deleted the dapplion/beforeEpochTransition branch August 9, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants