-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move exitQueue cache values to epochContext #2928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
August 9, 2021 19:47
Code Climate has analyzed commit 3e3eb4a and detected 0 issues on this pull request. View more on Code Climate. |
dapplion
force-pushed
the
dapplion/exitqueue
branch
from
August 9, 2021 19:53
d8ea873
to
efb3e13
Compare
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
dapplion
force-pushed
the
dapplion/exitqueue
branch
2 times, most recently
from
August 10, 2021 10:05
707b896
to
a3cdca1
Compare
dapplion
force-pushed
the
dapplion/exitqueue
branch
from
August 10, 2021 11:47
43fe18f
to
0a7cdf6
Compare
wemeetagain
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To speed up validator exits @tuyennhv added an optimization in #2695 to loop over validators one per exits on a block. This optimization can be taken further since the expensive computations can be done once per epoch only. Also the exitQueueEpoch and churn are already computed in epoch process.
Description
Moves exitQueueEpoch, exitQueueChurn and churnLimit cached values from blockProcess and epochProcess to epochContext. The values are available to epoch processing and block processing. Now no extra loop over the validators tree is necessary to initiate exits. Those constants are copied on epochCtx.copy() so they can be safely mutated on different forks.