Use same naming as spec for indicesEligibleForActivation

[dapplion]

Motivation

To follow the code and spec more easily, these names match the spec functions

Description

Rename:

• indicesToSetActivationEligibility -> indicesEligibleForActivationQueue
• indicesToMaybeActivate -> indicesEligibleForActivation

[codeclimate]

Code Climate has analyzed commit 4715055 and detected 0 issues on this pull request.

View more on Code Climate.

[github-actions]

Performance Report

✔️ no performance regression detected

Full benchmark results

Benchmark suite	Current: da6ba49	Previous: a54a1ea	Ratio
getCommitteeAssignments - req 1000 vs - 250000 vc	8.9355 ms/op	8.1085 ms/op	1.10
epoch altair - 250000 vs - 7PWei - processInactivityUpdates	2.1099 s/op	2.4653 s/op	0.86
epoch altair - 250000 vs - 7PWei - processRewardsAndPenalties	893.38 ms/op	1.0149 s/op	0.88
epoch altair - 250000 vs - 7PWei - processParticipationFlagUpdates	326.75 ms/op	351.50 ms/op	0.93
Process block - 250000 vs - 7PWei - with 0 validator exit	414.89 us/op	518.27 us/op	0.80
Process block - 250000 vs - 7PWei - with 1 validator exit	38.531 ms/op	26.891 ms/op	1.43
Process block - 250000 vs - 7PWei - with 16 validator exits	22.869 ms/op	31.234 ms/op	0.73
epoch phase0 - 250000 vs - 7PWei - beforeProcessEpoch	739.52 ms/op	779.75 ms/op	0.95
epoch phase0 - 250000 vs - 7PWei - processRewardsAndPenalties	455.63 ms/op	494.30 ms/op	0.92
epoch phase0 - 250000 vs - 7PWei - processEffectiveBalanceUpdates	109.04 ms/op	103.36 ms/op	1.05
getAttestationDeltas - 250000 vs - 7PWei	98.687 ms/op	115.89 ms/op	0.85
processSlots - 250000 vs - 7PWei - 32 empty slots	5.0843 s/op	5.5316 s/op	0.92
shuffle list - 16384 els	1.8666 ms/op	1.7858 ms/op	1.05
shuffle list - 250000 els	26.792 ms/op	25.400 ms/op	1.05
getPubkeys - persistent - req 1000 vs - 250000 vc	19.823 us/op	17.839 us/op	1.11
BLS verify - blst-native	2.1035 ms/op	2.0838 ms/op	1.01
BLS verifyMultipleSignatures 3 - blst-native	4.3027 ms/op	4.2749 ms/op	1.01
BLS verifyMultipleSignatures 8 - blst-native	9.3035 ms/op	9.2233 ms/op	1.01
BLS verifyMultipleSignatures 32 - blst-native	36.646 ms/op	34.087 ms/op	1.08
BLS aggregatePubkeys 32 - blst-native	45.461 us/op	46.882 us/op	0.97
BLS aggregatePubkeys 128 - blst-native	176.20 us/op	182.35 us/op	0.97
getAttestationsForBlock	81.538 ms/op	117.60 ms/op	0.69
validate gossip signedAggregateAndProof - struct	6.9832 ms/op	6.9494 ms/op	1.00
validate gossip signedAggregateAndProof - treeBacked	5.1539 ms/op	5.1890 ms/op	0.99
validate gossip attestation - struct	2.3873 ms/op	2.4036 ms/op	0.99
validate gossip attestation - treeBacked	2.4381 ms/op	2.5281 ms/op	0.96

by benchmarkbot/action