-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comments to processBlock functions #2940
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
August 10, 2021 20:06
Code Climate has analyzed commit 2da4c4a and detected 0 issues on this pull request. View more on Code Climate. |
wemeetagain
previously approved these changes
Aug 10, 2021
wemeetagain
previously approved these changes
Aug 10, 2021
twoeths
previously approved these changes
Aug 11, 2021
dapplion
force-pushed
the
dapplion/block-fn-comments
branch
from
August 11, 2021 07:17
5a64fa7
to
2da4c4a
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add context for future optimizations
Description
Add a short description about function purpose + relevant performance info about the function cost