Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to processBlock functions #2940

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Conversation

dapplion
Copy link
Contributor

Motivation

Add context for future optimizations

Description

Add a short description about function purpose + relevant performance info about the function cost

@codeclimate
Copy link

codeclimate bot commented Aug 10, 2021

Code Climate has analyzed commit 2da4c4a and detected 0 issues on this pull request.

View more on Code Climate.

wemeetagain
wemeetagain previously approved these changes Aug 10, 2021
wemeetagain
wemeetagain previously approved these changes Aug 10, 2021
@wemeetagain wemeetagain reopened this Aug 10, 2021
twoeths
twoeths previously approved these changes Aug 11, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2021

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 39cf947 Previous: fb5e41f Ratio
getCommitteeAssignments - req 1000 vs - 250000 vc 8.1511 ms/op 9.8207 ms/op 0.83
processBlock altair 250000 vs - 7PWei - maxed ops 494.04 ms/op 506.91 ms/op 0.97
processBlock altair 250000 vs - 7PWei - average 189.55 ms/op 194.22 ms/op 0.98
epoch altair - 250000 vs - 7PWei - processInactivityUpdates 2.5642 s/op 2.5514 s/op 1.01
epoch altair - 250000 vs - 7PWei - processRewardsAndPenalties 1.0476 s/op 1.2361 s/op 0.85
epoch altair - 250000 vs - 7PWei - processParticipationFlagUpdates 469.30 ms/op 504.85 ms/op 0.93
processBlock phase0 250000 vs - 7PWei - maxed ops 214.01 ms/op 213.14 ms/op 1.00
processBlock phase0 250000 vs - 7PWei - average 29.149 ms/op 32.687 ms/op 0.89
epoch phase0 - 250000 vs - 7PWei - beforeProcessEpoch 1.6825 s/op 1.7609 s/op 0.96
epoch phase0 - 250000 vs - 7PWei - processRewardsAndPenalties 782.14 ms/op 755.51 ms/op 1.04
epoch phase0 - 250000 vs - 7PWei - processEffectiveBalanceUpdates 152.95 ms/op 61.139 ms/op 2.50
getAttestationDeltas - 250000 vs - 7PWei 118.60 ms/op 125.78 ms/op 0.94
processSlots - 250000 vs - 7PWei - 32 empty slots 3.3177 s/op 3.5863 s/op 0.93
shuffle list - 16384 els 16.518 ms/op 28.938 ms/op 0.57
shuffle list - 250000 els 236.07 ms/op 419.15 ms/op 0.56
getPubkeys - persistent - req 1000 vs - 250000 vc 19.643 us/op 22.758 us/op 0.86
BLS verify - blst-native 2.1759 ms/op 2.3350 ms/op 0.93
BLS verifyMultipleSignatures 3 - blst-native 4.4720 ms/op 4.7772 ms/op 0.94
BLS verifyMultipleSignatures 8 - blst-native 9.4378 ms/op 10.282 ms/op 0.92
BLS verifyMultipleSignatures 32 - blst-native 34.601 ms/op 37.274 ms/op 0.93
BLS aggregatePubkeys 32 - blst-native 47.442 us/op 52.330 us/op 0.91
BLS aggregatePubkeys 128 - blst-native 182.57 us/op 194.99 us/op 0.94
getAttestationsForBlock 683.96 ms/op 939.44 ms/op 0.73
validate gossip signedAggregateAndProof - struct 5.2961 ms/op 5.6032 ms/op 0.95
validate gossip signedAggregateAndProof - treeBacked 5.2986 ms/op 5.5620 ms/op 0.95
validate gossip attestation - struct 2.5811 ms/op 2.6110 ms/op 0.99
validate gossip attestation - treeBacked 2.5094 ms/op 2.6599 ms/op 0.94

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 9a9a2dd into master Aug 12, 2021
@wemeetagain wemeetagain deleted the dapplion/block-fn-comments branch August 12, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants