Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance comments to processEpoch functions #2944

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

dapplion
Copy link
Contributor

Motivation

Fine tune the benchmark test cases to reflect regular network conditions and worst cases spec compliant.

Description

Add descriptions to all processEpoch functions with an aprox description of their performance cost and with what factors does it vary.

@codeclimate
Copy link

codeclimate bot commented Aug 10, 2021

Code Climate has analyzed commit 9a7ae27 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: d6a297f Previous: c09ea9a Ratio
getCommitteeAssignments - req 1000 vs - 250000 vc 7.7402 ms/op 9.2084 ms/op 0.84
processBlock altair 250000 vs - 7PWei - maxed ops 473.37 ms/op 563.59 ms/op 0.84
processBlock altair 250000 vs - 7PWei - average 176.82 ms/op 220.05 ms/op 0.80
epoch altair - 250000 vs - 7PWei - processInactivityUpdates 2.4698 s/op 2.6754 s/op 0.92
epoch altair - 250000 vs - 7PWei - processRewardsAndPenalties 984.34 ms/op 1.1298 s/op 0.87
epoch altair - 250000 vs - 7PWei - processParticipationFlagUpdates 499.57 ms/op 578.71 ms/op 0.86
processBlock phase0 250000 vs - 7PWei - maxed ops 216.19 ms/op 240.26 ms/op 0.90
processBlock phase0 250000 vs - 7PWei - average 27.481 ms/op 30.951 ms/op 0.89
epoch phase0 - 250000 vs - 7PWei - beforeProcessEpoch 1.6677 s/op 2.0031 s/op 0.83
epoch phase0 - 250000 vs - 7PWei - processRewardsAndPenalties 690.28 ms/op 918.98 ms/op 0.75
epoch phase0 - 250000 vs - 7PWei - processEffectiveBalanceUpdates 52.337 ms/op 135.53 ms/op 0.39
getAttestationDeltas - 250000 vs - 7PWei 117.57 ms/op 124.54 ms/op 0.94
processSlots - 250000 vs - 7PWei - 32 empty slots 3.3406 s/op 3.6104 s/op 0.93
shuffle list - 16384 els 25.001 ms/op 30.941 ms/op 0.81
shuffle list - 250000 els 345.57 ms/op 298.32 ms/op 1.16
getPubkeys - persistent - req 1000 vs - 250000 vc 18.249 us/op 20.070 us/op 0.91
BLS verify - blst-native 2.4604 ms/op 2.3405 ms/op 1.05
BLS verifyMultipleSignatures 3 - blst-native 5.0635 ms/op 4.8100 ms/op 1.05
BLS verifyMultipleSignatures 8 - blst-native 10.919 ms/op 10.355 ms/op 1.05
BLS verifyMultipleSignatures 32 - blst-native 42.971 ms/op 37.961 ms/op 1.13
BLS aggregatePubkeys 32 - blst-native 54.618 us/op 78.616 us/op 0.69
BLS aggregatePubkeys 128 - blst-native 211.14 us/op 210.14 us/op 1.00
getAttestationsForBlock 78.750 ms/op 89.045 ms/op 0.88
validate gossip signedAggregateAndProof - struct 5.9282 ms/op 5.7115 ms/op 1.04
validate gossip signedAggregateAndProof - treeBacked 5.8978 ms/op 5.6947 ms/op 1.04
validate gossip attestation - struct 2.7665 ms/op 2.6666 ms/op 1.04
validate gossip attestation - treeBacked 2.9562 ms/op 2.6806 ms/op 1.10

by benchmarkbot/action

@wemeetagain wemeetagain merged commit a6a41ab into master Aug 10, 2021
@wemeetagain wemeetagain deleted the dapplion/epoch-perf branch August 10, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants