Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no default read of the configFile and paramsFile, persistence of these files removed #3073

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Sep 3, 2021

Motivation
PR removes default reading of the configFile and paramsFile files without explicit flags. also when flags provided but files don't exists logs error onto the terminal to bring it to the user attentions as follows:

image

Description

partially closes #2983
Steps to test or reproduce

@codeclimate
Copy link

codeclimate bot commented Sep 3, 2021

Code Climate has analyzed commit 511fd58 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! If the user provided a flag for a file and the file is not found, the CLI must error and stop, not show an error and continue.

Also please check CI, type errors

@g11tech
Copy link
Contributor Author

g11tech commented Sep 3, 2021

Thanks for the PR! If the user provided a flag for a file and the file is not found, the CLI must error and stop, not show an error and continue.

Also please check CI, type errors

@dapplion understood for cli to throw error.
e2e test cases that are failing are where we init (init.test.ts), and then test the beacon config file options that are written. these test cases won't make sense in the new scheme. should i just remove them for now and later figure out a way to test the executed configuration?

@g11tech
Copy link
Contributor Author

g11tech commented Sep 3, 2021

or we dump the options like before (in a separate beaon.config.dump.json, network.params.dump.yml , just to inspect/run test cases against them)

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #3073 (1de5119) into master (1ad9929) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 1de5119 differs from pull request most recent head 511fd58. Consider uploading reports for the commit 511fd58 to get more accurate results

@@            Coverage Diff             @@
##           master    #3073      +/-   ##
==========================================
- Coverage   59.15%   59.09%   -0.06%     
==========================================
  Files         377      377              
  Lines        9066     9065       -1     
  Branches     1336     1334       -2     
==========================================
- Hits         5363     5357       -6     
- Misses       3320     3325       +5     
  Partials      383      383              

dapplion
dapplion previously approved these changes Sep 9, 2021
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!

@dapplion dapplion merged commit 623fd0e into ChainSafe:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persisted config overwrites new Pyrmont fork config
3 participants