-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no default read of the configFile and paramsFile, persistence of these files removed #3073
Conversation
Code Climate has analyzed commit 511fd58 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! If the user provided a flag for a file and the file is not found, the CLI must error and stop, not show an error and continue.
Also please check CI, type errors
@dapplion understood for cli to throw error. |
or we dump the options like before (in a separate beaon.config.dump.json, network.params.dump.yml , just to inspect/run test cases against them) |
Codecov Report
@@ Coverage Diff @@
## master #3073 +/- ##
==========================================
- Coverage 59.15% 59.09% -0.06%
==========================================
Files 377 377
Lines 9066 9065 -1
Branches 1336 1334 -2
==========================================
- Hits 5363 5357 -6
- Misses 3320 3325 +5
Partials 383 383 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks!
Motivation
PR removes default reading of the configFile and paramsFile files without explicit flags. also when flags provided but files don't exists logs error onto the terminal to bring it to the user attentions as follows:
Description
partially closes #2983
Steps to test or reproduce