Precompute epoch transition #3383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoeths
requested review from
dapplion,
mpetrunic and
wemeetagain
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3383 +/- ##
==========================================
- Coverage 38.36% 38.07% -0.30%
==========================================
Files 303 304 +1
Lines 7738 7843 +105
Branches 1157 1189 +32
==========================================
+ Hits 2969 2986 +17
- Misses 4628 4716 +88
Partials 141 141 |
|
Code Climate has analyzed commit 48b8e51 and detected 0 issues on this pull request. View more on Code Climate. |
Performance Report✔️ no performance regression detected Full benchmark results
|
g11tech
previously approved these changes
Oct 22, 2021
wemeetagain
reviewed
Oct 25, 2021
|
Tested this for a while:
|
dapplion
reviewed
Oct 28, 2021
dapplion
reviewed
Oct 28, 2021
dapplion
reviewed
Oct 28, 2021
twoeths
force-pushed
the
tuyen/precompute-epoch-transition
branch
from
371622d
to
644b60b
Compare
|
New precompute epoch metrics:
|
dapplion
reviewed
Oct 29, 2021
| @@ -538,5 +538,22 @@ export function createLodestarMetrics( | |||
| name: "unhandeled_promise_rejections", | |||
| help: "UnhandeledPromiseRejection count", | |||
| }), | |||
|
|
|||
| // Precompute epoch | |||
| preComputeEpoch: { | |||
There was a problem hiding this comment.
The name preComputeEpoch is bit too generic could we do precomputeNextEpochTransition? If sounds good please rename files and classes on all the PR
dapplion
reviewed
Oct 29, 2021
| // Precompute epoch | ||
| preComputeEpoch: { | ||
| count: register.counter<"result">({ | ||
| name: "precompute_epoch_result", |
dapplion
reviewed
Oct 29, 2021
| count: register.counter<"result">({ | ||
| name: "precompute_epoch_result", | ||
| labelNames: ["result"], | ||
| help: "Number of precompute epoch skip/success/error", |
There was a problem hiding this comment.
Total number of precomputeNextEpochTransition runs by result
dapplion
reviewed
Oct 29, 2021
| .getBlockSlotState(blockRoot, nextSlot, RegenCaller.preComputeEpoch) | ||
| .then(() => { | ||
| this.metrics?.preComputeEpoch.count.inc({result: "success"}, 1); | ||
| const previousHits = this.chain.checkpointStateCache.updatePreComputedCheckpoint(blockRoot, nextEpoch); |
There was a problem hiding this comment.
Can you find a a way to track this without adding custom code in the checkpointStateCache? Ideally this class should have sufficient info to know if the previous run was re-orged or not.
There was a problem hiding this comment.
@dapplion even when our node is reorged, it does not mean the pre computed epoch transition is wasteful as some nodes can still send attestations with our old/obsolete target checkpoint and we still need that cached target checkpoint. So for this waste metric, it does not depend on the node being re-orged or not, it depends on the produced checkpoint state is used or not.
There was a problem hiding this comment.
Yeah, that's true. Let's leave it like this then
twoeths
force-pushed
the
tuyen/precompute-epoch-transition
branch
from
13f97c0
to
48b8e51
Compare
wemeetagain
requested changes
Nov 3, 2021
wemeetagain
approved these changes
Nov 4, 2021
dapplion
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Closes Early epoch transition when node is synced #3382
Test