Fix peer score serialization #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoeths
requested review from
dapplion,
mpetrunic and
wemeetagain
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3520 +/- ##
==========================================
- Coverage 37.90% 37.89% -0.02%
==========================================
Files 308 308
Lines 8129 8134 +5
Branches 1248 1250 +2
==========================================
+ Hits 3081 3082 +1
- Misses 4900 4904 +4
Partials 148 148 |
|
Code Climate has analyzed commit 161b732 and detected 0 issues on this pull request. View more on Code Climate. |
twoeths
commented
Dec 15, 2021
| * https://github.com/multiformats/js-multistream-select/blame/cf4e297b362a43bde2ea117085ceba78cbce1c12/src/select.js#L50 | ||
| */ | ||
| const multiStreamSelectErrorCodes = { | ||
| protocolSelectionFailed: "protocol selection failed", |
There was a problem hiding this comment.
once this error happens, it'll happen all the time and the peer is useless to us. It's similar to the ERR_UNSUPPORTED_PROTOCOL error below
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
DIAL_ERROR, I don't see we say goodbye to peers with "Peer score too low" or "Peer banned""protocol selection failed"and it's still in our connected peer without being bannedDescription
Right now we use
ssz.Number64type to serialize/deserialize peer score which is float, a peer score of-20is serialized and deserialized back as a very big uint64Use a new
floatSerdeswhich is similar tostringSerdesbut we parse float as an extra stepIf method is
pingand we get"protocol selection failed", ban the peer immediatelyCloses #3517
Tested in contabo-19
