-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle errors thrown by EL's executePayload #3545
Conversation
Code Climate has analyzed commit 2293644 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3545 +/- ##
==========================================
- Coverage 37.56% 37.43% -0.13%
==========================================
Files 310 311 +1
Lines 8253 8307 +54
Branches 1273 1286 +13
==========================================
+ Hits 3100 3110 +10
- Misses 5005 5049 +44
Partials 148 148 |
@dapplion reverted the retry mechanism(s). Kindly review. Would want to tackle the retry mechanism of executionEngine(#3567) in separate PR (along with through review of as how jsonRPC client behaves in various unavailability scenarios) as the aim of this PR is to prevent down-scoring peers because of EL errors. |
Been running locally on kintsugi for an hour+ now with EL shutdown, peer count still strong 25. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Excellent work
Motivation
Currently in kintsugi devnets it has been observed that EL throws error like
internal error
,invalid merkles
and sometimesconnection refused
. There could be host of other scenarios where EL is not able to respond. This causes block to be treated as invalid in the current handling, leading to downscoring of the peers.In a very limited peer scenario, lodestar eventually kicks all peers and goes out of sync unless peerstore is removed.
This PR
warn
for him to check and take appropriate action/investigation.and unnecessary/invalid down-scoring of the peer is also prevented.
Closes #3537