Create RELEASE.md #3587
Merged
Create RELEASE.md #3587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philknows
added
the
scope-documentation
philknows
requested review from
ColinSchwarz,
mpetrunic and
RyRy79261
as code owners
|
Code Climate has analyzed commit 8296990 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3587 +/- ##
==========================================
- Coverage 37.52% 36.25% -1.28%
==========================================
Files 311 312 +1
Lines 8348 8859 +511
Branches 1293 1434 +141
==========================================
+ Hits 3133 3212 +79
- Misses 5066 5496 +430
- Partials 149 151 +2 |
Performance Report✔️ no performance regression detected Full benchmark results
|
dadepo
reviewed
Jan 7, 2022
wemeetagain
reviewed
Jan 8, 2022
|
|
||
| ## Stable Release | ||
| When pre-release candidates have met the testing requirements, we execute `release.yml`. | ||
|
|
There was a problem hiding this comment.
We should include a section on minor/patch releases, eg: v0.33.1
There was a problem hiding this comment.
Added this. Going off of what semver 2.0.0 describes as minor/patch releases.
There was a problem hiding this comment.
I was thinking more about when we decide to release them. I think its also related to the maintenance window for a release.
In the past, we've cut a patch release when our previous release had a glaring bug in it.
And we never went back to prior releases and patched them. The current release was the only maintained release that got patches.
There was a problem hiding this comment.
Agree with @wemeetagain above point
There was a problem hiding this comment.
For patch releases to fix a published stable version, I think it's important to get those fixes out there ASAP and to patch previous versions as well. These would generally be for high and critical types of bugs you're referring to? Do we want to add any specific parameters to include with it?
dapplion
reviewed
Jan 8, 2022
dapplion
reviewed
Jan 11, 2022
dapplion
previously approved these changes
Jan 11, 2022
g11tech
previously approved these changes
Jan 11, 2022
dadepo
reviewed
Jan 12, 2022
dadepo
reviewed
Jan 12, 2022
dapplion
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persisting release information into the main directory for reference. To help close #3036.