-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CL 1.1.8: Rename fork merge to bellatrix #3607
Conversation
Code Climate has analyzed commit 4924b4f and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3607 +/- ##
=======================================
Coverage 37.45% 37.45%
=======================================
Files 311 311
Lines 8364 8364
Branches 1297 1297
=======================================
Hits 3133 3133
Misses 5082 5082
Partials 149 149 |
Performance Report✔️ no performance regression detected Full benchmark results
|
1dd1f78
to
eb31c17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go! Bellatrix ⭐
Motivation
As per specs CL 1.1.8, fork
merge
is being renamed tobellatrix
as merge will be more specifically used for the event of merge of EL into PoS.FYI Empty place holder files are for
bellatrix/transition
andbellatrix/fork
scenarios planned to be added as a separate PR, tracked here: #3541This PR renames the relevant fields, files, types from fork
merge
tobellatrix
Closes #3575