Upgrade to spec 1.1.6 sans proposer boost #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
requested review from
dapplion,
mpetrunic,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit 9e505c7 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3608 +/- ##
=======================================
Coverage 37.50% 37.50%
=======================================
Files 311 311
Lines 8357 8357
Branches 1295 1295
=======================================
Hits 3134 3134
Misses 5074 5074
Partials 149 149 |
g11tech
commented
Jan 12, 2022
| @@ -157,6 +157,11 @@ export function forkChoiceTest(fork: ForkName): void { | |||
| timeout: 10000, | |||
| // eslint-disable-next-line @typescript-eslint/no-empty-function | |||
| expectFunc: () => {}, | |||
| shouldSkip: (_testCase, name, _index) => { | |||
| const ignoreTestsWithKeywords = ["proposer_boost"]; | |||
There was a problem hiding this comment.
This skip will be removed with the PR:#3540, has been added as part of strategy to update the spec version in easier manageable PRs
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Spec 1.1.6 has following changes pending apart from proposer boost
Description
Details
merge/transitiontests to be added as separate PR: tracked here: Add missingbellatrixtests to spec runner #3541Part of #3483