Increase default timeout of api instances except for validator duties #3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
requested review from
dapplion,
mpetrunic,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit 3bd7241 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3684 +/- ##
=======================================
Coverage 37.20% 37.20%
=======================================
Files 322 322
Lines 8717 8717
Branches 1349 1349
=======================================
Hits 3243 3243
Misses 5332 5332
Partials 142 142 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A user reported over discord that lodestar was timing out doing a wss state fetch from infura. On a bit of digging through, figured out that lodestar uses timeout of 12 seconds, which is fine for validator calling beacon api, but could be relaxed else where, as discussed with @dapplion here on discord
Description
This PR raises the default api timeout from 12 seconds to 40 seconds, which should be a comfortable range for downloading the mainnet sync state and adds couple of comments to enure/highlight validator using a strict 1 slot timeout.