Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable arm64 docker build #3734

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Disable arm64 docker build #3734

merged 1 commit into from
Feb 9, 2022

Conversation

wemeetagain
Copy link
Member

Motivation

See https://github.com/ChainSafe/lodestar/runs/5113003430?check_suite_focus=true
and
ChainSafe/blst-ts#51

After #3698 , the docker build is breaking because blst isn't prebuilt for arm64, and the final docker layer doesn't have build tools to build blst itself.

We should first resolve ChainSafe/blst-ts#51, then revert this when we're ready.

Description

Quick way to resolve the currently breaking docker build, just don't build the arm64 image.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #3734 (de17043) into master (37a6b2f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3734   +/-   ##
=======================================
  Coverage   37.14%   37.14%           
=======================================
  Files         320      320           
  Lines        8722     8722           
  Branches     1356     1356           
=======================================
  Hits         3240     3240           
  Misses       5340     5340           
  Partials      142      142

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 6d8597b Previous: 37a6b2f Ratio
BeaconState.hashTreeRoot - No change 542.00 ns/op 726.00 ns/op 0.75
BeaconState.hashTreeRoot - 1 full validator 129.00 us/op 152.13 us/op 0.85
BeaconState.hashTreeRoot - 32 full validator 1.8995 ms/op 2.2798 ms/op 0.83
BeaconState.hashTreeRoot - 512 full validator 25.348 ms/op 31.699 ms/op 0.80
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 123.94 us/op 163.86 us/op 0.76
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.0759 ms/op 2.5816 ms/op 0.80
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 27.980 ms/op 35.296 ms/op 0.79
BeaconState.hashTreeRoot - 1 balances 94.146 us/op 108.93 us/op 0.86
BeaconState.hashTreeRoot - 32 balances 764.90 us/op 965.46 us/op 0.79
BeaconState.hashTreeRoot - 512 balances 7.4050 ms/op 9.1212 ms/op 0.81
BeaconState.hashTreeRoot - 250000 balances 144.41 ms/op 161.40 ms/op 0.89
processSlot - 1 slots 45.762 us/op 54.246 us/op 0.84
processSlot - 32 slots 2.8434 ms/op 3.5110 ms/op 0.81
getCommitteeAssignments - req 1 vs - 250000 vc 5.3391 ms/op 6.4242 ms/op 0.83
getCommitteeAssignments - req 100 vs - 250000 vc 7.4381 ms/op 9.0015 ms/op 0.83
getCommitteeAssignments - req 1000 vs - 250000 vc 7.9154 ms/op 9.5171 ms/op 0.83
computeProposers - vc 250000 19.942 ms/op 25.175 ms/op 0.79
computeEpochShuffling - vc 250000 184.45 ms/op 222.68 ms/op 0.83
getNextSyncCommittee - vc 250000 329.53 ms/op 412.12 ms/op 0.80
altair processAttestation - 250000 vs - 7PWei normalcase 36.289 ms/op 49.873 ms/op 0.73
altair processAttestation - 250000 vs - 7PWei worstcase 35.162 ms/op 41.528 ms/op 0.85
altair processAttestation - setStatus - 1/6 committees join 10.780 ms/op 13.587 ms/op 0.79
altair processAttestation - setStatus - 1/3 committees join 22.007 ms/op 29.775 ms/op 0.74
altair processAttestation - setStatus - 1/2 committees join 33.532 ms/op 42.389 ms/op 0.79
altair processAttestation - setStatus - 2/3 committees join 45.355 ms/op 58.772 ms/op 0.77
altair processAttestation - setStatus - 4/5 committees join 55.546 ms/op 69.119 ms/op 0.80
altair processAttestation - setStatus - 100% committees join 72.517 ms/op 92.320 ms/op 0.79
altair processAttestation - updateEpochParticipants - 1/6 committees join 12.358 ms/op 15.328 ms/op 0.81
altair processAttestation - updateEpochParticipants - 1/3 committees join 21.363 ms/op 31.354 ms/op 0.68
altair processAttestation - updateEpochParticipants - 1/2 committees join 25.301 ms/op 64.952 ms/op 0.39
altair processAttestation - updateEpochParticipants - 2/3 committees join 23.437 ms/op 23.099 ms/op 1.01
altair processAttestation - updateEpochParticipants - 4/5 committees join 24.576 ms/op 24.702 ms/op 0.99
altair processAttestation - updateEpochParticipants - 100% committees join 29.075 ms/op 27.374 ms/op 1.06
altair processAttestation - updateAllStatus 19.667 ms/op 22.683 ms/op 0.87
altair processBlock - 250000 vs - 7PWei normalcase 34.098 ms/op 38.349 ms/op 0.89
altair processBlock - 250000 vs - 7PWei worstcase 105.50 ms/op 126.61 ms/op 0.83
altair processEpoch - mainnet_e81889 1.0490 s/op 1.2608 s/op 0.83
mainnet_e81889 - altair beforeProcessEpoch 325.75 ms/op 309.80 ms/op 1.05
mainnet_e81889 - altair processJustificationAndFinalization 82.502 us/op 64.576 us/op 1.28
mainnet_e81889 - altair processInactivityUpdates 18.324 ms/op 21.422 ms/op 0.86
mainnet_e81889 - altair processRewardsAndPenalties 229.86 ms/op 325.57 ms/op 0.71
mainnet_e81889 - altair processRegistryUpdates 8.1210 us/op 10.731 us/op 0.76
mainnet_e81889 - altair processSlashings 1.9100 us/op 3.1790 us/op 0.60
mainnet_e81889 - altair processEth1DataReset 1.5380 us/op 2.8720 us/op 0.54
mainnet_e81889 - altair processEffectiveBalanceUpdates 6.9437 ms/op 7.9752 ms/op 0.87
mainnet_e81889 - altair processSlashingsReset 9.1090 us/op 18.682 us/op 0.49
mainnet_e81889 - altair processRandaoMixesReset 13.495 us/op 21.270 us/op 0.63
mainnet_e81889 - altair processHistoricalRootsUpdate 1.2950 us/op 3.7890 us/op 0.34
mainnet_e81889 - altair processParticipationFlagUpdates 70.516 ms/op 99.010 ms/op 0.71
mainnet_e81889 - altair processSyncCommitteeUpdates 1.4500 us/op 2.5000 us/op 0.58
mainnet_e81889 - altair afterProcessEpoch 224.07 ms/op 267.66 ms/op 0.84
altair processInactivityUpdates - 250000 normalcase 74.590 ms/op 82.291 ms/op 0.91
altair processInactivityUpdates - 250000 worstcase 72.155 ms/op 99.682 ms/op 0.72
altair processParticipationFlagUpdates - 250000 anycase 63.767 ms/op 67.572 ms/op 0.94
altair processRewardsAndPenalties - 250000 normalcase 236.94 ms/op 258.94 ms/op 0.92
altair processRewardsAndPenalties - 250000 worstcase 210.81 ms/op 257.80 ms/op 0.82
altair processSyncCommitteeUpdates - 250000 370.88 ms/op 427.23 ms/op 0.87
Tree 40 250000 create 841.11 ms/op 869.15 ms/op 0.97
Tree 40 250000 get(125000) 326.38 ns/op 398.47 ns/op 0.82
Tree 40 250000 set(125000) 1.8768 us/op 2.6868 us/op 0.70
Tree 40 250000 toArray() 45.460 ms/op 53.091 ms/op 0.86
Tree 40 250000 iterate all - toArray() + loop 39.613 ms/op 44.820 ms/op 0.88
Tree 40 250000 iterate all - get(i) 119.97 ms/op 141.18 ms/op 0.85
MutableVector 250000 create 25.346 ms/op 29.907 ms/op 0.85
MutableVector 250000 get(125000) 12.573 ns/op 15.704 ns/op 0.80
MutableVector 250000 set(125000) 537.36 ns/op 617.64 ns/op 0.87
MutableVector 250000 toArray() 8.7841 ms/op 10.507 ms/op 0.84
MutableVector 250000 iterate all - toArray() + loop 9.2423 ms/op 10.694 ms/op 0.86
MutableVector 250000 iterate all - get(i) 3.7801 ms/op 4.5236 ms/op 0.84
Array 250000 create 5.7289 ms/op 6.7900 ms/op 0.84
Array 250000 clone - spread 2.3440 ms/op 2.6295 ms/op 0.89
Array 250000 get(125000) 1.0590 ns/op 1.3140 ns/op 0.81
Array 250000 set(125000) 1.0530 ns/op 1.3050 ns/op 0.81
Array 250000 iterate all - loop 167.81 us/op 201.31 us/op 0.83
effectiveBalanceIncrements clone Uint8Array 300000 65.623 us/op 91.093 us/op 0.72
effectiveBalanceIncrements clone MutableVector 300000 663.00 ns/op 855.00 ns/op 0.78
effectiveBalanceIncrements rw all Uint8Array 300000 301.80 us/op 362.35 us/op 0.83
effectiveBalanceIncrements rw all MutableVector 300000 176.21 ms/op 220.63 ms/op 0.80
aggregationBits - 2048 els - readonlyValues 181.81 us/op 225.06 us/op 0.81
aggregationBits - 2048 els - zipIndexesInBitList 36.041 us/op 42.074 us/op 0.86
regular array get 100000 times 67.403 us/op 80.971 us/op 0.83
wrappedArray get 100000 times 67.423 us/op 81.032 us/op 0.83
arrayWithProxy get 100000 times 28.309 ms/op 33.861 ms/op 0.84
ssz.Root.equals 1.0780 us/op 1.4020 us/op 0.77
ssz.Root.equals with valueOf() 1.2700 us/op 1.6850 us/op 0.75
byteArrayEquals with valueOf() 1.2690 us/op 1.6230 us/op 0.78
phase0 processBlock - 250000 vs - 7PWei normalcase 8.0673 ms/op 9.4367 ms/op 0.85
phase0 processBlock - 250000 vs - 7PWei worstcase 74.613 ms/op 88.095 ms/op 0.85
phase0 afterProcessEpoch - 250000 vs - 7PWei 209.04 ms/op 257.77 ms/op 0.81
phase0 beforeProcessEpoch - 250000 vs - 7PWei 586.00 ms/op 684.95 ms/op 0.86
phase0 processEpoch - mainnet_e58758 901.91 ms/op 1.0403 s/op 0.87
mainnet_e58758 - phase0 beforeProcessEpoch 430.49 ms/op 495.36 ms/op 0.87
mainnet_e58758 - phase0 processJustificationAndFinalization 85.450 us/op 62.522 us/op 1.37
mainnet_e58758 - phase0 processRewardsAndPenalties 158.73 ms/op 156.95 ms/op 1.01
mainnet_e58758 - phase0 processRegistryUpdates 54.713 us/op 40.949 us/op 1.34
mainnet_e58758 - phase0 processSlashings 2.1100 us/op 3.4690 us/op 0.61
mainnet_e58758 - phase0 processEth1DataReset 1.9490 us/op 2.9860 us/op 0.65
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 5.6675 ms/op 6.5638 ms/op 0.86
mainnet_e58758 - phase0 processSlashingsReset 12.238 us/op 13.408 us/op 0.91
mainnet_e58758 - phase0 processRandaoMixesReset 18.076 us/op 15.111 us/op 1.20
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.2680 us/op 4.0090 us/op 0.32
mainnet_e58758 - phase0 processParticipationRecordUpdates 8.2500 us/op 13.272 us/op 0.62
mainnet_e58758 - phase0 afterProcessEpoch 186.25 ms/op 222.01 ms/op 0.84
phase0 processEffectiveBalanceUpdates - 250000 normalcase 6.5765 ms/op 7.5806 ms/op 0.87
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 6.8050 ms/op 8.0645 ms/op 0.84
phase0 processRegistryUpdates - 250000 normalcase 61.551 us/op 47.901 us/op 1.28
phase0 processRegistryUpdates - 250000 badcase_full_deposits 2.9825 ms/op 3.3233 ms/op 0.90
phase0 processRegistryUpdates - 250000 worstcase 0.5 1.7299 s/op 2.1576 s/op 0.80
phase0 getAttestationDeltas - 250000 normalcase 74.182 ms/op 102.02 ms/op 0.73
phase0 getAttestationDeltas - 250000 worstcase 75.480 ms/op 94.181 ms/op 0.80
phase0 processSlashings - 250000 worstcase 34.466 ms/op 38.249 ms/op 0.90
shuffle list - 16384 els 12.885 ms/op 15.225 ms/op 0.85
shuffle list - 250000 els 184.20 ms/op 218.59 ms/op 0.84
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 430.42 us/op 509.47 us/op 0.84
pass gossip attestations to forkchoice per slot 16.308 ms/op 21.635 ms/op 0.75
computeDeltas 3.9717 ms/op 4.2559 ms/op 0.93
computeProposerBoostScoreFromBalances 503.23 us/op 603.28 us/op 0.83
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.9507 ms/op 2.8464 ms/op 0.69
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 655.08 us/op 886.75 us/op 0.74
BLS verify - blst-native 1.8597 ms/op 2.2265 ms/op 0.84
BLS verifyMultipleSignatures 3 - blst-native 3.8157 ms/op 4.5524 ms/op 0.84
BLS verifyMultipleSignatures 8 - blst-native 8.2293 ms/op 9.8358 ms/op 0.84
BLS verifyMultipleSignatures 32 - blst-native 29.859 ms/op 35.774 ms/op 0.83
BLS aggregatePubkeys 32 - blst-native 39.703 us/op 47.094 us/op 0.84
BLS aggregatePubkeys 128 - blst-native 154.04 us/op 184.24 us/op 0.84
getAttestationsForBlock 60.295 ms/op 80.960 ms/op 0.74
CheckpointStateCache - add get delete 18.875 us/op 23.259 us/op 0.81
validate gossip signedAggregateAndProof - struct 4.4544 ms/op 5.3469 ms/op 0.83
validate gossip signedAggregateAndProof - treeBacked 4.4703 ms/op 5.2879 ms/op 0.85
validate gossip attestation - struct 2.0854 ms/op 2.5180 ms/op 0.83
validate gossip attestation - treeBacked 2.1113 ms/op 2.5198 ms/op 0.84
pickEth1Vote - no votes 9.2027 ms/op 12.823 ms/op 0.72
pickEth1Vote - max votes 51.419 ms/op 63.962 ms/op 0.80
pickEth1Vote - Eth1Data hashTreeRoot value x2048 24.694 ms/op 30.257 ms/op 0.82
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 9.4624 ms/op 11.408 ms/op 0.83
pickEth1Vote - Eth1Data fastSerialize value x2048 5.2620 ms/op 6.8131 ms/op 0.77
pickEth1Vote - Eth1Data fastSerialize tree x2048 24.001 ms/op 29.370 ms/op 0.82
bytes32 toHexString 1.6340 us/op 2.2740 us/op 0.72
bytes32 Buffer.toString(hex) 659.00 ns/op 898.00 ns/op 0.73
bytes32 Buffer.toString(hex) from Uint8Array 884.00 ns/op 1.1220 us/op 0.79
bytes32 Buffer.toString(hex) + 0x 658.00 ns/op 911.00 ns/op 0.72
Object access 1 prop 0.30700 ns/op 0.44500 ns/op 0.69
Map access 1 prop 0.27700 ns/op 0.37100 ns/op 0.75
Object get x1000 17.921 ns/op 21.965 ns/op 0.82
Map get x1000 0.97100 ns/op 1.1840 ns/op 0.82
Object set x1000 107.87 ns/op 134.57 ns/op 0.80
Map set x1000 64.252 ns/op 80.647 ns/op 0.80
Return object 10000 times 0.36530 ns/op 0.44540 ns/op 0.82
Throw Error 10000 times 5.8326 us/op 6.9768 us/op 0.84
enrSubnets - fastDeserialize 64 bits 1.2460 us/op 1.5810 us/op 0.79
enrSubnets - ssz BitVector 64 bits 17.126 us/op 19.791 us/op 0.87
enrSubnets - fastDeserialize 4 bits 406.00 ns/op 585.00 ns/op 0.69
enrSubnets - ssz BitVector 4 bits 2.9980 us/op 3.5750 us/op 0.84
RateTracker 1000000 limit, 1 obj count per request 176.43 ns/op 219.52 ns/op 0.80
RateTracker 1000000 limit, 2 obj count per request 132.89 ns/op 165.63 ns/op 0.80
RateTracker 1000000 limit, 4 obj count per request 108.26 ns/op 136.33 ns/op 0.79
RateTracker 1000000 limit, 8 obj count per request 99.031 ns/op 123.37 ns/op 0.80
RateTracker with prune 3.8030 us/op 4.9970 us/op 0.76

by benchmarkbot/action

@dapplion
Copy link
Contributor

dapplion commented Feb 9, 2022

@wemeetagain For next attempts you can modify the github actions workflow to also trigger on a specific branch temporarily to prevent polluting master

@dapplion dapplion merged commit 09fb4d4 into master Feb 9, 2022
@dapplion dapplion deleted the cayman/fix-docker-build branch February 9, 2022 05:04
@dapplion dapplion mentioned this pull request Jul 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@g11tech g11tech Awaiting requested review from g11tech

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

@twoeths twoeths Awaiting requested review from twoeths

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish arm64 bindings
2 participants
@wemeetagain @dapplion