Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unknown topics in gosispsub metrics #3877

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Mar 31, 2022

Motivation

Got this error in some prater nodes: Unknown gossip type optimistic_light_client_update_v0

Description

  • In prater seems like there are some new topic as above, does anybody has any info about that btw?
  • We have to handle unknown topics in gossipsubonScrapeMetrics

Closes #3876

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #3877 (488071d) into master (08f98c2) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 488071d differs from pull request most recent head 8bfeb16. Consider uploading reports for the commit 8bfeb16 to get more accurate results

@@            Coverage Diff             @@
##           master    #3877      +/-   ##
==========================================
- Coverage   36.00%   35.99%   -0.01%     
==========================================
  Files         326      326              
  Lines        9091     9092       +1     
  Branches     1434     1434              
==========================================
  Hits         3273     3273              
- Misses       5675     5676       +1     
  Partials      143      143              

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 488071d Previous: 08f98c2 Ratio
BeaconState.hashTreeRoot - No change 668.00 ns/op 672.00 ns/op 0.99
BeaconState.hashTreeRoot - 1 full validator 146.49 us/op 152.29 us/op 0.96
BeaconState.hashTreeRoot - 32 full validator 2.1817 ms/op 2.3687 ms/op 0.92
BeaconState.hashTreeRoot - 512 full validator 28.262 ms/op 31.274 ms/op 0.90
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 145.72 us/op 156.04 us/op 0.93
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.4300 ms/op 2.8656 ms/op 0.85
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 38.929 ms/op 36.073 ms/op 1.08
BeaconState.hashTreeRoot - 1 balances 101.12 us/op 107.35 us/op 0.94
BeaconState.hashTreeRoot - 32 balances 824.78 us/op 909.95 us/op 0.91
BeaconState.hashTreeRoot - 512 balances 7.9935 ms/op 8.9493 ms/op 0.89
BeaconState.hashTreeRoot - 250000 balances 144.19 ms/op 161.47 ms/op 0.89
processSlot - 1 slots 61.780 us/op 63.010 us/op 0.98
processSlot - 32 slots 3.2358 ms/op 3.4252 ms/op 0.94
getCommitteeAssignments - req 1 vs - 250000 vc 5.9338 ms/op 6.1812 ms/op 0.96
getCommitteeAssignments - req 100 vs - 250000 vc 8.0210 ms/op 8.6158 ms/op 0.93
getCommitteeAssignments - req 1000 vs - 250000 vc 8.6332 ms/op 9.2022 ms/op 0.94
computeProposers - vc 250000 22.531 ms/op 25.972 ms/op 0.87
computeEpochShuffling - vc 250000 203.11 ms/op 225.00 ms/op 0.90
getNextSyncCommittee - vc 250000 372.92 ms/op 407.28 ms/op 0.92
altair processAttestation - 250000 vs - 7PWei normalcase 39.769 ms/op 41.080 ms/op 0.97
altair processAttestation - 250000 vs - 7PWei worstcase 37.674 ms/op 75.185 ms/op 0.50
altair processAttestation - setStatus - 1/6 committees join 12.325 ms/op 13.838 ms/op 0.89
altair processAttestation - setStatus - 1/3 committees join 21.275 ms/op 28.770 ms/op 0.74
altair processAttestation - setStatus - 1/2 committees join 32.950 ms/op 39.225 ms/op 0.84
altair processAttestation - setStatus - 2/3 committees join 43.660 ms/op 48.830 ms/op 0.89
altair processAttestation - setStatus - 4/5 committees join 51.612 ms/op 63.584 ms/op 0.81
altair processAttestation - setStatus - 100% committees join 65.937 ms/op 81.695 ms/op 0.81
altair processAttestation - updateEpochParticipants - 1/6 committees join 11.420 ms/op 12.881 ms/op 0.89
altair processAttestation - updateEpochParticipants - 1/3 committees join 23.076 ms/op 27.603 ms/op 0.84
altair processAttestation - updateEpochParticipants - 1/2 committees join 21.426 ms/op 24.496 ms/op 0.87
altair processAttestation - updateEpochParticipants - 2/3 committees join 41.505 ms/op 28.085 ms/op 1.48
altair processAttestation - updateEpochParticipants - 4/5 committees join 22.062 ms/op 27.898 ms/op 0.79
altair processAttestation - updateEpochParticipants - 100% committees join 26.585 ms/op 30.527 ms/op 0.87
altair processAttestation - updateAllStatus 21.336 ms/op 22.329 ms/op 0.96
altair processBlock - 250000 vs - 7PWei normalcase 35.419 ms/op 38.555 ms/op 0.92
altair processBlock - 250000 vs - 7PWei worstcase 113.84 ms/op 125.01 ms/op 0.91
altair processEpoch - mainnet_e81889 854.27 ms/op 953.17 ms/op 0.90
mainnet_e81889 - altair beforeProcessEpoch 354.03 ms/op 373.63 ms/op 0.95
mainnet_e81889 - altair processJustificationAndFinalization 69.383 us/op 69.161 us/op 1.00
mainnet_e81889 - altair processInactivityUpdates 20.607 ms/op 20.180 ms/op 1.02
mainnet_e81889 - altair processRewardsAndPenalties 103.81 ms/op 110.81 ms/op 0.94
mainnet_e81889 - altair processRegistryUpdates 9.6630 us/op 9.9180 us/op 0.97
mainnet_e81889 - altair processSlashings 3.1530 us/op 3.5710 us/op 0.88
mainnet_e81889 - altair processEth1DataReset 3.1420 us/op 2.9110 us/op 1.08
mainnet_e81889 - altair processEffectiveBalanceUpdates 7.5125 ms/op 7.7060 ms/op 0.97
mainnet_e81889 - altair processSlashingsReset 14.033 us/op 16.579 us/op 0.85
mainnet_e81889 - altair processRandaoMixesReset 18.245 us/op 21.780 us/op 0.84
mainnet_e81889 - altair processHistoricalRootsUpdate 4.0450 us/op 3.4170 us/op 1.18
mainnet_e81889 - altair processParticipationFlagUpdates 81.127 ms/op 81.888 ms/op 0.99
mainnet_e81889 - altair processSyncCommitteeUpdates 3.3580 us/op 2.9730 us/op 1.13
mainnet_e81889 - altair afterProcessEpoch 261.59 ms/op 292.15 ms/op 0.90
altair processInactivityUpdates - 250000 normalcase 81.204 ms/op 82.880 ms/op 0.98
altair processInactivityUpdates - 250000 worstcase 79.833 ms/op 85.954 ms/op 0.93
altair processParticipationFlagUpdates - 250000 anycase 63.509 ms/op 70.374 ms/op 0.90
altair processRewardsAndPenalties - 250000 normalcase 95.728 ms/op 105.93 ms/op 0.90
altair processRewardsAndPenalties - 250000 worstcase 95.901 ms/op 118.91 ms/op 0.81
altair processSyncCommitteeUpdates - 250000 407.84 ms/op 422.13 ms/op 0.97
Tree 40 250000 create 724.94 ms/op 761.86 ms/op 0.95
Tree 40 250000 get(125000) 370.49 ns/op 391.46 ns/op 0.95
Tree 40 250000 set(125000) 2.1308 us/op 2.3388 us/op 0.91
Tree 40 250000 toArray() 41.324 ms/op 45.055 ms/op 0.92
Tree 40 250000 iterate all - toArray() + loop 44.497 ms/op 44.652 ms/op 1.00
Tree 40 250000 iterate all - get(i) 137.38 ms/op 140.02 ms/op 0.98
MutableVector 250000 create 24.425 ms/op 24.709 ms/op 0.99
MutableVector 250000 get(125000) 14.300 ns/op 14.801 ns/op 0.97
MutableVector 250000 set(125000) 587.23 ns/op 596.27 ns/op 0.98
MutableVector 250000 toArray() 9.9673 ms/op 10.617 ms/op 0.94
MutableVector 250000 iterate all - toArray() + loop 10.012 ms/op 10.171 ms/op 0.98
MutableVector 250000 iterate all - get(i) 3.7768 ms/op 4.0250 ms/op 0.94
Array 250000 create 5.8779 ms/op 6.3795 ms/op 0.92
Array 250000 clone - spread 2.5821 ms/op 2.7932 ms/op 0.92
Array 250000 get(125000) 1.2380 ns/op 1.3470 ns/op 0.92
Array 250000 set(125000) 1.2490 ns/op 1.3880 ns/op 0.90
Array 250000 iterate all - loop 191.72 us/op 211.09 us/op 0.91
effectiveBalanceIncrements clone Uint8Array 300000 83.734 us/op 305.42 us/op 0.27
effectiveBalanceIncrements clone MutableVector 300000 826.00 ns/op 644.00 ns/op 1.28
effectiveBalanceIncrements rw all Uint8Array 300000 343.58 us/op 352.20 us/op 0.98
effectiveBalanceIncrements rw all MutableVector 300000 207.27 ms/op 185.45 ms/op 1.12
aggregationBits - 2048 els - readonlyValues 217.25 us/op 202.52 us/op 1.07
aggregationBits - 2048 els - zipIndexesInBitList 40.797 us/op 35.967 us/op 1.13
regular array get 100000 times 78.036 us/op 79.517 us/op 0.98
wrappedArray get 100000 times 78.734 us/op 78.565 us/op 1.00
arrayWithProxy get 100000 times 34.303 ms/op 38.854 ms/op 0.88
ssz.Root.equals 1.3150 us/op 1.2550 us/op 1.05
ssz.Root.equals with valueOf() 1.6090 us/op 1.4720 us/op 1.09
byteArrayEquals with valueOf() 1.6280 us/op 1.4750 us/op 1.10
phase0 processBlock - 250000 vs - 7PWei normalcase 9.8426 ms/op 9.0721 ms/op 1.08
phase0 processBlock - 250000 vs - 7PWei worstcase 84.709 ms/op 83.163 ms/op 1.02
phase0 afterProcessEpoch - 250000 vs - 7PWei 254.49 ms/op 246.55 ms/op 1.03
phase0 beforeProcessEpoch - 250000 vs - 7PWei 607.87 ms/op 647.72 ms/op 0.94
phase0 processEpoch - mainnet_e58758 862.76 ms/op 896.31 ms/op 0.96
mainnet_e58758 - phase0 beforeProcessEpoch 474.26 ms/op 483.63 ms/op 0.98
mainnet_e58758 - phase0 processJustificationAndFinalization 59.628 us/op 69.095 us/op 0.86
mainnet_e58758 - phase0 processRewardsAndPenalties 124.71 ms/op 94.315 ms/op 1.32
mainnet_e58758 - phase0 processRegistryUpdates 38.788 us/op 47.989 us/op 0.81
mainnet_e58758 - phase0 processSlashings 3.4500 us/op 2.8650 us/op 1.20
mainnet_e58758 - phase0 processEth1DataReset 3.0440 us/op 2.8420 us/op 1.07
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 5.9235 ms/op 6.6308 ms/op 0.89
mainnet_e58758 - phase0 processSlashingsReset 12.561 us/op 13.758 us/op 0.91
mainnet_e58758 - phase0 processRandaoMixesReset 15.753 us/op 20.940 us/op 0.75
mainnet_e58758 - phase0 processHistoricalRootsUpdate 3.9910 us/op 3.9760 us/op 1.00
mainnet_e58758 - phase0 processParticipationRecordUpdates 13.008 us/op 13.466 us/op 0.97
mainnet_e58758 - phase0 afterProcessEpoch 212.25 ms/op 217.03 ms/op 0.98
phase0 processEffectiveBalanceUpdates - 250000 normalcase 6.8877 ms/op 7.4611 ms/op 0.92
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 7.4468 ms/op 7.6914 ms/op 0.97
phase0 processRegistryUpdates - 250000 normalcase 40.080 us/op 49.892 us/op 0.80
phase0 processRegistryUpdates - 250000 badcase_full_deposits 3.1168 ms/op 3.1964 ms/op 0.98
phase0 processRegistryUpdates - 250000 worstcase 0.5 1.7653 s/op 1.9108 s/op 0.92
phase0 getAttestationDeltas - 250000 normalcase 15.309 ms/op 15.972 ms/op 0.96
phase0 getAttestationDeltas - 250000 worstcase 14.990 ms/op 15.537 ms/op 0.96
phase0 processSlashings - 250000 worstcase 41.658 ms/op 40.726 ms/op 1.02
shuffle list - 16384 els 14.785 ms/op 15.283 ms/op 0.97
shuffle list - 250000 els 213.43 ms/op 220.38 ms/op 0.97
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 545.44 us/op 563.13 us/op 0.97
pass gossip attestations to forkchoice per slot 16.820 ms/op 16.353 ms/op 1.03
computeDeltas 3.5190 ms/op 3.7322 ms/op 0.94
computeProposerBoostScoreFromBalances 573.74 us/op 609.97 us/op 0.94
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.0736 ms/op 2.3022 ms/op 0.90
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 903.52 us/op 925.09 us/op 0.98
BLS verify - blst-native 2.1141 ms/op 2.1755 ms/op 0.97
BLS verifyMultipleSignatures 3 - blst-native 4.3125 ms/op 4.4616 ms/op 0.97
BLS verifyMultipleSignatures 8 - blst-native 9.2688 ms/op 9.4353 ms/op 0.98
BLS verifyMultipleSignatures 32 - blst-native 33.912 ms/op 34.584 ms/op 0.98
BLS aggregatePubkeys 32 - blst-native 46.467 us/op 46.940 us/op 0.99
BLS aggregatePubkeys 128 - blst-native 172.63 us/op 178.43 us/op 0.97
getAttestationsForBlock 68.314 ms/op 78.766 ms/op 0.87
CheckpointStateCache - add get delete 20.100 us/op 21.893 us/op 0.92
validate gossip signedAggregateAndProof - struct 4.9890 ms/op 5.1245 ms/op 0.97
validate gossip signedAggregateAndProof - treeBacked 4.9323 ms/op 5.0562 ms/op 0.98
validate gossip attestation - struct 2.3366 ms/op 2.4393 ms/op 0.96
validate gossip attestation - treeBacked 2.3779 ms/op 2.4576 ms/op 0.97
pickEth1Vote - no votes 9.0434 ms/op 10.325 ms/op 0.88
pickEth1Vote - max votes 52.559 ms/op 59.817 ms/op 0.88
pickEth1Vote - Eth1Data hashTreeRoot value x2048 28.238 ms/op 30.169 ms/op 0.94
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 10.024 ms/op 10.964 ms/op 0.91
pickEth1Vote - Eth1Data fastSerialize value x2048 5.3819 ms/op 5.8344 ms/op 0.92
pickEth1Vote - Eth1Data fastSerialize tree x2048 24.577 ms/op 25.972 ms/op 0.95
bytes32 toHexString 1.7120 us/op 1.9320 us/op 0.89
bytes32 Buffer.toString(hex) 762.00 ns/op 834.00 ns/op 0.91
bytes32 Buffer.toString(hex) from Uint8Array 1.0230 us/op 1.0120 us/op 1.01
bytes32 Buffer.toString(hex) + 0x 786.00 ns/op 826.00 ns/op 0.95
Object access 1 prop 0.33900 ns/op 0.40800 ns/op 0.83
Map access 1 prop 0.32000 ns/op 0.35300 ns/op 0.91
Object get x1000 18.724 ns/op 20.642 ns/op 0.91
Map get x1000 1.1430 ns/op 1.1530 ns/op 0.99
Object set x1000 108.56 ns/op 126.27 ns/op 0.86
Map set x1000 66.866 ns/op 78.166 ns/op 0.86
Return object 10000 times 0.41090 ns/op 0.43870 ns/op 0.94
Throw Error 10000 times 6.7015 us/op 6.6386 us/op 1.01
enrSubnets - fastDeserialize 64 bits 1.4060 us/op 1.5100 us/op 0.93
enrSubnets - ssz BitVector 64 bits 18.449 us/op 19.344 us/op 0.95
enrSubnets - fastDeserialize 4 bits 534.00 ns/op 545.00 ns/op 0.98
enrSubnets - ssz BitVector 4 bits 3.3790 us/op 3.6050 us/op 0.94
RateTracker 1000000 limit, 1 obj count per request 188.83 ns/op 209.83 ns/op 0.90
RateTracker 1000000 limit, 2 obj count per request 140.14 ns/op 158.14 ns/op 0.89
RateTracker 1000000 limit, 4 obj count per request 114.78 ns/op 127.66 ns/op 0.90
RateTracker 1000000 limit, 8 obj count per request 103.31 ns/op 117.11 ns/op 0.88
RateTracker with prune 3.9630 us/op 4.3420 us/op 0.91
array of 16000 items push then shift 3.4389 us/op 3.8173 us/op 0.90
LinkedList of 16000 items push then shift 16.786 ns/op 19.336 ns/op 0.87
array of 16000 items push then pop 213.79 ns/op 246.26 ns/op 0.87
LinkedList of 16000 items push then pop 17.380 ns/op 17.640 ns/op 0.99
array of 24000 items push then shift 5.0059 us/op 5.3780 us/op 0.93
LinkedList of 24000 items push then shift 19.132 ns/op 22.350 ns/op 0.86
array of 24000 items push then pop 197.71 ns/op 216.06 ns/op 0.92
LinkedList of 24000 items push then pop 18.663 ns/op 18.965 ns/op 0.98

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 43b4c17 into master Apr 1, 2022
@wemeetagain wemeetagain deleted the tuyen/handle-unknown-topics branch April 1, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics api is broken
2 participants