Create codeql-analysis.yml #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3975 +/- ##
==========================================
+ Coverage 37.06% 37.10% +0.04%
==========================================
Files 325 325
Lines 9109 9115 +6
Branches 1468 1470 +2
==========================================
+ Hits 3376 3382 +6
Misses 5542 5542
Partials 191 191 |
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
commented
May 5, 2022
| return passphrase; | ||
| } catch (e) { | ||
| console.log(`Imported passphrase ${passphraseFile}, but it's invalid: ${(e as Error).message}`); |
There was a problem hiding this comment.
Logging the error is very important, does codeql complain about that too?
There was a problem hiding this comment.
I'll check if the error message does not contain any information regarding the file path. Wanted to be on the safe side by removing it, but I'll confirm and if its safe and include.
There was a problem hiding this comment.
Updated to Include the error message
…r contain info relateing to location of passphrase file
wemeetagain
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Recommended by Github for code analysis