Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ropsten TTD to XXL #4072

Merged
merged 1 commit into from
May 26, 2022
Merged

Update Ropsten TTD to XXL #4072

merged 1 commit into from
May 26, 2022

Conversation

philknows
Copy link
Member

TTD Default override to 100000000000000000000000 to deter miners from hitting TTD before Ropsten beacon chain launch and Bellatrix fork.

@philknows philknows requested a review from a team as a code owner May 26, 2022 18:08
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: d56764a Previous: 8682951 Ratio
BeaconState.hashTreeRoot - No change 490.00 ns/op 498.00 ns/op 0.98
BeaconState.hashTreeRoot - 1 full validator 64.139 us/op 65.203 us/op 0.98
BeaconState.hashTreeRoot - 32 full validator 615.14 us/op 638.88 us/op 0.96
BeaconState.hashTreeRoot - 512 full validator 6.7506 ms/op 6.9945 ms/op 0.97
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 82.351 us/op 82.747 us/op 1.00
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.1161 ms/op 1.1532 ms/op 0.97
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 16.767 ms/op 15.133 ms/op 1.11
BeaconState.hashTreeRoot - 1 balances 63.351 us/op 62.221 us/op 1.02
BeaconState.hashTreeRoot - 32 balances 557.19 us/op 552.95 us/op 1.01
BeaconState.hashTreeRoot - 512 balances 5.5282 ms/op 5.3288 ms/op 1.04
BeaconState.hashTreeRoot - 250000 balances 122.37 ms/op 111.53 ms/op 1.10
processSlot - 1 slots 13.595 us/op 12.134 us/op 1.12
processSlot - 32 slots 1.9766 ms/op 1.9142 ms/op 1.03
getCommitteeAssignments - req 1 vs - 250000 vc 6.3840 ms/op 6.0064 ms/op 1.06
getCommitteeAssignments - req 100 vs - 250000 vc 8.7778 ms/op 8.5148 ms/op 1.03
getCommitteeAssignments - req 1000 vs - 250000 vc 9.3917 ms/op 9.0700 ms/op 1.04
computeProposers - vc 250000 20.285 ms/op 19.086 ms/op 1.06
computeEpochShuffling - vc 250000 203.41 ms/op 188.90 ms/op 1.08
getNextSyncCommittee - vc 250000 327.11 ms/op 315.61 ms/op 1.04
altair processAttestation - 250000 vs - 7PWei normalcase 4.3655 ms/op 4.3723 ms/op 1.00
altair processAttestation - 250000 vs - 7PWei worstcase 6.1588 ms/op 6.7839 ms/op 0.91
altair processAttestation - setStatus - 1/6 committees join 208.05 us/op 217.72 us/op 0.96
altair processAttestation - setStatus - 1/3 committees join 423.43 us/op 426.36 us/op 0.99
altair processAttestation - setStatus - 1/2 committees join 621.08 us/op 585.83 us/op 1.06
altair processAttestation - setStatus - 2/3 committees join 792.41 us/op 782.70 us/op 1.01
altair processAttestation - setStatus - 4/5 committees join 1.1042 ms/op 1.0265 ms/op 1.08
altair processAttestation - setStatus - 100% committees join 1.3108 ms/op 1.2497 ms/op 1.05
altair processBlock - 250000 vs - 7PWei normalcase 33.455 ms/op 30.829 ms/op 1.09
altair processBlock - 250000 vs - 7PWei normalcase hashState 43.545 ms/op 40.861 ms/op 1.07
altair processBlock - 250000 vs - 7PWei worstcase 89.699 ms/op 84.199 ms/op 1.07
altair processBlock - 250000 vs - 7PWei worstcase hashState 120.14 ms/op 125.13 ms/op 0.96
altair processEth1Data - 250000 vs - 7PWei normalcase 1.1838 ms/op 850.29 us/op 1.39
altair processEpoch - mainnet_e81889 671.56 ms/op 693.64 ms/op 0.97
mainnet_e81889 - altair beforeProcessEpoch 171.67 ms/op 103.30 ms/op 1.66
mainnet_e81889 - altair processJustificationAndFinalization 40.272 us/op 36.598 us/op 1.10
mainnet_e81889 - altair processInactivityUpdates 12.884 ms/op 13.021 ms/op 0.99
mainnet_e81889 - altair processRewardsAndPenalties 104.84 ms/op 175.63 ms/op 0.60
mainnet_e81889 - altair processRegistryUpdates 7.5650 us/op 7.0170 us/op 1.08
mainnet_e81889 - altair processSlashings 2.4400 us/op 2.2630 us/op 1.08
mainnet_e81889 - altair processEth1DataReset 2.2520 us/op 1.8920 us/op 1.19
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.7058 ms/op 2.9504 ms/op 0.92
mainnet_e81889 - altair processSlashingsReset 12.041 us/op 9.7090 us/op 1.24
mainnet_e81889 - altair processRandaoMixesReset 13.275 us/op 12.634 us/op 1.05
mainnet_e81889 - altair processHistoricalRootsUpdate 2.3170 us/op 1.9500 us/op 1.19
mainnet_e81889 - altair processParticipationFlagUpdates 10.377 us/op 6.4650 us/op 1.61
mainnet_e81889 - altair processSyncCommitteeUpdates 2.3660 us/op 2.2450 us/op 1.05
mainnet_e81889 - altair afterProcessEpoch 235.06 ms/op 231.29 ms/op 1.02
altair processInactivityUpdates - 250000 normalcase 48.345 ms/op 37.849 ms/op 1.28
altair processInactivityUpdates - 250000 worstcase 29.162 ms/op 31.477 ms/op 0.93
altair processRewardsAndPenalties - 250000 normalcase 99.131 ms/op 156.55 ms/op 0.63
altair processRewardsAndPenalties - 250000 worstcase 91.170 ms/op 96.918 ms/op 0.94
altair processSyncCommitteeUpdates - 250000 323.47 ms/op 342.14 ms/op 0.95
Tree 40 250000 create 1.0043 s/op 797.24 ms/op 1.26
Tree 40 250000 get(125000) 352.14 ns/op 341.46 ns/op 1.03
Tree 40 250000 set(125000) 3.0111 us/op 2.5791 us/op 1.17
Tree 40 250000 toArray() 35.825 ms/op 36.885 ms/op 0.97
Tree 40 250000 iterate all - toArray() + loop 36.655 ms/op 38.409 ms/op 0.95
Tree 40 250000 iterate all - get(i) 130.38 ms/op 132.11 ms/op 0.99
MutableVector 250000 create 19.064 ms/op 18.120 ms/op 1.05
MutableVector 250000 get(125000) 15.784 ns/op 18.048 ns/op 0.87
MutableVector 250000 set(125000) 832.91 ns/op 781.47 ns/op 1.07
MutableVector 250000 toArray() 9.4790 ms/op 7.9498 ms/op 1.19
MutableVector 250000 iterate all - toArray() + loop 9.7709 ms/op 8.2382 ms/op 1.19
MutableVector 250000 iterate all - get(i) 4.1105 ms/op 3.9165 ms/op 1.05
Array 250000 create 8.6983 ms/op 6.9519 ms/op 1.25
Array 250000 clone - spread 5.9470 ms/op 4.0970 ms/op 1.45
Array 250000 get(125000) 2.5160 ns/op 1.7500 ns/op 1.44
Array 250000 set(125000) 2.3700 ns/op 1.7200 ns/op 1.38
Array 250000 iterate all - loop 201.65 us/op 201.21 us/op 1.00
effectiveBalanceIncrements clone Uint8Array 300000 131.78 us/op 101.39 us/op 1.30
effectiveBalanceIncrements clone MutableVector 300000 1.7440 us/op 1.3090 us/op 1.33
effectiveBalanceIncrements rw all Uint8Array 300000 302.76 us/op 302.32 us/op 1.00
effectiveBalanceIncrements rw all MutableVector 300000 279.87 ms/op 240.04 ms/op 1.17
aggregationBits - 2048 els - zipIndexesInBitList 46.323 us/op 37.299 us/op 1.24
regular array get 100000 times 80.947 us/op 80.696 us/op 1.00
wrappedArray get 100000 times 80.982 us/op 80.976 us/op 1.00
arrayWithProxy get 100000 times 40.898 ms/op 35.427 ms/op 1.15
ssz.Root.equals 585.00 ns/op 606.00 ns/op 0.97
byteArrayEquals 600.00 ns/op 624.00 ns/op 0.96
phase0 processBlock - 250000 vs - 7PWei normalcase 4.5308 ms/op 4.4435 ms/op 1.02
phase0 processBlock - 250000 vs - 7PWei worstcase 55.595 ms/op 54.454 ms/op 1.02
phase0 afterProcessEpoch - 250000 vs - 7PWei 226.24 ms/op 222.75 ms/op 1.02
phase0 beforeProcessEpoch - 250000 vs - 7PWei 85.916 ms/op 80.327 ms/op 1.07
phase0 processEpoch - mainnet_e58758 617.94 ms/op 627.28 ms/op 0.99
mainnet_e58758 - phase0 beforeProcessEpoch 277.99 ms/op 265.12 ms/op 1.05
mainnet_e58758 - phase0 processJustificationAndFinalization 34.753 us/op 32.831 us/op 1.06
mainnet_e58758 - phase0 processRewardsAndPenalties 159.38 ms/op 161.72 ms/op 0.99
mainnet_e58758 - phase0 processRegistryUpdates 19.287 us/op 18.591 us/op 1.04
mainnet_e58758 - phase0 processSlashings 2.1390 us/op 1.7720 us/op 1.21
mainnet_e58758 - phase0 processEth1DataReset 1.9600 us/op 2.0570 us/op 0.95
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.6321 ms/op 2.6223 ms/op 1.00
mainnet_e58758 - phase0 processSlashingsReset 12.412 us/op 10.227 us/op 1.21
mainnet_e58758 - phase0 processRandaoMixesReset 13.940 us/op 11.789 us/op 1.18
mainnet_e58758 - phase0 processHistoricalRootsUpdate 3.2170 us/op 2.1400 us/op 1.50
mainnet_e58758 - phase0 processParticipationRecordUpdates 15.166 us/op 13.258 us/op 1.14
mainnet_e58758 - phase0 afterProcessEpoch 187.74 ms/op 191.18 ms/op 0.98
phase0 processEffectiveBalanceUpdates - 250000 normalcase 3.4609 ms/op 3.5844 ms/op 0.97
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.6251 ms/op 3.9058 ms/op 0.93
phase0 processRegistryUpdates - 250000 normalcase 17.182 us/op 14.028 us/op 1.22
phase0 processRegistryUpdates - 250000 badcase_full_deposits 526.46 us/op 557.27 us/op 0.94
phase0 processRegistryUpdates - 250000 worstcase 0.5 263.90 ms/op 254.30 ms/op 1.04
phase0 getAttestationDeltas - 250000 normalcase 17.703 ms/op 17.161 ms/op 1.03
phase0 getAttestationDeltas - 250000 worstcase 18.319 ms/op 16.600 ms/op 1.10
phase0 processSlashings - 250000 worstcase 6.3680 ms/op 6.3462 ms/op 1.00
shuffle list - 16384 els 13.367 ms/op 13.572 ms/op 0.98
shuffle list - 250000 els 194.69 ms/op 192.51 ms/op 1.01
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 449.66 us/op 452.16 us/op 0.99
pass gossip attestations to forkchoice per slot 3.6027 ms/op 3.8528 ms/op 0.94
computeDeltas 3.6657 ms/op 3.8571 ms/op 0.95
computeProposerBoostScoreFromBalances 1.0929 ms/op 1.1040 ms/op 0.99
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.3607 ms/op 2.3843 ms/op 0.99
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 103.95 us/op 105.99 us/op 0.98
BLS verify - blst-native 2.2736 ms/op 2.2264 ms/op 1.02
BLS verifyMultipleSignatures 3 - blst-native 4.5829 ms/op 4.5349 ms/op 1.01
BLS verifyMultipleSignatures 8 - blst-native 9.5361 ms/op 9.7214 ms/op 0.98
BLS verifyMultipleSignatures 32 - blst-native 33.519 ms/op 35.149 ms/op 0.95
BLS aggregatePubkeys 32 - blst-native 45.095 us/op 47.582 us/op 0.95
BLS aggregatePubkeys 128 - blst-native 170.10 us/op 184.37 us/op 0.92
getAttestationsForBlock 81.446 ms/op 88.507 ms/op 0.92
isKnown best case - 1 super set check 512.00 ns/op 547.00 ns/op 0.94
isKnown normal case - 2 super set checks 497.00 ns/op 532.00 ns/op 0.93
isKnown worse case - 16 super set checks 495.00 ns/op 502.00 ns/op 0.99
CheckpointStateCache - add get delete 13.579 us/op 14.639 us/op 0.93
validate gossip signedAggregateAndProof - struct 5.0065 ms/op 5.5799 ms/op 0.90
validate gossip attestation - struct 2.4128 ms/op 2.4333 ms/op 0.99
altair verifyImport mainnet_s3766816:31 7.3829 s/op 7.6120 s/op 0.97
pickEth1Vote - no votes 2.3520 ms/op 2.4565 ms/op 0.96
pickEth1Vote - max votes 28.395 ms/op 28.448 ms/op 1.00
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.584 ms/op 13.613 ms/op 1.00
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 24.935 ms/op 26.355 ms/op 0.95
pickEth1Vote - Eth1Data fastSerialize value x2048 1.6925 ms/op 1.6649 ms/op 1.02
pickEth1Vote - Eth1Data fastSerialize tree x2048 22.168 ms/op 18.803 ms/op 1.18
bytes32 toHexString 1.2020 us/op 1.2370 us/op 0.97
bytes32 Buffer.toString(hex) 797.00 ns/op 845.00 ns/op 0.94
bytes32 Buffer.toString(hex) from Uint8Array 1.1250 us/op 1.1070 us/op 1.02
bytes32 Buffer.toString(hex) + 0x 832.00 ns/op 859.00 ns/op 0.97
Object access 1 prop 0.44200 ns/op 0.42400 ns/op 1.04
Map access 1 prop 0.34300 ns/op 0.33000 ns/op 1.04
Object get x1000 21.715 ns/op 20.204 ns/op 1.07
Map get x1000 1.1820 ns/op 1.1680 ns/op 1.01
Object set x1000 144.97 ns/op 135.51 ns/op 1.07
Map set x1000 87.052 ns/op 85.224 ns/op 1.02
Return object 10000 times 0.44550 ns/op 0.44950 ns/op 0.99
Throw Error 10000 times 6.8433 us/op 6.9652 us/op 0.98
enrSubnets - fastDeserialize 64 bits 3.2570 us/op 3.2000 us/op 1.02
enrSubnets - ssz BitVector 64 bits 906.00 ns/op 905.00 ns/op 1.00
enrSubnets - fastDeserialize 4 bits 509.00 ns/op 468.00 ns/op 1.09
enrSubnets - ssz BitVector 4 bits 940.00 ns/op 842.00 ns/op 1.12
prioritizePeers score -10:0 att 32-0.1 sync 2-0 124.23 us/op 123.18 us/op 1.01
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 151.78 us/op 161.97 us/op 0.94
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 274.28 us/op 267.13 us/op 1.03
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 580.43 us/op 458.30 us/op 1.27
prioritizePeers score 0:0 att 64-1 sync 4-1 553.50 us/op 537.99 us/op 1.03
RateTracker 1000000 limit, 1 obj count per request 236.17 ns/op 228.66 ns/op 1.03
RateTracker 1000000 limit, 2 obj count per request 181.55 ns/op 168.72 ns/op 1.08
RateTracker 1000000 limit, 4 obj count per request 154.19 ns/op 134.79 ns/op 1.14
RateTracker 1000000 limit, 8 obj count per request 140.03 ns/op 121.03 ns/op 1.16
RateTracker with prune 5.9070 us/op 5.0530 us/op 1.17
array of 16000 items push then shift 3.8176 us/op 3.7229 us/op 1.03
LinkedList of 16000 items push then shift 28.877 ns/op 26.788 ns/op 1.08
array of 16000 items push then pop 295.57 ns/op 281.30 ns/op 1.05
LinkedList of 16000 items push then pop 22.803 ns/op 22.813 ns/op 1.00
array of 24000 items push then shift 5.1806 us/op 5.6348 us/op 0.92
LinkedList of 24000 items push then shift 28.016 ns/op 29.708 ns/op 0.94
array of 24000 items push then pop 215.04 ns/op 234.24 ns/op 0.92
LinkedList of 24000 items push then pop 22.186 ns/op 23.598 ns/op 0.94
intersect bitArray bitLen 8 12.985 ns/op 13.972 ns/op 0.93
intersect array and set length 8 182.18 ns/op 206.64 ns/op 0.88
intersect bitArray bitLen 128 65.803 ns/op 90.905 ns/op 0.72
intersect array and set length 128 2.4452 us/op 2.9160 us/op 0.84

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 7f7ef80 into master May 26, 2022
@wemeetagain wemeetagain deleted the philknows/ropsten-ttd-override branch May 26, 2022 18:34
@wemeetagain wemeetagain restored the philknows/ropsten-ttd-override branch May 27, 2022 14:32
@wemeetagain
Copy link
Member

Accidentally merged to master

@wemeetagain wemeetagain mentioned this pull request May 27, 2022
Closed
@wemeetagain
Copy link
Member

nvm, merged to master before the transition, the commit already lives in unstable

@dapplion dapplion deleted the philknows/ropsten-ttd-override branch May 28, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@philknows @wemeetagain @g11tech