Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another fix for publish rc #4099

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Another fix for publish rc #4099

merged 1 commit into from
Jun 1, 2022

Conversation

wemeetagain
Copy link
Member

Motivation

#4096 added a bash script which broke in CI. The script checks the that the commit at the rc tag is an ancestor of the head of the rc branch. But the command to get the head commit of the rc branch erroneously assumed that the branch had already been checked out. Which is not the case in CI.

Description
Update the script to check against the remote's rc branch, which should always exist in CI.

@wemeetagain wemeetagain requested a review from a team as a code owner June 1, 2022 15:23
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: dfcf283 Previous: 06c852e Ratio
BeaconState.hashTreeRoot - No change 501.00 ns/op 527.00 ns/op 0.95
BeaconState.hashTreeRoot - 1 full validator 70.329 us/op 67.667 us/op 1.04
BeaconState.hashTreeRoot - 32 full validator 684.73 us/op 703.85 us/op 0.97
BeaconState.hashTreeRoot - 512 full validator 6.7149 ms/op 8.3127 ms/op 0.81
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 91.162 us/op 86.790 us/op 1.05
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.1499 ms/op 1.1481 ms/op 1.00
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 15.685 ms/op 17.554 ms/op 0.89
BeaconState.hashTreeRoot - 1 balances 64.344 us/op 66.873 us/op 0.96
BeaconState.hashTreeRoot - 32 balances 562.93 us/op 586.80 us/op 0.96
BeaconState.hashTreeRoot - 512 balances 5.2189 ms/op 6.0812 ms/op 0.86
BeaconState.hashTreeRoot - 250000 balances 118.60 ms/op 116.34 ms/op 1.02
processSlot - 1 slots 14.528 us/op 13.857 us/op 1.05
processSlot - 32 slots 2.2006 ms/op 1.9824 ms/op 1.11
getCommitteeAssignments - req 1 vs - 250000 vc 5.0236 ms/op 5.4704 ms/op 0.92
getCommitteeAssignments - req 100 vs - 250000 vc 6.9381 ms/op 8.0093 ms/op 0.87
getCommitteeAssignments - req 1000 vs - 250000 vc 7.4051 ms/op 8.7620 ms/op 0.85
computeProposers - vc 250000 19.303 ms/op 19.781 ms/op 0.98
computeEpochShuffling - vc 250000 165.55 ms/op 179.33 ms/op 0.92
getNextSyncCommittee - vc 250000 317.00 ms/op 326.22 ms/op 0.97
altair processAttestation - 250000 vs - 7PWei normalcase 4.5770 ms/op 4.6097 ms/op 0.99
altair processAttestation - 250000 vs - 7PWei worstcase 6.5438 ms/op 6.4175 ms/op 1.02
altair processAttestation - setStatus - 1/6 committees join 202.40 us/op 201.59 us/op 1.00
altair processAttestation - setStatus - 1/3 committees join 422.11 us/op 369.21 us/op 1.14
altair processAttestation - setStatus - 1/2 committees join 587.93 us/op 507.81 us/op 1.16
altair processAttestation - setStatus - 2/3 committees join 765.85 us/op 670.38 us/op 1.14
altair processAttestation - setStatus - 4/5 committees join 1.0746 ms/op 946.43 us/op 1.14
altair processAttestation - setStatus - 100% committees join 1.2258 ms/op 1.1347 ms/op 1.08
altair processBlock - 250000 vs - 7PWei normalcase 32.033 ms/op 29.377 ms/op 1.09
altair processBlock - 250000 vs - 7PWei normalcase hashState 41.007 ms/op 42.398 ms/op 0.97
altair processBlock - 250000 vs - 7PWei worstcase 84.794 ms/op 83.786 ms/op 1.01
altair processBlock - 250000 vs - 7PWei worstcase hashState 128.91 ms/op 125.44 ms/op 1.03
altair processEth1Data - 250000 vs - 7PWei normalcase 875.31 us/op 1.0463 ms/op 0.84
altair processEpoch - mainnet_e81889 626.71 ms/op 607.94 ms/op 1.03
mainnet_e81889 - altair beforeProcessEpoch 155.76 ms/op 178.86 ms/op 0.87
mainnet_e81889 - altair processJustificationAndFinalization 68.400 us/op 18.491 us/op 3.70
mainnet_e81889 - altair processInactivityUpdates 12.383 ms/op 12.364 ms/op 1.00
mainnet_e81889 - altair processRewardsAndPenalties 154.71 ms/op 133.78 ms/op 1.16
mainnet_e81889 - altair processRegistryUpdates 15.299 us/op 2.8550 us/op 5.36
mainnet_e81889 - altair processSlashings 4.5560 us/op 721.00 ns/op 6.32
mainnet_e81889 - altair processEth1DataReset 4.5040 us/op 711.00 ns/op 6.33
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.5553 ms/op 2.8446 ms/op 0.90
mainnet_e81889 - altair processSlashingsReset 21.198 us/op 3.6280 us/op 5.84
mainnet_e81889 - altair processRandaoMixesReset 25.126 us/op 4.7050 us/op 5.34
mainnet_e81889 - altair processHistoricalRootsUpdate 4.5340 us/op 677.00 ns/op 6.70
mainnet_e81889 - altair processParticipationFlagUpdates 12.591 us/op 2.0550 us/op 6.13
mainnet_e81889 - altair processSyncCommitteeUpdates 3.8660 us/op 687.00 ns/op 5.63
mainnet_e81889 - altair afterProcessEpoch 195.60 ms/op 207.92 ms/op 0.94
altair processInactivityUpdates - 250000 normalcase 42.396 ms/op 34.891 ms/op 1.22
altair processInactivityUpdates - 250000 worstcase 35.393 ms/op 28.923 ms/op 1.22
altair processRewardsAndPenalties - 250000 normalcase 159.90 ms/op 130.47 ms/op 1.23
altair processRewardsAndPenalties - 250000 worstcase 90.986 ms/op 114.84 ms/op 0.79
altair processSyncCommitteeUpdates - 250000 337.91 ms/op 330.31 ms/op 1.02
Tree 40 250000 create 946.43 ms/op 1.3704 s/op 0.69
Tree 40 250000 get(125000) 307.05 ns/op 259.89 ns/op 1.18
Tree 40 250000 set(125000) 3.2578 us/op 3.8053 us/op 0.86
Tree 40 250000 toArray() 37.558 ms/op 36.391 ms/op 1.03
Tree 40 250000 iterate all - toArray() + loop 39.275 ms/op 36.688 ms/op 1.07
Tree 40 250000 iterate all - get(i) 134.49 ms/op 125.11 ms/op 1.07
MutableVector 250000 create 20.258 ms/op 16.789 ms/op 1.21
MutableVector 250000 get(125000) 13.604 ns/op 12.107 ns/op 1.12
MutableVector 250000 set(125000) 915.00 ns/op 1.0294 us/op 0.89
MutableVector 250000 toArray() 6.4434 ms/op 7.6711 ms/op 0.84
MutableVector 250000 iterate all - toArray() + loop 7.1130 ms/op 7.8938 ms/op 0.90
MutableVector 250000 iterate all - get(i) 3.0894 ms/op 2.6804 ms/op 1.15
Array 250000 create 5.8830 ms/op 7.4944 ms/op 0.78
Array 250000 clone - spread 3.8727 ms/op 7.4022 ms/op 0.52
Array 250000 get(125000) 1.6550 ns/op 2.8060 ns/op 0.59
Array 250000 set(125000) 1.6430 ns/op 2.8000 ns/op 0.59
Array 250000 iterate all - loop 131.91 us/op 151.17 us/op 0.87
effectiveBalanceIncrements clone Uint8Array 300000 102.84 us/op 110.09 us/op 0.93
effectiveBalanceIncrements clone MutableVector 300000 1.2620 us/op 2.2820 us/op 0.55
effectiveBalanceIncrements rw all Uint8Array 300000 276.39 us/op 247.67 us/op 1.12
effectiveBalanceIncrements rw all MutableVector 300000 282.39 ms/op 335.45 ms/op 0.84
aggregationBits - 2048 els - zipIndexesInBitList 39.894 us/op 50.424 us/op 0.79
regular array get 100000 times 56.197 us/op 61.388 us/op 0.92
wrappedArray get 100000 times 51.940 us/op 60.629 us/op 0.86
arrayWithProxy get 100000 times 33.139 ms/op 29.423 ms/op 1.13
ssz.Root.equals 617.00 ns/op 573.00 ns/op 1.08
byteArrayEquals 612.00 ns/op 568.00 ns/op 1.08
phase0 processBlock - 250000 vs - 7PWei normalcase 4.6599 ms/op 4.5984 ms/op 1.01
phase0 processBlock - 250000 vs - 7PWei worstcase 52.705 ms/op 54.603 ms/op 0.97
phase0 afterProcessEpoch - 250000 vs - 7PWei 201.27 ms/op 199.88 ms/op 1.01
phase0 beforeProcessEpoch - 250000 vs - 7PWei 80.506 ms/op 97.157 ms/op 0.83
phase0 processEpoch - mainnet_e58758 668.24 ms/op 571.38 ms/op 1.17
mainnet_e58758 - phase0 beforeProcessEpoch 244.53 ms/op 239.26 ms/op 1.02
mainnet_e58758 - phase0 processJustificationAndFinalization 69.074 us/op 20.182 us/op 3.42
mainnet_e58758 - phase0 processRewardsAndPenalties 133.04 ms/op 116.19 ms/op 1.14
mainnet_e58758 - phase0 processRegistryUpdates 31.826 us/op 8.5280 us/op 3.73
mainnet_e58758 - phase0 processSlashings 4.4480 us/op 632.00 ns/op 7.04
mainnet_e58758 - phase0 processEth1DataReset 4.3180 us/op 685.00 ns/op 6.30
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.1475 ms/op 1.7279 ms/op 1.24
mainnet_e58758 - phase0 processSlashingsReset 21.223 us/op 4.8440 us/op 4.38
mainnet_e58758 - phase0 processRandaoMixesReset 25.860 us/op 4.5840 us/op 5.64
mainnet_e58758 - phase0 processHistoricalRootsUpdate 4.1420 us/op 762.00 ns/op 5.44
mainnet_e58758 - phase0 processParticipationRecordUpdates 24.774 us/op 4.1150 us/op 6.02
mainnet_e58758 - phase0 afterProcessEpoch 158.78 ms/op 188.87 ms/op 0.84
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.5353 ms/op 2.0889 ms/op 1.21
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.4074 ms/op 2.3095 ms/op 1.04
phase0 processRegistryUpdates - 250000 normalcase 27.356 us/op 6.8490 us/op 3.99
phase0 processRegistryUpdates - 250000 badcase_full_deposits 482.55 us/op 388.45 us/op 1.24
phase0 processRegistryUpdates - 250000 worstcase 0.5 237.84 ms/op 233.81 ms/op 1.02
phase0 getAttestationDeltas - 250000 normalcase 14.285 ms/op 18.462 ms/op 0.77
phase0 getAttestationDeltas - 250000 worstcase 15.118 ms/op 18.566 ms/op 0.81
phase0 processSlashings - 250000 worstcase 6.9840 ms/op 5.7973 ms/op 1.20
shuffle list - 16384 els 11.423 ms/op 11.607 ms/op 0.98
shuffle list - 250000 els 166.07 ms/op 173.97 ms/op 0.95
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 445.28 us/op 399.72 us/op 1.11
pass gossip attestations to forkchoice per slot 3.6926 ms/op 3.2575 ms/op 1.13
computeDeltas 4.0157 ms/op 4.4339 ms/op 0.91
computeProposerBoostScoreFromBalances 821.55 us/op 804.56 us/op 1.02
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 3.0188 ms/op 2.7158 ms/op 1.11
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 92.252 us/op 90.887 us/op 1.02
BLS verify - blst-native 2.1732 ms/op 2.1768 ms/op 1.00
BLS verifyMultipleSignatures 3 - blst-native 4.5096 ms/op 4.4914 ms/op 1.00
BLS verifyMultipleSignatures 8 - blst-native 9.6280 ms/op 9.7132 ms/op 0.99
BLS verifyMultipleSignatures 32 - blst-native 33.852 ms/op 35.316 ms/op 0.96
BLS aggregatePubkeys 32 - blst-native 46.462 us/op 46.871 us/op 0.99
BLS aggregatePubkeys 128 - blst-native 172.01 us/op 183.50 us/op 0.94
getAttestationsForBlock 73.683 ms/op 71.295 ms/op 1.03
isKnown best case - 1 super set check 482.00 ns/op 527.00 ns/op 0.91
isKnown normal case - 2 super set checks 483.00 ns/op 515.00 ns/op 0.94
isKnown worse case - 16 super set checks 486.00 ns/op 513.00 ns/op 0.95
CheckpointStateCache - add get delete 13.360 us/op 13.052 us/op 1.02
validate gossip signedAggregateAndProof - struct 4.9979 ms/op 5.0354 ms/op 0.99
validate gossip attestation - struct 2.4050 ms/op 2.3792 ms/op 1.01
altair verifyImport mainnet_s3766816:31 7.0163 s/op 7.3126 s/op 0.96
pickEth1Vote - no votes 2.3138 ms/op 2.3209 ms/op 1.00
pickEth1Vote - max votes 31.009 ms/op 33.378 ms/op 0.93
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.891 ms/op 15.250 ms/op 0.91
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 25.623 ms/op 29.135 ms/op 0.88
pickEth1Vote - Eth1Data fastSerialize value x2048 1.6466 ms/op 1.6213 ms/op 1.02
pickEth1Vote - Eth1Data fastSerialize tree x2048 21.847 ms/op 24.273 ms/op 0.90
bytes32 toHexString 1.0910 us/op 1.4440 us/op 0.76
bytes32 Buffer.toString(hex) 731.00 ns/op 819.00 ns/op 0.89
bytes32 Buffer.toString(hex) from Uint8Array 1.0350 us/op 1.1400 us/op 0.91
bytes32 Buffer.toString(hex) + 0x 762.00 ns/op 835.00 ns/op 0.91
Object access 1 prop 0.46400 ns/op 0.47400 ns/op 0.98
Map access 1 prop 0.35300 ns/op 0.32500 ns/op 1.09
Object get x1000 17.677 ns/op 11.085 ns/op 1.59
Map get x1000 0.97300 ns/op 1.0230 ns/op 0.95
Object set x1000 118.47 ns/op 113.39 ns/op 1.04
Map set x1000 80.458 ns/op 72.984 ns/op 1.10
Return object 10000 times 0.41930 ns/op 0.44410 ns/op 0.94
Throw Error 10000 times 7.1042 us/op 6.1216 us/op 1.16
enrSubnets - fastDeserialize 64 bits 3.0570 us/op 3.8470 us/op 0.79
enrSubnets - ssz BitVector 64 bits 893.00 ns/op 978.00 ns/op 0.91
enrSubnets - fastDeserialize 4 bits 466.00 ns/op 483.00 ns/op 0.96
enrSubnets - ssz BitVector 4 bits 887.00 ns/op 955.00 ns/op 0.93
prioritizePeers score -10:0 att 32-0.1 sync 2-0 121.04 us/op 104.76 us/op 1.16
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 176.67 us/op 128.48 us/op 1.38
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 299.47 us/op 239.58 us/op 1.25
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 535.93 us/op 476.21 us/op 1.13
prioritizePeers score 0:0 att 64-1 sync 4-1 565.78 us/op 459.22 us/op 1.23
RateTracker 1000000 limit, 1 obj count per request 228.39 ns/op 212.36 ns/op 1.08
RateTracker 1000000 limit, 2 obj count per request 153.84 ns/op 162.51 ns/op 0.95
RateTracker 1000000 limit, 4 obj count per request 137.49 ns/op 136.86 ns/op 1.00
RateTracker 1000000 limit, 8 obj count per request 125.51 ns/op 124.36 ns/op 1.01
RateTracker with prune 5.2210 us/op 6.7490 us/op 0.77
array of 16000 items push then shift 5.0815 us/op 51.671 us/op 0.10
LinkedList of 16000 items push then shift 27.971 ns/op 23.756 ns/op 1.18
array of 16000 items push then pop 259.01 ns/op 267.55 ns/op 0.97
LinkedList of 16000 items push then pop 20.340 ns/op 17.944 ns/op 1.13
array of 24000 items push then shift 6.9618 us/op 77.468 us/op 0.09
LinkedList of 24000 items push then shift 29.129 ns/op 38.342 ns/op 0.76
array of 24000 items push then pop 203.11 ns/op 241.35 ns/op 0.84
LinkedList of 24000 items push then pop 23.003 ns/op 21.644 ns/op 1.06
intersect bitArray bitLen 8 10.929 ns/op 10.657 ns/op 1.03
intersect array and set length 8 181.01 ns/op 199.19 ns/op 0.91
intersect bitArray bitLen 128 66.764 ns/op 57.732 ns/op 1.16
intersect array and set length 128 2.3154 us/op 2.2344 us/op 1.04

by benchmarkbot/action

@wemeetagain wemeetagain merged commit ebd668d into unstable Jun 1, 2022
@wemeetagain wemeetagain deleted the cayman/fix-rc-again branch June 1, 2022 16:08
wemeetagain added a commit that referenced this pull request Jun 1, 2022
@wemeetagain
Another fix for publish rc (#4099)
3e6e4d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philknows philknows philknows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wemeetagain @philknows