Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publish stable workflow #4130

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Fix publish stable workflow #4130

merged 1 commit into from
Jun 7, 2022

Conversation

wemeetagain
Copy link
Member

@wemeetagain wemeetagain commented Jun 7, 2022 •
edited

See https://github.com/ChainSafe/lodestar/actions/runs/2457085743

Run STABLE_COMMIT=$(git log --pretty="%h" -n 1 stable)
fatal: ambiguous argument 'stable': unknown revision or path not in the working tree.

@wemeetagain wemeetagain requested a review from a team as a code owner June 7, 2022 20:02
@wemeetagain wemeetagain changed the base branch from unstable to stable June 7, 2022 20:02
@wemeetagain wemeetagain changed the title Cayman/fix stable release Fix publish stable workflow Jun 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: e74acc0 Previous: fe5c98e Ratio
altair processAttestation - 250000 vs - 7PWei normalcase 3.9865 ms/op 4.2532 ms/op 0.94
altair processAttestation - 250000 vs - 7PWei worstcase 6.1275 ms/op 7.1125 ms/op 0.86
altair processAttestation - setStatus - 1/6 committees join 236.56 us/op 244.42 us/op 0.97
altair processAttestation - setStatus - 1/3 committees join 442.19 us/op 466.06 us/op 0.95
altair processAttestation - setStatus - 1/2 committees join 635.48 us/op 658.40 us/op 0.97
altair processAttestation - setStatus - 2/3 committees join 875.89 us/op 832.57 us/op 1.05
altair processAttestation - setStatus - 4/5 committees join 1.1104 ms/op 1.1577 ms/op 0.96
altair processAttestation - setStatus - 100% committees join 1.4017 ms/op 1.4989 ms/op 0.94
altair processBlock - 250000 vs - 7PWei normalcase 30.077 ms/op 37.455 ms/op 0.80
altair processBlock - 250000 vs - 7PWei normalcase hashState 39.951 ms/op 39.085 ms/op 1.02
altair processBlock - 250000 vs - 7PWei worstcase 89.978 ms/op 87.269 ms/op 1.03
altair processBlock - 250000 vs - 7PWei worstcase hashState 107.18 ms/op 114.69 ms/op 0.93
phase0 processBlock - 250000 vs - 7PWei normalcase 4.1750 ms/op 3.9335 ms/op 1.06
phase0 processBlock - 250000 vs - 7PWei worstcase 54.621 ms/op 56.672 ms/op 0.96
altair processEth1Data - 250000 vs - 7PWei normalcase 777.32 us/op 791.53 us/op 0.98
Tree 40 250000 create 846.55 ms/op 877.28 ms/op 0.96
Tree 40 250000 get(125000) 337.07 ns/op 368.65 ns/op 0.91
Tree 40 250000 set(125000) 2.8370 us/op 2.9955 us/op 0.95
Tree 40 250000 toArray() 37.197 ms/op 37.378 ms/op 1.00
Tree 40 250000 iterate all - toArray() + loop 36.692 ms/op 37.781 ms/op 0.97
Tree 40 250000 iterate all - get(i) 129.08 ms/op 130.26 ms/op 0.99
MutableVector 250000 create 20.126 ms/op 19.064 ms/op 1.06
MutableVector 250000 get(125000) 15.042 ns/op 18.942 ns/op 0.79
MutableVector 250000 set(125000) 696.72 ns/op 780.59 ns/op 0.89
MutableVector 250000 toArray() 8.0249 ms/op 8.5731 ms/op 0.94
MutableVector 250000 iterate all - toArray() + loop 8.0290 ms/op 8.6508 ms/op 0.93
MutableVector 250000 iterate all - get(i) 3.8342 ms/op 3.9903 ms/op 0.96
Array 250000 create 7.2419 ms/op 8.3192 ms/op 0.87
Array 250000 clone - spread 4.1328 ms/op 3.2465 ms/op 1.27
Array 250000 get(125000) 1.7260 ns/op 1.3280 ns/op 1.30
Array 250000 set(125000) 1.7350 ns/op 1.2500 ns/op 1.39
Array 250000 iterate all - loop 197.87 us/op 194.02 us/op 1.02
effectiveBalanceIncrements clone Uint8Array 300000 108.05 us/op 84.898 us/op 1.27
effectiveBalanceIncrements clone MutableVector 300000 1.3830 us/op 860.00 ns/op 1.61
effectiveBalanceIncrements rw all Uint8Array 300000 294.03 us/op 288.67 us/op 1.02
effectiveBalanceIncrements rw all MutableVector 300000 238.61 ms/op 193.32 ms/op 1.23
phase0 afterProcessEpoch - 250000 vs - 7PWei 223.36 ms/op 233.26 ms/op 0.96
phase0 beforeProcessEpoch - 250000 vs - 7PWei 78.315 ms/op 77.428 ms/op 1.01
altair processEpoch - mainnet_e81889 560.18 ms/op 658.04 ms/op 0.85
mainnet_e81889 - altair beforeProcessEpoch 173.27 ms/op 153.23 ms/op 1.13
mainnet_e81889 - altair processJustificationAndFinalization 48.237 us/op 35.021 us/op 1.38
mainnet_e81889 - altair processInactivityUpdates 11.809 ms/op 13.525 ms/op 0.87
mainnet_e81889 - altair processRewardsAndPenalties 97.972 ms/op 161.07 ms/op 0.61
mainnet_e81889 - altair processRegistryUpdates 8.1450 us/op 8.7040 us/op 0.94
mainnet_e81889 - altair processSlashings 2.0300 us/op 2.0300 us/op 1.00
mainnet_e81889 - altair processEth1DataReset 2.1810 us/op 2.0680 us/op 1.05
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.6776 ms/op 2.9057 ms/op 0.92
mainnet_e81889 - altair processSlashingsReset 16.583 us/op 12.266 us/op 1.35
mainnet_e81889 - altair processRandaoMixesReset 15.698 us/op 13.214 us/op 1.19
mainnet_e81889 - altair processHistoricalRootsUpdate 2.5780 us/op 2.3160 us/op 1.11
mainnet_e81889 - altair processParticipationFlagUpdates 7.5740 us/op 6.9480 us/op 1.09
mainnet_e81889 - altair processSyncCommitteeUpdates 2.1780 us/op 2.0350 us/op 1.07
mainnet_e81889 - altair afterProcessEpoch 227.82 ms/op 238.42 ms/op 0.96
phase0 processEpoch - mainnet_e58758 690.15 ms/op 667.07 ms/op 1.03
mainnet_e58758 - phase0 beforeProcessEpoch 210.55 ms/op 219.97 ms/op 0.96
mainnet_e58758 - phase0 processJustificationAndFinalization 32.029 us/op 29.213 us/op 1.10
mainnet_e58758 - phase0 processRewardsAndPenalties 140.95 ms/op 85.764 ms/op 1.64
mainnet_e58758 - phase0 processRegistryUpdates 20.010 us/op 18.951 us/op 1.06
mainnet_e58758 - phase0 processSlashings 1.8240 us/op 2.2310 us/op 0.82
mainnet_e58758 - phase0 processEth1DataReset 1.7080 us/op 1.7860 us/op 0.96
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.4150 ms/op 2.3437 ms/op 1.03
mainnet_e58758 - phase0 processSlashingsReset 12.713 us/op 10.571 us/op 1.20
mainnet_e58758 - phase0 processRandaoMixesReset 15.157 us/op 14.669 us/op 1.03
mainnet_e58758 - phase0 processHistoricalRootsUpdate 2.2410 us/op 2.1640 us/op 1.04
mainnet_e58758 - phase0 processParticipationRecordUpdates 14.972 us/op 13.094 us/op 1.14
mainnet_e58758 - phase0 afterProcessEpoch 184.88 ms/op 190.95 ms/op 0.97
phase0 processEffectiveBalanceUpdates - 250000 normalcase 3.4534 ms/op 3.4786 ms/op 0.99
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.8225 ms/op 4.3407 ms/op 0.88
altair processInactivityUpdates - 250000 normalcase 27.942 ms/op 37.380 ms/op 0.75
altair processInactivityUpdates - 250000 worstcase 28.146 ms/op 38.025 ms/op 0.74
phase0 processRegistryUpdates - 250000 normalcase 16.360 us/op 14.914 us/op 1.10
phase0 processRegistryUpdates - 250000 badcase_full_deposits 493.98 us/op 514.87 us/op 0.96
phase0 processRegistryUpdates - 250000 worstcase 0.5 244.08 ms/op 243.77 ms/op 1.00
altair processRewardsAndPenalties - 250000 normalcase 93.226 ms/op 94.623 ms/op 0.99
altair processRewardsAndPenalties - 250000 worstcase 142.78 ms/op 147.20 ms/op 0.97
phase0 getAttestationDeltas - 250000 normalcase 14.986 ms/op 14.519 ms/op 1.03
phase0 getAttestationDeltas - 250000 worstcase 14.645 ms/op 14.873 ms/op 0.98
phase0 processSlashings - 250000 worstcase 6.4146 ms/op 6.2311 ms/op 1.03
altair processSyncCommitteeUpdates - 250000 328.36 ms/op 328.87 ms/op 1.00
BeaconState.hashTreeRoot - No change 636.00 ns/op 669.00 ns/op 0.95
BeaconState.hashTreeRoot - 1 full validator 66.138 us/op 72.223 us/op 0.92
BeaconState.hashTreeRoot - 32 full validator 637.45 us/op 702.44 us/op 0.91
BeaconState.hashTreeRoot - 512 full validator 7.8609 ms/op 7.9878 ms/op 0.98
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 87.375 us/op 97.692 us/op 0.89
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.1956 ms/op 1.3758 ms/op 0.87
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 17.053 ms/op 18.669 ms/op 0.91
BeaconState.hashTreeRoot - 1 balances 71.068 us/op 83.282 us/op 0.85
BeaconState.hashTreeRoot - 32 balances 660.46 us/op 559.57 us/op 1.18
BeaconState.hashTreeRoot - 512 balances 6.6440 ms/op 6.0020 ms/op 1.11
BeaconState.hashTreeRoot - 250000 balances 95.554 ms/op 99.552 ms/op 0.96
aggregationBits - 2048 els - zipIndexesInBitList 35.783 us/op 40.944 us/op 0.87
regular array get 100000 times 79.494 us/op 79.541 us/op 1.00
wrappedArray get 100000 times 76.467 us/op 78.662 us/op 0.97
arrayWithProxy get 100000 times 33.420 ms/op 34.433 ms/op 0.97
ssz.Root.equals 536.00 ns/op 600.00 ns/op 0.89
byteArrayEquals 538.00 ns/op 597.00 ns/op 0.90
shuffle list - 16384 els 12.452 ms/op 13.531 ms/op 0.92
shuffle list - 250000 els 203.67 ms/op 192.73 ms/op 1.06
processSlot - 1 slots 14.880 us/op 15.030 us/op 0.99
processSlot - 32 slots 2.2696 ms/op 2.2033 ms/op 1.03
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 462.99 us/op 464.24 us/op 1.00
getCommitteeAssignments - req 1 vs - 250000 vc 5.9932 ms/op 6.2901 ms/op 0.95
getCommitteeAssignments - req 100 vs - 250000 vc 8.1095 ms/op 8.6212 ms/op 0.94
getCommitteeAssignments - req 1000 vs - 250000 vc 8.9340 ms/op 9.3607 ms/op 0.95
computeProposers - vc 250000 18.337 ms/op 21.965 ms/op 0.83
computeEpochShuffling - vc 250000 212.14 ms/op 190.77 ms/op 1.11
getNextSyncCommittee - vc 250000 306.01 ms/op 319.84 ms/op 0.96
pass gossip attestations to forkchoice per slot 3.6034 ms/op 3.7587 ms/op 0.96
computeDeltas 3.7854 ms/op 3.8167 ms/op 0.99
computeProposerBoostScoreFromBalances 1.0635 ms/op 1.0540 ms/op 1.01
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.2641 ms/op 2.3684 ms/op 0.96
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 83.979 us/op 83.964 us/op 1.00
BLS verify - blst-native 2.0907 ms/op 2.2210 ms/op 0.94
BLS verifyMultipleSignatures 3 - blst-native 4.3516 ms/op 4.3908 ms/op 0.99
BLS verifyMultipleSignatures 8 - blst-native 9.5218 ms/op 9.5043 ms/op 1.00
BLS verifyMultipleSignatures 32 - blst-native 31.571 ms/op 34.271 ms/op 0.92
BLS aggregatePubkeys 32 - blst-native 43.148 us/op 45.155 us/op 0.96
BLS aggregatePubkeys 128 - blst-native 171.22 us/op 180.74 us/op 0.95
getAttestationsForBlock 72.558 ms/op 72.374 ms/op 1.00
isKnown best case - 1 super set check 539.00 ns/op 512.00 ns/op 1.05
isKnown normal case - 2 super set checks 483.00 ns/op 498.00 ns/op 0.97
isKnown worse case - 16 super set checks 493.00 ns/op 478.00 ns/op 1.03
CheckpointStateCache - add get delete 12.390 us/op 12.525 us/op 0.99
validate gossip signedAggregateAndProof - struct 5.1278 ms/op 4.8674 ms/op 1.05
validate gossip attestation - struct 2.3746 ms/op 2.3562 ms/op 1.01
altair verifyImport mainnet_s3766816:31 7.3202 s/op 7.3233 s/op 1.00
pickEth1Vote - no votes 2.4519 ms/op 2.5509 ms/op 0.96
pickEth1Vote - max votes 28.709 ms/op 31.434 ms/op 0.91
pickEth1Vote - Eth1Data hashTreeRoot value x2048 14.628 ms/op 14.564 ms/op 1.00
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 24.623 ms/op 24.151 ms/op 1.02
pickEth1Vote - Eth1Data fastSerialize value x2048 1.7866 ms/op 1.8461 ms/op 0.97
pickEth1Vote - Eth1Data fastSerialize tree x2048 20.539 ms/op 21.053 ms/op 0.98
bytes32 toHexString 1.2750 us/op 1.3450 us/op 0.95
bytes32 Buffer.toString(hex) 790.00 ns/op 851.00 ns/op 0.93
bytes32 Buffer.toString(hex) from Uint8Array 1.1100 us/op 1.1440 us/op 0.97
bytes32 Buffer.toString(hex) + 0x 804.00 ns/op 851.00 ns/op 0.94
Object access 1 prop 0.45000 ns/op 0.44700 ns/op 1.01
Map access 1 prop 0.34000 ns/op 0.34500 ns/op 0.99
Object get x1000 21.468 ns/op 20.574 ns/op 1.04
Map get x1000 1.1660 ns/op 1.1700 ns/op 1.00
Object set x1000 138.41 ns/op 142.08 ns/op 0.97
Map set x1000 85.505 ns/op 85.586 ns/op 1.00
Return object 10000 times 0.43720 ns/op 0.42840 ns/op 1.02
Throw Error 10000 times 6.9400 us/op 6.8597 us/op 1.01
enrSubnets - fastDeserialize 64 bits 3.1860 us/op 3.3620 us/op 0.95
enrSubnets - ssz BitVector 64 bits 928.00 ns/op 905.00 ns/op 1.03
enrSubnets - fastDeserialize 4 bits 475.00 ns/op 501.00 ns/op 0.95
enrSubnets - ssz BitVector 4 bits 912.00 ns/op 889.00 ns/op 1.03
prioritizePeers score -10:0 att 32-0.1 sync 2-0 123.50 us/op 114.25 us/op 1.08
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 141.99 us/op 160.76 us/op 0.88
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 259.97 us/op 267.66 us/op 0.97
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 528.40 us/op 468.63 us/op 1.13
prioritizePeers score 0:0 att 64-1 sync 4-1 540.90 us/op 531.97 us/op 1.02
RateTracker 1000000 limit, 1 obj count per request 224.44 ns/op 224.79 ns/op 1.00
RateTracker 1000000 limit, 2 obj count per request 169.01 ns/op 168.90 ns/op 1.00
RateTracker 1000000 limit, 4 obj count per request 136.74 ns/op 139.84 ns/op 0.98
RateTracker 1000000 limit, 8 obj count per request 125.97 ns/op 126.59 ns/op 1.00
RateTracker with prune 4.9000 us/op 5.0990 us/op 0.96
array of 16000 items push then shift 3.6653 us/op 3.7792 us/op 0.97
LinkedList of 16000 items push then shift 28.292 ns/op 29.212 ns/op 0.97
array of 16000 items push then pop 288.90 ns/op 275.78 ns/op 1.05
LinkedList of 16000 items push then pop 23.468 ns/op 24.357 ns/op 0.96
array of 24000 items push then shift 5.4063 us/op 5.2526 us/op 1.03
LinkedList of 24000 items push then shift 28.733 ns/op 29.023 ns/op 0.99
array of 24000 items push then pop 230.03 ns/op 232.81 ns/op 0.99
LinkedList of 24000 items push then pop 22.706 ns/op 23.869 ns/op 0.95
intersect bitArray bitLen 8 12.714 ns/op 13.221 ns/op 0.96
intersect array and set length 8 176.80 ns/op 192.20 ns/op 0.92
intersect bitArray bitLen 128 84.882 ns/op 83.692 ns/op 1.01
intersect array and set length 128 2.6038 us/op 2.6482 us/op 0.98

by benchmarkbot/action

@wemeetagain wemeetagain merged commit c7cf92e into stable Jun 7, 2022
@wemeetagain wemeetagain deleted the cayman/fix-stable-release branch June 7, 2022 20:28
wemeetagain added a commit that referenced this pull request Jun 7, 2022
@wemeetagain @g11tech @dapplion
Stable (#4129)
56a6bb4 
* v0.38.0

* Populate eth1 deposit cache with remote follow distance timed based (#4111)

* Fix HttpClient event handler leak (#4107)

Fix leak in signalGlobal event listeners

* Add Eth1DepositTracker metrics (#4110)

* Add Eth1DepositTracker metrics

* Add Eth1DepositTracker metrics

* Remove duplicate line

* Fix publish stable workflow (#4130)

Co-authored-by: harkamal <gajinder@g11.in>
Co-authored-by: Lion - dapplion <35266934+dapplion@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wemeetagain @dapplion