Checkpoint balances cache #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
reviewed
Jul 13, 2022
dapplion
reviewed
Jul 13, 2022
twoeths
commented
Jul 13, 2022
| const checkpointSlot = computeStartSlotAtEpoch(checkpoint.epoch); | ||
| const head = this.forkChoice.getHead(); | ||
| // Find a state in the same branch of checkpoint at same epoch. Balances should exactly the same | ||
| for (const descendantBlock of this.forkChoice.forwardIterateDescendants(checkpoint.rootHex)) { |
There was a problem hiding this comment.
should we consume forwardIterateDescendants only once to improve performance a bit? either extract to an array, or that function could return an array itself
There was a problem hiding this comment.
Since it's very unlikely to hit this code path I would not do that for simplicity. Metrics will clearly show if we have to run the iterator twice too often, only then optimize
dapplion
reviewed
Jul 13, 2022
| const blockDelaySec = (Math.floor(Date.now() / 1000) - postState.genesisTime) % chain.config.SECONDS_PER_SLOT; | ||
| const blockRoot = toHexString(chain.config.getForkTypes(block.message.slot).BeaconBlock.hashTreeRoot(block.message)); | ||
| // Should compute checkpoint balances before forkchoice.onBlock | ||
| chain.checkpointBalancesCache.processState(blockRoot, postState); |
There was a problem hiding this comment.
Calling fc_store.onVerifiedBlock() in a similar pattern as lighthouse sounds better than here.
dapplion
approved these changes
Jul 13, 2022
dapplion
approved these changes
Jul 13, 2022
|
Tested for a while in nightly group, metrics show that we always hit balances cache
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now whenever we provide a justified checkpoint to forkchoice, we provide balances too but forkchoice may switch justified checkpoint so we want to provide a way to cache balances from checkpoints
Description
justifiedBalancesGetterfunction: