Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop typedocs #4312

Merged
merged 2 commits into from Jul 17, 2022
Merged

Drop typedocs #4312

merged 2 commits into from Jul 17, 2022

Conversation

dapplion
Copy link
Contributor

Motivation

Description

Drop typedocs

@dapplion dapplion requested a review from a team as a code owner July 17, 2022 09:41
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: ad33426 Previous: 6d1ed43 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.0757 ms/op 2.1432 ms/op 0.97
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 71.320 us/op 71.475 us/op 1.00
BLS verify - blst-native 1.8555 ms/op 1.8570 ms/op 1.00
BLS verifyMultipleSignatures 3 - blst-native 3.8004 ms/op 3.7998 ms/op 1.00
BLS verifyMultipleSignatures 8 - blst-native 8.1825 ms/op 8.1813 ms/op 1.00
BLS verifyMultipleSignatures 32 - blst-native 29.661 ms/op 29.672 ms/op 1.00
BLS aggregatePubkeys 32 - blst-native 39.086 us/op 39.733 us/op 0.98
BLS aggregatePubkeys 128 - blst-native 152.64 us/op 152.51 us/op 1.00
getAttestationsForBlock 46.469 ms/op 46.718 ms/op 0.99
isKnown best case - 1 super set check 430.00 ns/op 430.00 ns/op 1.00
isKnown normal case - 2 super set checks 420.00 ns/op 416.00 ns/op 1.01
isKnown worse case - 16 super set checks 421.00 ns/op 416.00 ns/op 1.01
CheckpointStateCache - add get delete 11.347 us/op 10.933 us/op 1.04
validate gossip signedAggregateAndProof - struct 4.2690 ms/op 4.2740 ms/op 1.00
validate gossip attestation - struct 2.0240 ms/op 2.0273 ms/op 1.00
altair verifyImport mainnet_s3766816:31 12.383 s/op 12.742 s/op 0.97
pickEth1Vote - no votes 2.1266 ms/op 2.0658 ms/op 1.03
pickEth1Vote - max votes 27.640 ms/op 22.926 ms/op 1.21
pickEth1Vote - Eth1Data hashTreeRoot value x2048 12.612 ms/op 11.522 ms/op 1.09
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.911 ms/op 22.344 ms/op 1.03
pickEth1Vote - Eth1Data fastSerialize value x2048 1.6690 ms/op 1.5578 ms/op 1.07
pickEth1Vote - Eth1Data fastSerialize tree x2048 20.178 ms/op 18.161 ms/op 1.11
bytes32 toHexString 1.2510 us/op 1.0650 us/op 1.17
bytes32 Buffer.toString(hex) 748.00 ns/op 700.00 ns/op 1.07
bytes32 Buffer.toString(hex) from Uint8Array 955.00 ns/op 902.00 ns/op 1.06
bytes32 Buffer.toString(hex) + 0x 765.00 ns/op 696.00 ns/op 1.10
Object access 1 prop 0.41700 ns/op 0.37200 ns/op 1.12
Map access 1 prop 0.29800 ns/op 0.29700 ns/op 1.00
Object get x1000 18.269 ns/op 17.724 ns/op 1.03
Map get x1000 0.99200 ns/op 1.0020 ns/op 0.99
Object set x1000 133.86 ns/op 121.60 ns/op 1.10
Map set x1000 79.875 ns/op 73.162 ns/op 1.09
Return object 10000 times 0.37940 ns/op 0.37380 ns/op 1.01
Throw Error 10000 times 6.1219 us/op 5.9660 us/op 1.03
enrSubnets - fastDeserialize 64 bits 2.7290 us/op 2.7420 us/op 1.00
enrSubnets - ssz BitVector 64 bits 739.00 ns/op 764.00 ns/op 0.97
enrSubnets - fastDeserialize 4 bits 400.00 ns/op 423.00 ns/op 0.95
enrSubnets - ssz BitVector 4 bits 799.00 ns/op 736.00 ns/op 1.09
prioritizePeers score -10:0 att 32-0.1 sync 2-0 103.29 us/op 111.31 us/op 0.93
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 124.34 us/op 139.59 us/op 0.89
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 232.98 us/op 239.42 us/op 0.97
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 492.29 us/op 404.29 us/op 1.22
prioritizePeers score 0:0 att 64-1 sync 4-1 460.08 us/op 472.19 us/op 0.97
RateTracker 1000000 limit, 1 obj count per request 196.41 ns/op 211.70 ns/op 0.93
RateTracker 1000000 limit, 2 obj count per request 142.43 ns/op 161.13 ns/op 0.88
RateTracker 1000000 limit, 4 obj count per request 119.98 ns/op 134.20 ns/op 0.89
RateTracker 1000000 limit, 8 obj count per request 107.13 ns/op 120.76 ns/op 0.89
RateTracker with prune 4.3380 us/op 4.4950 us/op 0.97
array of 16000 items push then shift 3.0220 us/op 3.1634 us/op 0.96
LinkedList of 16000 items push then shift 23.957 ns/op 25.777 ns/op 0.93
array of 16000 items push then pop 231.26 ns/op 240.78 ns/op 0.96
LinkedList of 16000 items push then pop 19.894 ns/op 21.538 ns/op 0.92
array of 24000 items push then shift 4.0173 us/op 4.5499 us/op 0.88
LinkedList of 24000 items push then shift 25.262 ns/op 25.796 ns/op 0.98
array of 24000 items push then pop 215.57 ns/op 187.78 ns/op 1.15
LinkedList of 24000 items push then pop 21.494 ns/op 22.294 ns/op 0.96
intersect bitArray bitLen 8 11.756 ns/op 11.747 ns/op 1.00
intersect array and set length 8 181.99 ns/op 167.54 ns/op 1.09
intersect bitArray bitLen 128 62.037 ns/op 62.059 ns/op 1.00
intersect array and set length 128 2.3243 us/op 2.2489 us/op 1.03
pass gossip attestations to forkchoice per slot 3.5608 ms/op 3.2581 ms/op 1.09
computeDeltas 3.0792 ms/op 3.5639 ms/op 0.86
computeProposerBoostScoreFromBalances 921.12 us/op 907.40 us/op 1.02
altair processAttestation - 250000 vs - 7PWei normalcase 4.5954 ms/op 3.9181 ms/op 1.17
altair processAttestation - 250000 vs - 7PWei worstcase 6.9058 ms/op 5.7877 ms/op 1.19
altair processAttestation - setStatus - 1/6 committees join 213.39 us/op 204.79 us/op 1.04
altair processAttestation - setStatus - 1/3 committees join 401.37 us/op 395.59 us/op 1.01
altair processAttestation - setStatus - 1/2 committees join 560.54 us/op 556.88 us/op 1.01
altair processAttestation - setStatus - 2/3 committees join 745.00 us/op 718.78 us/op 1.04
altair processAttestation - setStatus - 4/5 committees join 1.0364 ms/op 987.43 us/op 1.05
altair processAttestation - setStatus - 100% committees join 1.1833 ms/op 1.1827 ms/op 1.00
altair processBlock - 250000 vs - 7PWei normalcase 27.619 ms/op 27.584 ms/op 1.00
altair processBlock - 250000 vs - 7PWei normalcase hashState 41.313 ms/op 35.185 ms/op 1.17
altair processBlock - 250000 vs - 7PWei worstcase 80.012 ms/op 83.754 ms/op 0.96
altair processBlock - 250000 vs - 7PWei worstcase hashState 92.933 ms/op 96.320 ms/op 0.96
phase0 processBlock - 250000 vs - 7PWei normalcase 4.8314 ms/op 4.4041 ms/op 1.10
phase0 processBlock - 250000 vs - 7PWei worstcase 41.243 ms/op 47.060 ms/op 0.88
altair processEth1Data - 250000 vs - 7PWei normalcase 829.41 us/op 849.63 us/op 0.98
Tree 40 250000 create 860.56 ms/op 820.34 ms/op 1.05
Tree 40 250000 get(125000) 284.53 ns/op 283.85 ns/op 1.00
Tree 40 250000 set(125000) 2.3645 us/op 2.4658 us/op 0.96
Tree 40 250000 toArray() 32.053 ms/op 32.477 ms/op 0.99
Tree 40 250000 iterate all - toArray() + loop 32.287 ms/op 35.726 ms/op 0.90
Tree 40 250000 iterate all - get(i) 111.29 ms/op 108.98 ms/op 1.02
MutableVector 250000 create 15.231 ms/op 12.159 ms/op 1.25
MutableVector 250000 get(125000) 13.077 ns/op 13.479 ns/op 0.97
MutableVector 250000 set(125000) 632.87 ns/op 559.44 ns/op 1.13
MutableVector 250000 toArray() 6.6776 ms/op 6.2724 ms/op 1.06
MutableVector 250000 iterate all - toArray() + loop 6.8258 ms/op 6.3774 ms/op 1.07
MutableVector 250000 iterate all - get(i) 3.2805 ms/op 3.2876 ms/op 1.00
Array 250000 create 6.0675 ms/op 5.7092 ms/op 1.06
Array 250000 clone - spread 3.0670 ms/op 3.0820 ms/op 1.00
Array 250000 get(125000) 1.3460 ns/op 1.3710 ns/op 0.98
Array 250000 set(125000) 1.3430 ns/op 1.3630 ns/op 0.99
Array 250000 iterate all - loop 167.80 us/op 170.51 us/op 0.98
effectiveBalanceIncrements clone Uint8Array 300000 79.268 us/op 71.730 us/op 1.11
effectiveBalanceIncrements clone MutableVector 300000 950.00 ns/op 636.00 ns/op 1.49
effectiveBalanceIncrements rw all Uint8Array 300000 252.49 us/op 252.51 us/op 1.00
effectiveBalanceIncrements rw all MutableVector 300000 176.27 ms/op 155.66 ms/op 1.13
phase0 afterProcessEpoch - 250000 vs - 7PWei 186.01 ms/op 180.74 ms/op 1.03
phase0 beforeProcessEpoch - 250000 vs - 7PWei 94.653 ms/op 75.488 ms/op 1.25
altair processEpoch - mainnet_e81889 569.95 ms/op 585.33 ms/op 0.97
mainnet_e81889 - altair beforeProcessEpoch 132.63 ms/op 140.80 ms/op 0.94
mainnet_e81889 - altair processJustificationAndFinalization 20.905 us/op 30.738 us/op 0.68
mainnet_e81889 - altair processInactivityUpdates 10.646 ms/op 11.462 ms/op 0.93
mainnet_e81889 - altair processRewardsAndPenalties 91.209 ms/op 92.514 ms/op 0.99
mainnet_e81889 - altair processRegistryUpdates 4.4680 us/op 5.5890 us/op 0.80
mainnet_e81889 - altair processSlashings 1.0190 us/op 1.6780 us/op 0.61
mainnet_e81889 - altair processEth1DataReset 953.00 ns/op 1.7440 us/op 0.55
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.4090 ms/op 2.4311 ms/op 0.99
mainnet_e81889 - altair processSlashingsReset 5.9420 us/op 8.8530 us/op 0.67
mainnet_e81889 - altair processRandaoMixesReset 6.1740 us/op 11.091 us/op 0.56
mainnet_e81889 - altair processHistoricalRootsUpdate 1.0240 us/op 1.4750 us/op 0.69
mainnet_e81889 - altair processParticipationFlagUpdates 3.1010 us/op 4.6820 us/op 0.66
mainnet_e81889 - altair processSyncCommitteeUpdates 682.00 ns/op 1.1260 us/op 0.61
mainnet_e81889 - altair afterProcessEpoch 194.66 ms/op 191.88 ms/op 1.01
phase0 processEpoch - mainnet_e58758 511.69 ms/op 530.28 ms/op 0.96
mainnet_e58758 - phase0 beforeProcessEpoch 219.61 ms/op 234.24 ms/op 0.94
mainnet_e58758 - phase0 processJustificationAndFinalization 20.316 us/op 30.876 us/op 0.66
mainnet_e58758 - phase0 processRewardsAndPenalties 125.66 ms/op 142.75 ms/op 0.88
mainnet_e58758 - phase0 processRegistryUpdates 9.9490 us/op 18.037 us/op 0.55
mainnet_e58758 - phase0 processSlashings 870.00 ns/op 1.2900 us/op 0.67
mainnet_e58758 - phase0 processEth1DataReset 888.00 ns/op 1.3810 us/op 0.64
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.1114 ms/op 2.2008 ms/op 0.96
mainnet_e58758 - phase0 processSlashingsReset 5.5670 us/op 7.8130 us/op 0.71
mainnet_e58758 - phase0 processRandaoMixesReset 6.6580 us/op 10.662 us/op 0.62
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.2210 us/op 1.2050 us/op 1.01
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.8340 us/op 7.9710 us/op 0.73
mainnet_e58758 - phase0 afterProcessEpoch 160.32 ms/op 157.35 ms/op 1.02
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.5456 ms/op 2.6094 ms/op 0.98
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.0611 ms/op 3.1124 ms/op 0.98
altair processInactivityUpdates - 250000 normalcase 40.144 ms/op 44.745 ms/op 0.90
altair processInactivityUpdates - 250000 worstcase 38.255 ms/op 52.244 ms/op 0.73
phase0 processRegistryUpdates - 250000 normalcase 9.4060 us/op 15.734 us/op 0.60
phase0 processRegistryUpdates - 250000 badcase_full_deposits 420.53 us/op 638.88 us/op 0.66
phase0 processRegistryUpdates - 250000 worstcase 0.5 209.36 ms/op 214.66 ms/op 0.98
altair processRewardsAndPenalties - 250000 normalcase 123.09 ms/op 127.24 ms/op 0.97
altair processRewardsAndPenalties - 250000 worstcase 123.42 ms/op 85.988 ms/op 1.44
phase0 getAttestationDeltas - 250000 normalcase 11.531 ms/op 12.822 ms/op 0.90
phase0 getAttestationDeltas - 250000 worstcase 11.665 ms/op 13.127 ms/op 0.89
phase0 processSlashings - 250000 worstcase 5.4315 ms/op 5.4481 ms/op 1.00
altair processSyncCommitteeUpdates - 250000 276.96 ms/op 268.35 ms/op 1.03
BeaconState.hashTreeRoot - No change 561.00 ns/op 487.00 ns/op 1.15
BeaconState.hashTreeRoot - 1 full validator 56.808 us/op 56.065 us/op 1.01
BeaconState.hashTreeRoot - 32 full validator 555.41 us/op 550.24 us/op 1.01
BeaconState.hashTreeRoot - 512 full validator 6.1398 ms/op 6.0226 ms/op 1.02
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 72.016 us/op 69.557 us/op 1.04
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 985.66 us/op 1.0088 ms/op 0.98
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 12.865 ms/op 12.558 ms/op 1.02
BeaconState.hashTreeRoot - 1 balances 53.542 us/op 53.633 us/op 1.00
BeaconState.hashTreeRoot - 32 balances 472.93 us/op 464.51 us/op 1.02
BeaconState.hashTreeRoot - 512 balances 4.5386 ms/op 4.5223 ms/op 1.00
BeaconState.hashTreeRoot - 250000 balances 85.161 ms/op 80.303 ms/op 1.06
aggregationBits - 2048 els - zipIndexesInBitList 32.016 us/op 30.277 us/op 1.06
regular array get 100000 times 67.399 us/op 67.413 us/op 1.00
wrappedArray get 100000 times 67.413 us/op 67.409 us/op 1.00
arrayWithProxy get 100000 times 29.422 ms/op 29.399 ms/op 1.00
ssz.Root.equals 471.00 ns/op 479.00 ns/op 0.98
byteArrayEquals 485.00 ns/op 453.00 ns/op 1.07
shuffle list - 16384 els 11.331 ms/op 10.925 ms/op 1.04
shuffle list - 250000 els 166.25 ms/op 162.18 ms/op 1.03
processSlot - 1 slots 12.172 us/op 11.897 us/op 1.02
processSlot - 32 slots 1.7142 ms/op 1.6897 ms/op 1.01
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 387.84 us/op 395.83 us/op 0.98
getCommitteeAssignments - req 1 vs - 250000 vc 5.3475 ms/op 5.3061 ms/op 1.01
getCommitteeAssignments - req 100 vs - 250000 vc 7.3258 ms/op 7.3422 ms/op 1.00
getCommitteeAssignments - req 1000 vs - 250000 vc 7.7660 ms/op 7.8535 ms/op 0.99
computeProposers - vc 250000 17.783 ms/op 17.447 ms/op 1.02
computeEpochShuffling - vc 250000 169.61 ms/op 164.89 ms/op 1.03
getNextSyncCommittee - vc 250000 267.00 ms/op 266.73 ms/op 1.00

by benchmarkbot/action

@wemeetagain wemeetagain merged commit f04d270 into unstable Jul 17, 2022
@wemeetagain wemeetagain deleted the dapplion/drop-typedocs branch July 17, 2022 15:19
@dapplion dapplion mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dapplion @wemeetagain