Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add goerli flag #4316

Merged
merged 1 commit into from Jul 18, 2022
Merged

Add goerli flag #4316

merged 1 commit into from Jul 18, 2022

Conversation

dapplion
Copy link
Contributor

Motivation

Description

Closes #4298

@dapplion dapplion requested a review from a team as a code owner July 17, 2022 14:20
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: cb0a539 Previous: 13558b5 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.8375 ms/op 2.5192 ms/op 0.73
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 71.801 us/op 86.735 us/op 0.83
BLS verify - blst-native 1.8540 ms/op 2.1842 ms/op 0.85
BLS verifyMultipleSignatures 3 - blst-native 3.7972 ms/op 4.4466 ms/op 0.85
BLS verifyMultipleSignatures 8 - blst-native 8.1802 ms/op 9.6741 ms/op 0.85
BLS verifyMultipleSignatures 32 - blst-native 29.640 ms/op 35.252 ms/op 0.84
BLS aggregatePubkeys 32 - blst-native 39.305 us/op 45.754 us/op 0.86
BLS aggregatePubkeys 128 - blst-native 153.00 us/op 179.26 us/op 0.85
getAttestationsForBlock 44.959 ms/op 53.465 ms/op 0.84
isKnown best case - 1 super set check 466.00 ns/op 502.00 ns/op 0.93
isKnown normal case - 2 super set checks 450.00 ns/op 481.00 ns/op 0.94
isKnown worse case - 16 super set checks 449.00 ns/op 488.00 ns/op 0.92
CheckpointStateCache - add get delete 10.853 us/op 13.418 us/op 0.81
validate gossip signedAggregateAndProof - struct 4.2565 ms/op 5.0240 ms/op 0.85
validate gossip attestation - struct 2.0413 ms/op 2.4060 ms/op 0.85
altair verifyImport mainnet_s3766816:31 12.800 s/op 14.676 s/op 0.87
pickEth1Vote - no votes 2.0579 ms/op 2.4823 ms/op 0.83
pickEth1Vote - max votes 24.076 ms/op 29.271 ms/op 0.82
pickEth1Vote - Eth1Data hashTreeRoot value x2048 11.547 ms/op 13.841 ms/op 0.83
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 21.399 ms/op 25.872 ms/op 0.83
pickEth1Vote - Eth1Data fastSerialize value x2048 1.5087 ms/op 1.8680 ms/op 0.81
pickEth1Vote - Eth1Data fastSerialize tree x2048 17.894 ms/op 20.876 ms/op 0.86
bytes32 toHexString 1.0550 us/op 1.3330 us/op 0.79
bytes32 Buffer.toString(hex) 674.00 ns/op 841.00 ns/op 0.80
bytes32 Buffer.toString(hex) from Uint8Array 916.00 ns/op 1.1460 us/op 0.80
bytes32 Buffer.toString(hex) + 0x 678.00 ns/op 875.00 ns/op 0.77
Object access 1 prop 0.35800 ns/op 0.45300 ns/op 0.79
Map access 1 prop 0.30200 ns/op 0.33300 ns/op 0.91
Object get x1000 19.642 ns/op 20.340 ns/op 0.97
Map get x1000 1.1190 ns/op 1.1820 ns/op 0.95
Object set x1000 116.30 ns/op 143.12 ns/op 0.81
Map set x1000 72.850 ns/op 85.752 ns/op 0.85
Return object 10000 times 0.36820 ns/op 0.43550 ns/op 0.85
Throw Error 10000 times 6.0129 us/op 6.8360 us/op 0.88
enrSubnets - fastDeserialize 64 bits 2.6440 us/op 3.2300 us/op 0.82
enrSubnets - ssz BitVector 64 bits 702.00 ns/op 877.00 ns/op 0.80
enrSubnets - fastDeserialize 4 bits 377.00 ns/op 482.00 ns/op 0.78
enrSubnets - ssz BitVector 4 bits 716.00 ns/op 889.00 ns/op 0.81
prioritizePeers score -10:0 att 32-0.1 sync 2-0 95.868 us/op 122.02 us/op 0.79
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 137.21 us/op 140.74 us/op 0.97
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 219.72 us/op 258.35 us/op 0.85
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 392.12 us/op 540.60 us/op 0.73
prioritizePeers score 0:0 att 64-1 sync 4-1 469.91 us/op 540.49 us/op 0.87
RateTracker 1000000 limit, 1 obj count per request 187.70 ns/op 237.35 ns/op 0.79
RateTracker 1000000 limit, 2 obj count per request 142.49 ns/op 181.88 ns/op 0.78
RateTracker 1000000 limit, 4 obj count per request 120.41 ns/op 155.57 ns/op 0.77
RateTracker 1000000 limit, 8 obj count per request 105.42 ns/op 140.08 ns/op 0.75
RateTracker with prune 4.6010 us/op 5.2110 us/op 0.88
array of 16000 items push then shift 3.1956 us/op 3.6984 us/op 0.86
LinkedList of 16000 items push then shift 27.156 ns/op 28.732 ns/op 0.95
array of 16000 items push then pop 249.26 ns/op 273.95 ns/op 0.91
LinkedList of 16000 items push then pop 22.823 ns/op 24.054 ns/op 0.95
array of 24000 items push then shift 4.5786 us/op 5.3069 us/op 0.86
LinkedList of 24000 items push then shift 28.592 ns/op 29.419 ns/op 0.97
array of 24000 items push then pop 194.86 ns/op 231.51 ns/op 0.84
LinkedList of 24000 items push then pop 22.822 ns/op 24.414 ns/op 0.93
intersect bitArray bitLen 8 11.757 ns/op 14.017 ns/op 0.84
intersect array and set length 8 166.43 ns/op 202.44 ns/op 0.82
intersect bitArray bitLen 128 71.934 ns/op 73.111 ns/op 0.98
intersect array and set length 128 2.2462 us/op 2.6892 us/op 0.84
pass gossip attestations to forkchoice per slot 3.5583 ms/op 3.7357 ms/op 0.95
computeDeltas 4.0365 ms/op 3.8411 ms/op 1.05
computeProposerBoostScoreFromBalances 907.37 us/op 1.0761 ms/op 0.84
altair processAttestation - 250000 vs - 7PWei normalcase 3.9315 ms/op 4.9285 ms/op 0.80
altair processAttestation - 250000 vs - 7PWei worstcase 5.8301 ms/op 7.1035 ms/op 0.82
altair processAttestation - setStatus - 1/6 committees join 212.58 us/op 241.77 us/op 0.88
altair processAttestation - setStatus - 1/3 committees join 397.74 us/op 462.06 us/op 0.86
altair processAttestation - setStatus - 1/2 committees join 566.67 us/op 637.07 us/op 0.89
altair processAttestation - setStatus - 2/3 committees join 718.80 us/op 829.26 us/op 0.87
altair processAttestation - setStatus - 4/5 committees join 1.0130 ms/op 1.1582 ms/op 0.87
altair processAttestation - setStatus - 100% committees join 1.1932 ms/op 1.3635 ms/op 0.88
altair processBlock - 250000 vs - 7PWei normalcase 28.970 ms/op 33.023 ms/op 0.88
altair processBlock - 250000 vs - 7PWei normalcase hashState 37.555 ms/op 41.057 ms/op 0.91
altair processBlock - 250000 vs - 7PWei worstcase 80.736 ms/op 102.64 ms/op 0.79
altair processBlock - 250000 vs - 7PWei worstcase hashState 100.42 ms/op 113.32 ms/op 0.89
phase0 processBlock - 250000 vs - 7PWei normalcase 5.1060 ms/op 5.2650 ms/op 0.97
phase0 processBlock - 250000 vs - 7PWei worstcase 47.879 ms/op 56.006 ms/op 0.85
altair processEth1Data - 250000 vs - 7PWei normalcase 802.66 us/op 1.1266 ms/op 0.71
Tree 40 250000 create 818.81 ms/op 906.16 ms/op 0.90
Tree 40 250000 get(125000) 294.75 ns/op 342.43 ns/op 0.86
Tree 40 250000 set(125000) 2.6345 us/op 3.0463 us/op 0.86
Tree 40 250000 toArray() 33.338 ms/op 37.525 ms/op 0.89
Tree 40 250000 iterate all - toArray() + loop 34.990 ms/op 37.494 ms/op 0.93
Tree 40 250000 iterate all - get(i) 113.52 ms/op 133.21 ms/op 0.85
MutableVector 250000 create 15.321 ms/op 18.688 ms/op 0.82
MutableVector 250000 get(125000) 14.752 ns/op 17.930 ns/op 0.82
MutableVector 250000 set(125000) 635.87 ns/op 585.42 ns/op 1.09
MutableVector 250000 toArray() 6.7455 ms/op 7.6540 ms/op 0.88
MutableVector 250000 iterate all - toArray() + loop 7.0700 ms/op 7.8111 ms/op 0.91
MutableVector 250000 iterate all - get(i) 3.4384 ms/op 4.0149 ms/op 0.86
Array 250000 create 5.8203 ms/op 7.0599 ms/op 0.82
Array 250000 clone - spread 3.4413 ms/op 2.8794 ms/op 1.20
Array 250000 get(125000) 1.4780 ns/op 1.3170 ns/op 1.12
Array 250000 set(125000) 1.4850 ns/op 1.3010 ns/op 1.14
Array 250000 iterate all - loop 167.84 us/op 193.04 us/op 0.87
effectiveBalanceIncrements clone Uint8Array 300000 79.477 us/op 80.962 us/op 0.98
effectiveBalanceIncrements clone MutableVector 300000 1.1080 us/op 855.00 ns/op 1.30
effectiveBalanceIncrements rw all Uint8Array 300000 252.29 us/op 294.55 us/op 0.86
effectiveBalanceIncrements rw all MutableVector 300000 204.65 ms/op 186.71 ms/op 1.10
phase0 afterProcessEpoch - 250000 vs - 7PWei 184.08 ms/op 210.53 ms/op 0.87
phase0 beforeProcessEpoch - 250000 vs - 7PWei 106.46 ms/op 77.949 ms/op 1.37
altair processEpoch - mainnet_e81889 581.78 ms/op 667.38 ms/op 0.87
mainnet_e81889 - altair beforeProcessEpoch 143.90 ms/op 168.82 ms/op 0.85
mainnet_e81889 - altair processJustificationAndFinalization 41.216 us/op 33.722 us/op 1.22
mainnet_e81889 - altair processInactivityUpdates 12.138 ms/op 12.697 ms/op 0.96
mainnet_e81889 - altair processRewardsAndPenalties 93.253 ms/op 107.86 ms/op 0.86
mainnet_e81889 - altair processRegistryUpdates 6.6410 us/op 7.1000 us/op 0.94
mainnet_e81889 - altair processSlashings 1.7700 us/op 2.3340 us/op 0.76
mainnet_e81889 - altair processEth1DataReset 1.9750 us/op 2.0340 us/op 0.97
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.4309 ms/op 2.6931 ms/op 0.90
mainnet_e81889 - altair processSlashingsReset 10.337 us/op 10.638 us/op 0.97
mainnet_e81889 - altair processRandaoMixesReset 11.454 us/op 11.953 us/op 0.96
mainnet_e81889 - altair processHistoricalRootsUpdate 2.0220 us/op 1.9330 us/op 1.05
mainnet_e81889 - altair processParticipationFlagUpdates 5.2740 us/op 6.4940 us/op 0.81
mainnet_e81889 - altair processSyncCommitteeUpdates 1.3490 us/op 1.7130 us/op 0.79
mainnet_e81889 - altair afterProcessEpoch 192.60 ms/op 225.42 ms/op 0.85
phase0 processEpoch - mainnet_e58758 531.79 ms/op 611.91 ms/op 0.87
mainnet_e58758 - phase0 beforeProcessEpoch 232.48 ms/op 257.42 ms/op 0.90
mainnet_e58758 - phase0 processJustificationAndFinalization 24.907 us/op 32.502 us/op 0.77
mainnet_e58758 - phase0 processRewardsAndPenalties 86.182 ms/op 99.155 ms/op 0.87
mainnet_e58758 - phase0 processRegistryUpdates 22.618 us/op 16.185 us/op 1.40
mainnet_e58758 - phase0 processSlashings 1.8700 us/op 1.8440 us/op 1.01
mainnet_e58758 - phase0 processEth1DataReset 1.9730 us/op 1.9840 us/op 0.99
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.1094 ms/op 2.3770 ms/op 0.89
mainnet_e58758 - phase0 processSlashingsReset 9.2550 us/op 10.247 us/op 0.90
mainnet_e58758 - phase0 processRandaoMixesReset 11.410 us/op 12.506 us/op 0.91
mainnet_e58758 - phase0 processHistoricalRootsUpdate 2.1770 us/op 2.3180 us/op 0.94
mainnet_e58758 - phase0 processParticipationRecordUpdates 10.750 us/op 11.231 us/op 0.96
mainnet_e58758 - phase0 afterProcessEpoch 160.43 ms/op 190.04 ms/op 0.84
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.7810 ms/op 3.0534 ms/op 0.91
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.0846 ms/op 3.6346 ms/op 0.85
altair processInactivityUpdates - 250000 normalcase 42.505 ms/op 55.347 ms/op 0.77
altair processInactivityUpdates - 250000 worstcase 40.540 ms/op 48.359 ms/op 0.84
phase0 processRegistryUpdates - 250000 normalcase 16.470 us/op 14.053 us/op 1.17
phase0 processRegistryUpdates - 250000 badcase_full_deposits 458.71 us/op 554.50 us/op 0.83
phase0 processRegistryUpdates - 250000 worstcase 0.5 195.97 ms/op 274.30 ms/op 0.71
altair processRewardsAndPenalties - 250000 normalcase 90.387 ms/op 142.91 ms/op 0.63
altair processRewardsAndPenalties - 250000 worstcase 132.04 ms/op 100.66 ms/op 1.31
phase0 getAttestationDeltas - 250000 normalcase 12.493 ms/op 15.927 ms/op 0.78
phase0 getAttestationDeltas - 250000 worstcase 12.429 ms/op 15.588 ms/op 0.80
phase0 processSlashings - 250000 worstcase 5.5189 ms/op 6.3952 ms/op 0.86
altair processSyncCommitteeUpdates - 250000 285.58 ms/op 332.01 ms/op 0.86
BeaconState.hashTreeRoot - No change 467.00 ns/op 554.00 ns/op 0.84
BeaconState.hashTreeRoot - 1 full validator 56.656 us/op 64.361 us/op 0.88
BeaconState.hashTreeRoot - 32 full validator 549.08 us/op 666.39 us/op 0.82
BeaconState.hashTreeRoot - 512 full validator 6.1499 ms/op 7.3774 ms/op 0.83
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 69.848 us/op 83.339 us/op 0.84
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 965.35 us/op 1.1114 ms/op 0.87
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 12.651 ms/op 16.020 ms/op 0.79
BeaconState.hashTreeRoot - 1 balances 53.109 us/op 62.361 us/op 0.85
BeaconState.hashTreeRoot - 32 balances 463.77 us/op 543.07 us/op 0.85
BeaconState.hashTreeRoot - 512 balances 4.5160 ms/op 5.4793 ms/op 0.82
BeaconState.hashTreeRoot - 250000 balances 80.265 ms/op 118.17 ms/op 0.68
aggregationBits - 2048 els - zipIndexesInBitList 32.341 us/op 32.071 us/op 1.01
regular array get 100000 times 67.518 us/op 78.777 us/op 0.86
wrappedArray get 100000 times 67.434 us/op 78.649 us/op 0.86
arrayWithProxy get 100000 times 28.956 ms/op 33.536 ms/op 0.86
ssz.Root.equals 470.00 ns/op 565.00 ns/op 0.83
byteArrayEquals 455.00 ns/op 561.00 ns/op 0.81
shuffle list - 16384 els 11.046 ms/op 12.682 ms/op 0.87
shuffle list - 250000 els 162.58 ms/op 189.02 ms/op 0.86
processSlot - 1 slots 11.556 us/op 13.564 us/op 0.85
processSlot - 32 slots 1.7379 ms/op 2.0164 ms/op 0.86
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 383.67 us/op 585.74 us/op 0.66
getCommitteeAssignments - req 1 vs - 250000 vc 5.2686 ms/op 6.1697 ms/op 0.85
getCommitteeAssignments - req 100 vs - 250000 vc 7.2817 ms/op 8.5948 ms/op 0.85
getCommitteeAssignments - req 1000 vs - 250000 vc 7.7349 ms/op 9.1501 ms/op 0.85
computeProposers - vc 250000 17.170 ms/op 21.381 ms/op 0.80
computeEpochShuffling - vc 250000 165.36 ms/op 194.47 ms/op 0.85
getNextSyncCommittee - vc 250000 285.13 ms/op 314.37 ms/op 0.91

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 8ccbcb8 into unstable Jul 18, 2022
@wemeetagain wemeetagain deleted the dapplion/goerli-flag branch July 18, 2022 13:13
philknows pushed a commit that referenced this pull request Jul 21, 2022
@dapplion @philknows
Add goerli flag (#4316)
62e214a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@tuyennhv tuyennhv tuyennhv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add goerli alias flag
3 participants
@dapplion @wemeetagain @tuyennhv