Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msgIdFn: use Buffer.subarray() #4342

Merged
merged 2 commits into from
Aug 1, 2022
Merged

msgIdFn: use Buffer.subarray() #4342

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4031855
msgIdFn: use Buffer.slice()
twoeths Jul 24, 2022
197c50f
Use Buffer.subarray() instead of Buffer.slice()
twoeths Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/beacon-node/src/network/gossip/encoding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export function msgIdFn(gossipTopicCache: GossipTopicCache, msg: GossipsubMessag
}
}

return digest(Buffer.concat(vec)).slice(0, 20);
return Buffer.from(digest(Buffer.concat(vec))).slice(0, 20);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buffer.slice() is deprecated in Node.js 18, should we migrate similar pattern to Uint8Array.subarray()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

}

export class DataTransformSnappy {
Expand Down