Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution status to notifier on/post bellatrix #4366

Merged
merged 1 commit into from Aug 5, 2022

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Aug 5, 2022

Right now, we can see execution: premerge -, while its a good idea to show it only post bellatrix, and can also act as an indication for the user if lodestar's head is post bellatrix (There can still be time between bellatrix transition and the merge where premerge text transforms into the actual execution status)

@g11tech g11tech requested a review from a team as a code owner August 5, 2022 10:46
@g11tech g11tech enabled auto-merge (squash) August 5, 2022 10:46
@g11tech g11tech merged commit 107a983 into unstable Aug 5, 2022
@g11tech g11tech deleted the g11tech/notify-exec-post-bella branch August 5, 2022 11:07
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Performance Report

✔️ no performance regression detected

🚀🚀 Significant benchmark improvement detected

Benchmark suite Current: bf6f24f Previous: b34abb7 Ratio
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 384.52 us/op 1.2044 ms/op 0.32
Full benchmark results
Benchmark suite Current: bf6f24f Previous: b34abb7 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.5448 ms/op 2.0731 ms/op 1.23
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 72.414 us/op 76.264 us/op 0.95
BLS verify - blst-native 2.1653 ms/op 2.5407 ms/op 0.85
BLS verifyMultipleSignatures 3 - blst-native 4.4738 ms/op 5.2459 ms/op 0.85
BLS verifyMultipleSignatures 8 - blst-native 9.6643 ms/op 10.990 ms/op 0.88
BLS verifyMultipleSignatures 32 - blst-native 35.136 ms/op 39.967 ms/op 0.88
BLS aggregatePubkeys 32 - blst-native 46.687 us/op 55.284 us/op 0.84
BLS aggregatePubkeys 128 - blst-native 182.36 us/op 209.85 us/op 0.87
getAttestationsForBlock 159.84 ms/op 179.16 ms/op 0.89
isKnown best case - 1 super set check 489.00 ns/op 465.00 ns/op 1.05
isKnown normal case - 2 super set checks 485.00 ns/op 479.00 ns/op 1.01
isKnown worse case - 16 super set checks 486.00 ns/op 475.00 ns/op 1.02
CheckpointStateCache - add get delete 9.5200 us/op 10.065 us/op 0.95
validate gossip signedAggregateAndProof - struct 5.0339 ms/op 5.6849 ms/op 0.89
validate gossip attestation - struct 2.3602 ms/op 2.7814 ms/op 0.85
altair verifyImport mainnet_s3766816:31 9.1288 s/op 10.056 s/op 0.91
pickEth1Vote - no votes 2.1552 ms/op 2.3491 ms/op 0.92
pickEth1Vote - max votes 24.457 ms/op 22.161 ms/op 1.10
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.449 ms/op 13.552 ms/op 0.99
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.454 ms/op 22.032 ms/op 1.02
pickEth1Vote - Eth1Data fastSerialize value x2048 1.5422 ms/op 1.7145 ms/op 0.90
pickEth1Vote - Eth1Data fastSerialize tree x2048 17.446 ms/op 15.849 ms/op 1.10
bytes32 toHexString 1.2080 us/op 1.1710 us/op 1.03
bytes32 Buffer.toString(hex) 828.00 ns/op 778.00 ns/op 1.06
bytes32 Buffer.toString(hex) from Uint8Array 1.1270 us/op 1.0580 us/op 1.07
bytes32 Buffer.toString(hex) + 0x 826.00 ns/op 786.00 ns/op 1.05
Object access 1 prop 0.43800 ns/op 0.41000 ns/op 1.07
Map access 1 prop 0.31600 ns/op 0.30800 ns/op 1.03
Object get x1000 10.844 ns/op 14.655 ns/op 0.74
Map get x1000 0.93500 ns/op 0.88900 ns/op 1.05
Object set x1000 86.976 ns/op 106.90 ns/op 0.81
Map set x1000 59.230 ns/op 74.839 ns/op 0.79
Return object 10000 times 0.43990 ns/op 0.39400 ns/op 1.12
Throw Error 10000 times 6.1203 us/op 6.5403 us/op 0.94
enrSubnets - fastDeserialize 64 bits 3.2550 us/op 3.0190 us/op 1.08
enrSubnets - ssz BitVector 64 bits 876.00 ns/op 905.00 ns/op 0.97
enrSubnets - fastDeserialize 4 bits 444.00 ns/op 401.00 ns/op 1.11
enrSubnets - ssz BitVector 4 bits 883.00 ns/op 867.00 ns/op 1.02
prioritizePeers score -10:0 att 32-0.1 sync 2-0 94.101 us/op 102.04 us/op 0.92
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 134.25 us/op 140.59 us/op 0.95
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 244.09 us/op 250.07 us/op 0.98
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 336.08 us/op 544.71 us/op 0.62
prioritizePeers score 0:0 att 64-1 sync 4-1 407.95 us/op 613.00 us/op 0.67
RateTracker 1000000 limit, 1 obj count per request 204.64 ns/op 203.20 ns/op 1.01
RateTracker 1000000 limit, 2 obj count per request 153.87 ns/op 149.11 ns/op 1.03
RateTracker 1000000 limit, 4 obj count per request 127.96 ns/op 125.36 ns/op 1.02
RateTracker 1000000 limit, 8 obj count per request 114.83 ns/op 121.56 ns/op 0.94
RateTracker with prune 5.1810 us/op 5.1230 us/op 1.01
array of 16000 items push then shift 51.607 us/op 4.9314 us/op 10.47
LinkedList of 16000 items push then shift 17.976 ns/op 18.014 ns/op 1.00
array of 16000 items push then pop 227.92 ns/op 254.59 ns/op 0.90
LinkedList of 16000 items push then pop 14.924 ns/op 17.550 ns/op 0.85
array of 24000 items push then shift 77.385 us/op 7.2688 us/op 10.65
LinkedList of 24000 items push then shift 23.722 ns/op 18.566 ns/op 1.28
array of 24000 items push then pop 205.56 ns/op 203.40 ns/op 1.01
LinkedList of 24000 items push then pop 16.717 ns/op 17.373 ns/op 0.96
intersect bitArray bitLen 8 10.719 ns/op 11.782 ns/op 0.91
intersect array and set length 8 165.09 ns/op 186.16 ns/op 0.89
intersect bitArray bitLen 128 57.756 ns/op 67.480 ns/op 0.86
intersect array and set length 128 2.0394 us/op 2.2906 us/op 0.89
Buffer.concat 32 items 1.8580 ns/op 2.0060 ns/op 0.93
pass gossip attestations to forkchoice per slot 5.4323 ms/op 3.8688 ms/op 1.40
computeDeltas 3.2868 ms/op 3.3988 ms/op 0.97
computeProposerBoostScoreFromBalances 804.96 us/op 819.94 us/op 0.98
altair processAttestation - 250000 vs - 7PWei normalcase 4.0169 ms/op 4.6460 ms/op 0.86
altair processAttestation - 250000 vs - 7PWei worstcase 5.8777 ms/op 6.5096 ms/op 0.90
altair processAttestation - setStatus - 1/6 committees join 180.07 us/op 231.16 us/op 0.78
altair processAttestation - setStatus - 1/3 committees join 347.49 us/op 414.40 us/op 0.84
altair processAttestation - setStatus - 1/2 committees join 510.94 us/op 598.37 us/op 0.85
altair processAttestation - setStatus - 2/3 committees join 649.52 us/op 805.68 us/op 0.81
altair processAttestation - setStatus - 4/5 committees join 903.04 us/op 1.1107 ms/op 0.81
altair processAttestation - setStatus - 100% committees join 1.0972 ms/op 1.3532 ms/op 0.81
altair processBlock - 250000 vs - 7PWei normalcase 24.759 ms/op 28.710 ms/op 0.86
altair processBlock - 250000 vs - 7PWei normalcase hashState 39.369 ms/op 38.800 ms/op 1.01
altair processBlock - 250000 vs - 7PWei worstcase 85.025 ms/op 91.707 ms/op 0.93
altair processBlock - 250000 vs - 7PWei worstcase hashState 115.91 ms/op 116.93 ms/op 0.99
phase0 processBlock - 250000 vs - 7PWei normalcase 4.1349 ms/op 4.5602 ms/op 0.91
phase0 processBlock - 250000 vs - 7PWei worstcase 53.200 ms/op 61.448 ms/op 0.87
altair processEth1Data - 250000 vs - 7PWei normalcase 792.26 us/op 980.18 us/op 0.81
Tree 40 250000 create 741.03 ms/op 918.48 ms/op 0.81
Tree 40 250000 get(125000) 247.91 ns/op 298.60 ns/op 0.83
Tree 40 250000 set(125000) 2.2451 us/op 2.8019 us/op 0.80
Tree 40 250000 toArray() 27.782 ms/op 32.276 ms/op 0.86
Tree 40 250000 iterate all - toArray() + loop 27.909 ms/op 32.271 ms/op 0.86
Tree 40 250000 iterate all - get(i) 118.55 ms/op 126.91 ms/op 0.93
MutableVector 250000 create 13.409 ms/op 17.823 ms/op 0.75
MutableVector 250000 get(125000) 10.994 ns/op 13.656 ns/op 0.81
MutableVector 250000 set(125000) 510.44 ns/op 779.96 ns/op 0.65
MutableVector 250000 toArray() 5.8451 ms/op 6.8777 ms/op 0.85
MutableVector 250000 iterate all - toArray() + loop 6.5611 ms/op 7.3602 ms/op 0.89
MutableVector 250000 iterate all - get(i) 2.6861 ms/op 3.2953 ms/op 0.82
Array 250000 create 5.4140 ms/op 6.4969 ms/op 0.83
Array 250000 clone - spread 2.2412 ms/op 3.9180 ms/op 0.57
Array 250000 get(125000) 1.1040 ns/op 1.6910 ns/op 0.65
Array 250000 set(125000) 1.1010 ns/op 1.7560 ns/op 0.63
Array 250000 iterate all - loop 152.40 us/op 130.41 us/op 1.17
effectiveBalanceIncrements clone Uint8Array 300000 107.18 us/op 172.22 us/op 0.62
effectiveBalanceIncrements clone MutableVector 300000 660.00 ns/op 669.00 ns/op 0.99
effectiveBalanceIncrements rw all Uint8Array 300000 247.65 us/op 287.62 us/op 0.86
effectiveBalanceIncrements rw all MutableVector 300000 144.87 ms/op 192.70 ms/op 0.75
phase0 afterProcessEpoch - 250000 vs - 7PWei 188.58 ms/op 214.63 ms/op 0.88
phase0 beforeProcessEpoch - 250000 vs - 7PWei 61.852 ms/op 70.692 ms/op 0.87
altair processEpoch - mainnet_e81889 575.88 ms/op 649.35 ms/op 0.89
mainnet_e81889 - altair beforeProcessEpoch 130.81 ms/op 97.808 ms/op 1.34
mainnet_e81889 - altair processJustificationAndFinalization 17.292 us/op 71.027 us/op 0.24
mainnet_e81889 - altair processInactivityUpdates 9.1183 ms/op 12.793 ms/op 0.71
mainnet_e81889 - altair processRewardsAndPenalties 82.739 ms/op 97.949 ms/op 0.84
mainnet_e81889 - altair processRegistryUpdates 2.6220 us/op 18.119 us/op 0.14
mainnet_e81889 - altair processSlashings 618.00 ns/op 5.2380 us/op 0.12
mainnet_e81889 - altair processEth1DataReset 641.00 ns/op 5.8600 us/op 0.11
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.9886 ms/op 3.0218 ms/op 0.66
mainnet_e81889 - altair processSlashingsReset 4.3820 us/op 29.822 us/op 0.15
mainnet_e81889 - altair processRandaoMixesReset 4.0680 us/op 32.439 us/op 0.13
mainnet_e81889 - altair processHistoricalRootsUpdate 525.00 ns/op 5.5670 us/op 0.09
mainnet_e81889 - altair processParticipationFlagUpdates 2.2370 us/op 15.156 us/op 0.15
mainnet_e81889 - altair processSyncCommitteeUpdates 551.00 ns/op 4.3300 us/op 0.13
mainnet_e81889 - altair afterProcessEpoch 198.64 ms/op 204.62 ms/op 0.97
phase0 processEpoch - mainnet_e58758 490.93 ms/op 601.27 ms/op 0.82
mainnet_e58758 - phase0 beforeProcessEpoch 184.35 ms/op 260.94 ms/op 0.71
mainnet_e58758 - phase0 processJustificationAndFinalization 16.960 us/op 93.965 us/op 0.18
mainnet_e58758 - phase0 processRewardsAndPenalties 123.08 ms/op 92.259 ms/op 1.33
mainnet_e58758 - phase0 processRegistryUpdates 7.9650 us/op 38.495 us/op 0.21
mainnet_e58758 - phase0 processSlashings 581.00 ns/op 5.6650 us/op 0.10
mainnet_e58758 - phase0 processEth1DataReset 628.00 ns/op 5.4560 us/op 0.12
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.6125 ms/op 2.5061 ms/op 0.64
mainnet_e58758 - phase0 processSlashingsReset 3.4590 us/op 29.701 us/op 0.12
mainnet_e58758 - phase0 processRandaoMixesReset 4.1730 us/op 33.825 us/op 0.12
mainnet_e58758 - phase0 processHistoricalRootsUpdate 695.00 ns/op 5.6110 us/op 0.12
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.6740 us/op 29.180 us/op 0.13
mainnet_e58758 - phase0 afterProcessEpoch 163.63 ms/op 172.99 ms/op 0.95
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.9403 ms/op 2.4011 ms/op 0.81
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.2410 ms/op 2.6567 ms/op 0.84
altair processInactivityUpdates - 250000 normalcase 42.608 ms/op 50.490 ms/op 0.84
altair processInactivityUpdates - 250000 worstcase 42.445 ms/op 47.382 ms/op 0.90
phase0 processRegistryUpdates - 250000 normalcase 6.1650 us/op 33.314 us/op 0.19
phase0 processRegistryUpdates - 250000 badcase_full_deposits 377.90 us/op 504.94 us/op 0.75
phase0 processRegistryUpdates - 250000 worstcase 0.5 191.68 ms/op 251.36 ms/op 0.76
altair processRewardsAndPenalties - 250000 normalcase 114.77 ms/op 138.55 ms/op 0.83
altair processRewardsAndPenalties - 250000 worstcase 77.078 ms/op 114.30 ms/op 0.67
phase0 getAttestationDeltas - 250000 normalcase 13.441 ms/op 14.744 ms/op 0.91
phase0 getAttestationDeltas - 250000 worstcase 13.590 ms/op 14.316 ms/op 0.95
phase0 processSlashings - 250000 worstcase 5.1423 ms/op 6.1379 ms/op 0.84
altair processSyncCommitteeUpdates - 250000 296.67 ms/op 322.63 ms/op 0.92
BeaconState.hashTreeRoot - No change 530.00 ns/op 563.00 ns/op 0.94
BeaconState.hashTreeRoot - 1 full validator 73.936 us/op 79.624 us/op 0.93
BeaconState.hashTreeRoot - 32 full validator 734.20 us/op 820.79 us/op 0.89
BeaconState.hashTreeRoot - 512 full validator 9.0587 ms/op 7.9605 ms/op 1.14
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 91.673 us/op 112.09 us/op 0.82
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.2987 ms/op 1.5251 ms/op 0.85
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 17.338 ms/op 18.925 ms/op 0.92
BeaconState.hashTreeRoot - 1 balances 66.403 us/op 107.70 us/op 0.62
BeaconState.hashTreeRoot - 32 balances 671.95 us/op 678.83 us/op 0.99
BeaconState.hashTreeRoot - 512 balances 6.5894 ms/op 6.8656 ms/op 0.96
BeaconState.hashTreeRoot - 250000 balances 103.85 ms/op 121.52 ms/op 0.85
aggregationBits - 2048 els - zipIndexesInBitList 34.113 us/op 38.464 us/op 0.89
regular array get 100000 times 64.102 us/op 62.012 us/op 1.03
wrappedArray get 100000 times 62.161 us/op 66.255 us/op 0.94
arrayWithProxy get 100000 times 29.094 ms/op 39.302 ms/op 0.74
ssz.Root.equals 600.00 ns/op 656.00 ns/op 0.91
byteArrayEquals 554.00 ns/op 600.00 ns/op 0.92
shuffle list - 16384 els 11.466 ms/op 13.617 ms/op 0.84
shuffle list - 250000 els 167.31 ms/op 181.90 ms/op 0.92
processSlot - 1 slots 13.564 us/op 16.746 us/op 0.81
processSlot - 32 slots 1.9547 ms/op 2.2220 ms/op 0.88
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 384.52 us/op 1.2044 ms/op 0.32
getCommitteeAssignments - req 1 vs - 250000 vc 5.4101 ms/op 5.2004 ms/op 1.04
getCommitteeAssignments - req 100 vs - 250000 vc 7.8578 ms/op 7.7633 ms/op 1.01
getCommitteeAssignments - req 1000 vs - 250000 vc 8.4416 ms/op 7.7833 ms/op 1.08
computeProposers - vc 250000 17.771 ms/op 20.892 ms/op 0.85
computeEpochShuffling - vc 250000 186.42 ms/op 179.90 ms/op 1.04
getNextSyncCommittee - vc 250000 292.83 ms/op 304.10 ms/op 0.96

by benchmarkbot/action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants