Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker image history used tag #4373

Merged
merged 1 commit into from Aug 6, 2022
Merged

Fix docker image history used tag #4373

merged 1 commit into from Aug 6, 2022

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Aug 6, 2022

Motivation

Fixes a regression introduced in #4369

Description

When using docker buildx --push images are not available in the docker cache. In our workflow we do docker run to test the image running, so only that specific tag will be available

@dapplion dapplion requested a review from a team as a code owner August 6, 2022 07:36
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 6341213 Previous: eeb333a Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.9436 ms/op 2.0309 ms/op 0.96
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 73.981 us/op 65.797 us/op 1.12
BLS verify - blst-native 1.8557 ms/op 2.1671 ms/op 0.86
BLS verifyMultipleSignatures 3 - blst-native 3.8015 ms/op 4.4731 ms/op 0.85
BLS verifyMultipleSignatures 8 - blst-native 8.1821 ms/op 9.6694 ms/op 0.85
BLS verifyMultipleSignatures 32 - blst-native 29.673 ms/op 35.164 ms/op 0.84
BLS aggregatePubkeys 32 - blst-native 39.065 us/op 46.611 us/op 0.84
BLS aggregatePubkeys 128 - blst-native 152.59 us/op 182.30 us/op 0.84
getAttestationsForBlock 167.85 ms/op 150.22 ms/op 1.12
isKnown best case - 1 super set check 429.00 ns/op 483.00 ns/op 0.89
isKnown normal case - 2 super set checks 416.00 ns/op 475.00 ns/op 0.88
isKnown worse case - 16 super set checks 413.00 ns/op 471.00 ns/op 0.88
CheckpointStateCache - add get delete 8.6300 us/op 9.1370 us/op 0.94
validate gossip signedAggregateAndProof - struct 4.2637 ms/op 5.0207 ms/op 0.85
validate gossip attestation - struct 2.0300 ms/op 2.3813 ms/op 0.85
altair verifyImport mainnet_s3766816:31 8.8030 s/op 8.7081 s/op 1.01
pickEth1Vote - no votes 2.1426 ms/op 2.1617 ms/op 0.99
pickEth1Vote - max votes 24.011 ms/op 21.007 ms/op 1.14
pickEth1Vote - Eth1Data hashTreeRoot value x2048 11.739 ms/op 12.806 ms/op 0.92
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.172 ms/op 21.131 ms/op 1.05
pickEth1Vote - Eth1Data fastSerialize value x2048 1.6590 ms/op 1.5269 ms/op 1.09
pickEth1Vote - Eth1Data fastSerialize tree x2048 19.008 ms/op 14.772 ms/op 1.29
bytes32 toHexString 1.2410 us/op 1.1190 us/op 1.11
bytes32 Buffer.toString(hex) 730.00 ns/op 852.00 ns/op 0.86
bytes32 Buffer.toString(hex) from Uint8Array 1.0210 us/op 1.0500 us/op 0.97
bytes32 Buffer.toString(hex) + 0x 755.00 ns/op 847.00 ns/op 0.89
Object access 1 prop 0.41700 ns/op 0.38300 ns/op 1.09
Map access 1 prop 0.29900 ns/op 0.34200 ns/op 0.87
Object get x1000 17.516 ns/op 11.025 ns/op 1.59
Map get x1000 1.2090 ns/op 1.0480 ns/op 1.15
Object set x1000 131.94 ns/op 77.801 ns/op 1.70
Map set x1000 75.826 ns/op 51.096 ns/op 1.48
Return object 10000 times 0.37520 ns/op 0.44680 ns/op 0.84
Throw Error 10000 times 5.8587 us/op 6.1034 us/op 0.96
enrSubnets - fastDeserialize 64 bits 2.8220 us/op 2.8000 us/op 1.01
enrSubnets - ssz BitVector 64 bits 740.00 ns/op 849.00 ns/op 0.87
enrSubnets - fastDeserialize 4 bits 393.00 ns/op 492.00 ns/op 0.80
enrSubnets - ssz BitVector 4 bits 741.00 ns/op 852.00 ns/op 0.87
prioritizePeers score -10:0 att 32-0.1 sync 2-0 102.22 us/op 87.745 us/op 1.17
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 123.97 us/op 127.19 us/op 0.97
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 242.04 us/op 228.78 us/op 1.06
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 502.81 us/op 335.30 us/op 1.50
prioritizePeers score 0:0 att 64-1 sync 4-1 463.98 us/op 408.56 us/op 1.14
RateTracker 1000000 limit, 1 obj count per request 210.60 ns/op 194.30 ns/op 1.08
RateTracker 1000000 limit, 2 obj count per request 158.12 ns/op 140.80 ns/op 1.12
RateTracker 1000000 limit, 4 obj count per request 135.23 ns/op 117.59 ns/op 1.15
RateTracker 1000000 limit, 8 obj count per request 121.60 ns/op 102.11 ns/op 1.19
RateTracker with prune 4.6370 us/op 4.5870 us/op 1.01
array of 16000 items push then shift 3.1649 us/op 51.584 us/op 0.06
LinkedList of 16000 items push then shift 29.551 ns/op 12.811 ns/op 2.31
array of 16000 items push then pop 258.23 ns/op 228.80 ns/op 1.13
LinkedList of 16000 items push then pop 23.837 ns/op 12.086 ns/op 1.97
array of 24000 items push then shift 4.5412 us/op 77.338 us/op 0.06
LinkedList of 24000 items push then shift 28.832 ns/op 13.285 ns/op 2.17
array of 24000 items push then pop 206.76 ns/op 198.69 ns/op 1.04
LinkedList of 24000 items push then pop 22.864 ns/op 12.167 ns/op 1.88
intersect bitArray bitLen 8 11.484 ns/op 10.877 ns/op 1.06
intersect array and set length 8 167.02 ns/op 144.58 ns/op 1.16
intersect bitArray bitLen 128 72.004 ns/op 58.696 ns/op 1.23
intersect array and set length 128 2.2550 us/op 1.8506 us/op 1.22
Buffer.concat 32 items 1.8890 ns/op 1.8660 ns/op 1.01
pass gossip attestations to forkchoice per slot 3.1812 ms/op 3.1758 ms/op 1.00
computeDeltas 3.7276 ms/op 3.2829 ms/op 1.14
computeProposerBoostScoreFromBalances 908.08 us/op 810.91 us/op 1.12
altair processAttestation - 250000 vs - 7PWei normalcase 4.5902 ms/op 3.6254 ms/op 1.27
altair processAttestation - 250000 vs - 7PWei worstcase 6.6202 ms/op 5.2707 ms/op 1.26
altair processAttestation - setStatus - 1/6 committees join 210.31 us/op 176.33 us/op 1.19
altair processAttestation - setStatus - 1/3 committees join 395.53 us/op 341.83 us/op 1.16
altair processAttestation - setStatus - 1/2 committees join 552.84 us/op 493.44 us/op 1.12
altair processAttestation - setStatus - 2/3 committees join 708.14 us/op 652.99 us/op 1.08
altair processAttestation - setStatus - 4/5 committees join 983.17 us/op 903.33 us/op 1.09
altair processAttestation - setStatus - 100% committees join 1.1619 ms/op 1.0921 ms/op 1.06
altair processBlock - 250000 vs - 7PWei normalcase 27.986 ms/op 24.866 ms/op 1.13
altair processBlock - 250000 vs - 7PWei normalcase hashState 43.492 ms/op 39.350 ms/op 1.11
altair processBlock - 250000 vs - 7PWei worstcase 81.589 ms/op 83.543 ms/op 0.98
altair processBlock - 250000 vs - 7PWei worstcase hashState 98.796 ms/op 110.54 ms/op 0.89
phase0 processBlock - 250000 vs - 7PWei normalcase 4.8801 ms/op 3.7716 ms/op 1.29
phase0 processBlock - 250000 vs - 7PWei worstcase 48.786 ms/op 52.525 ms/op 0.93
altair processEth1Data - 250000 vs - 7PWei normalcase 867.33 us/op 733.62 us/op 1.18
Tree 40 250000 create 886.57 ms/op 719.30 ms/op 1.23
Tree 40 250000 get(125000) 293.73 ns/op 236.74 ns/op 1.24
Tree 40 250000 set(125000) 2.9116 us/op 2.2366 us/op 1.30
Tree 40 250000 toArray() 33.807 ms/op 27.773 ms/op 1.22
Tree 40 250000 iterate all - toArray() + loop 34.729 ms/op 27.887 ms/op 1.25
Tree 40 250000 iterate all - get(i) 116.70 ms/op 109.53 ms/op 1.07
MutableVector 250000 create 19.078 ms/op 13.344 ms/op 1.43
MutableVector 250000 get(125000) 15.139 ns/op 11.032 ns/op 1.37
MutableVector 250000 set(125000) 708.51 ns/op 567.49 ns/op 1.25
MutableVector 250000 toArray() 7.6623 ms/op 6.1487 ms/op 1.25
MutableVector 250000 iterate all - toArray() + loop 7.9503 ms/op 6.3909 ms/op 1.24
MutableVector 250000 iterate all - get(i) 3.2775 ms/op 2.6894 ms/op 1.22
Array 250000 create 7.0337 ms/op 6.3634 ms/op 1.11
Array 250000 clone - spread 3.9380 ms/op 2.3906 ms/op 1.65
Array 250000 get(125000) 1.6430 ns/op 1.1340 ns/op 1.45
Array 250000 set(125000) 1.6480 ns/op 1.1270 ns/op 1.46
Array 250000 iterate all - loop 170.41 us/op 151.01 us/op 1.13
effectiveBalanceIncrements clone Uint8Array 300000 86.591 us/op 35.902 us/op 2.41
effectiveBalanceIncrements clone MutableVector 300000 631.00 ns/op 690.00 ns/op 0.91
effectiveBalanceIncrements rw all Uint8Array 300000 252.44 us/op 247.35 us/op 1.02
effectiveBalanceIncrements rw all MutableVector 300000 170.79 ms/op 136.63 ms/op 1.25
phase0 afterProcessEpoch - 250000 vs - 7PWei 199.32 ms/op 186.36 ms/op 1.07
phase0 beforeProcessEpoch - 250000 vs - 7PWei 76.935 ms/op 58.419 ms/op 1.32
altair processEpoch - mainnet_e81889 591.29 ms/op 534.03 ms/op 1.11
mainnet_e81889 - altair beforeProcessEpoch 135.72 ms/op 118.23 ms/op 1.15
mainnet_e81889 - altair processJustificationAndFinalization 20.480 us/op 16.415 us/op 1.25
mainnet_e81889 - altair processInactivityUpdates 11.534 ms/op 8.7458 ms/op 1.32
mainnet_e81889 - altair processRewardsAndPenalties 96.241 ms/op 120.46 ms/op 0.80
mainnet_e81889 - altair processRegistryUpdates 5.0260 us/op 2.7170 us/op 1.85
mainnet_e81889 - altair processSlashings 1.1940 us/op 512.00 ns/op 2.33
mainnet_e81889 - altair processEth1DataReset 1.2880 us/op 621.00 ns/op 2.07
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.3802 ms/op 2.1033 ms/op 1.13
mainnet_e81889 - altair processSlashingsReset 8.8420 us/op 4.3820 us/op 2.02
mainnet_e81889 - altair processRandaoMixesReset 7.4220 us/op 4.5630 us/op 1.63
mainnet_e81889 - altair processHistoricalRootsUpdate 910.00 ns/op 690.00 ns/op 1.32
mainnet_e81889 - altair processParticipationFlagUpdates 3.7090 us/op 8.2120 us/op 0.45
mainnet_e81889 - altair processSyncCommitteeUpdates 812.00 ns/op 799.00 ns/op 1.02
mainnet_e81889 - altair afterProcessEpoch 197.22 ms/op 217.65 ms/op 0.91
phase0 processEpoch - mainnet_e58758 554.60 ms/op 631.10 ms/op 0.88
mainnet_e58758 - phase0 beforeProcessEpoch 247.10 ms/op 223.45 ms/op 1.11
mainnet_e58758 - phase0 processJustificationAndFinalization 20.941 us/op 16.341 us/op 1.28
mainnet_e58758 - phase0 processRewardsAndPenalties 144.91 ms/op 128.84 ms/op 1.12
mainnet_e58758 - phase0 processRegistryUpdates 11.199 us/op 7.9240 us/op 1.41
mainnet_e58758 - phase0 processSlashings 902.00 ns/op 561.00 ns/op 1.61
mainnet_e58758 - phase0 processEth1DataReset 1.1180 us/op 586.00 ns/op 1.91
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.2038 ms/op 1.9525 ms/op 1.13
mainnet_e58758 - phase0 processSlashingsReset 4.8150 us/op 4.2680 us/op 1.13
mainnet_e58758 - phase0 processRandaoMixesReset 7.4530 us/op 4.7450 us/op 1.57
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.0670 us/op 671.00 ns/op 1.59
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.0770 us/op 3.9040 us/op 1.30
mainnet_e58758 - phase0 afterProcessEpoch 161.62 ms/op 162.05 ms/op 1.00
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.5460 ms/op 2.0050 ms/op 1.27
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.0615 ms/op 2.2349 ms/op 1.37
altair processInactivityUpdates - 250000 normalcase 43.881 ms/op 50.598 ms/op 0.87
altair processInactivityUpdates - 250000 worstcase 52.468 ms/op 51.535 ms/op 1.02
phase0 processRegistryUpdates - 250000 normalcase 8.5760 us/op 6.5030 us/op 1.32
phase0 processRegistryUpdates - 250000 badcase_full_deposits 431.32 us/op 363.53 us/op 1.19
phase0 processRegistryUpdates - 250000 worstcase 0.5 225.41 ms/op 227.99 ms/op 0.99
altair processRewardsAndPenalties - 250000 normalcase 150.08 ms/op 133.81 ms/op 1.12
altair processRewardsAndPenalties - 250000 worstcase 125.39 ms/op 139.67 ms/op 0.90
phase0 getAttestationDeltas - 250000 normalcase 12.448 ms/op 11.899 ms/op 1.05
phase0 getAttestationDeltas - 250000 worstcase 13.307 ms/op 11.725 ms/op 1.13
phase0 processSlashings - 250000 worstcase 5.3300 ms/op 5.1307 ms/op 1.04
altair processSyncCommitteeUpdates - 250000 288.31 ms/op 295.23 ms/op 0.98
BeaconState.hashTreeRoot - No change 468.00 ns/op 516.00 ns/op 0.91
BeaconState.hashTreeRoot - 1 full validator 61.868 us/op 71.457 us/op 0.87
BeaconState.hashTreeRoot - 32 full validator 638.03 us/op 737.57 us/op 0.87
BeaconState.hashTreeRoot - 512 full validator 6.5680 ms/op 8.2199 ms/op 0.80
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 77.939 us/op 81.076 us/op 0.96
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.1959 ms/op 1.2588 ms/op 0.95
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 16.222 ms/op 18.843 ms/op 0.86
BeaconState.hashTreeRoot - 1 balances 68.396 us/op 64.585 us/op 1.06
BeaconState.hashTreeRoot - 32 balances 559.91 us/op 725.12 us/op 0.77
BeaconState.hashTreeRoot - 512 balances 5.7648 ms/op 10.501 ms/op 0.55
BeaconState.hashTreeRoot - 250000 balances 95.203 ms/op 109.78 ms/op 0.87
aggregationBits - 2048 els - zipIndexesInBitList 35.362 us/op 26.153 us/op 1.35
regular array get 100000 times 67.503 us/op 65.111 us/op 1.04
wrappedArray get 100000 times 67.417 us/op 64.688 us/op 1.04
arrayWithProxy get 100000 times 29.201 ms/op 27.565 ms/op 1.06
ssz.Root.equals 472.00 ns/op 541.00 ns/op 0.87
byteArrayEquals 486.00 ns/op 528.00 ns/op 0.92
shuffle list - 16384 els 11.314 ms/op 11.463 ms/op 0.99
shuffle list - 250000 els 166.48 ms/op 165.16 ms/op 1.01
processSlot - 1 slots 12.487 us/op 13.321 us/op 0.94
processSlot - 32 slots 1.7916 ms/op 1.9314 ms/op 0.93
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 395.63 us/op 389.64 us/op 1.02
getCommitteeAssignments - req 1 vs - 250000 vc 5.3363 ms/op 5.4601 ms/op 0.98
getCommitteeAssignments - req 100 vs - 250000 vc 7.3346 ms/op 7.9619 ms/op 0.92
getCommitteeAssignments - req 1000 vs - 250000 vc 7.7551 ms/op 8.5932 ms/op 0.90
computeProposers - vc 250000 19.015 ms/op 18.870 ms/op 1.01
computeEpochShuffling - vc 250000 169.59 ms/op 170.00 ms/op 1.00
getNextSyncCommittee - vc 250000 284.51 ms/op 283.61 ms/op 1.00

by benchmarkbot/action

@g11tech g11tech merged commit 1da9558 into unstable Aug 6, 2022
@g11tech g11tech deleted the dapplion/history-tag branch August 6, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants