Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a test file name #4389

Merged
merged 1 commit into from Aug 9, 2022
Merged

Fix a test file name #4389

merged 1 commit into from Aug 9, 2022

Conversation

nazarhussain
Copy link
Contributor

Motivation

A test file was renamed recently but mistakenly missed the .test suffix.

Description

Fixed the test file name.

@nazarhussain nazarhussain requested a review from a team as a code owner August 9, 2022 09:29
@dapplion dapplion enabled auto-merge (squash) August 9, 2022 09:42
@dapplion dapplion merged commit 0de0144 into unstable Aug 9, 2022
@dapplion dapplion deleted the nh/small-test-fix branch August 9, 2022 09:51
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: e612650 Previous: e9c1f05 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.2398 ms/op 2.1352 ms/op 1.05
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 77.811 us/op 67.487 us/op 1.15
BLS verify - blst-native 1.8503 ms/op 2.1671 ms/op 0.85
BLS verifyMultipleSignatures 3 - blst-native 3.7896 ms/op 4.4740 ms/op 0.85
BLS verifyMultipleSignatures 8 - blst-native 8.1666 ms/op 9.6768 ms/op 0.84
BLS verifyMultipleSignatures 32 - blst-native 29.606 ms/op 35.197 ms/op 0.84
BLS aggregatePubkeys 32 - blst-native 38.943 us/op 47.037 us/op 0.83
BLS aggregatePubkeys 128 - blst-native 151.93 us/op 182.48 us/op 0.83
getAttestationsForBlock 166.22 ms/op 143.70 ms/op 1.16
isKnown best case - 1 super set check 433.00 ns/op 468.00 ns/op 0.93
isKnown normal case - 2 super set checks 409.00 ns/op 465.00 ns/op 0.88
isKnown worse case - 16 super set checks 408.00 ns/op 475.00 ns/op 0.86
CheckpointStateCache - add get delete 9.1200 us/op 8.5840 us/op 1.06
validate gossip signedAggregateAndProof - struct 4.2614 ms/op 5.0236 ms/op 0.85
validate gossip attestation - struct 2.0296 ms/op 2.3619 ms/op 0.86
altair verifyImport mainnet_s3766816:31 8.5236 s/op 8.7530 s/op 0.97
pickEth1Vote - no votes 2.1350 ms/op 2.0387 ms/op 1.05
pickEth1Vote - max votes 21.598 ms/op 18.251 ms/op 1.18
pickEth1Vote - Eth1Data hashTreeRoot value x2048 11.458 ms/op 12.141 ms/op 0.94
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 21.161 ms/op 19.171 ms/op 1.10
pickEth1Vote - Eth1Data fastSerialize value x2048 1.6891 ms/op 1.4095 ms/op 1.20
pickEth1Vote - Eth1Data fastSerialize tree x2048 15.998 ms/op 13.359 ms/op 1.20
bytes32 toHexString 1.1520 us/op 969.00 ns/op 1.19
bytes32 Buffer.toString(hex) 783.00 ns/op 773.00 ns/op 1.01
bytes32 Buffer.toString(hex) from Uint8Array 983.00 ns/op 1.0140 us/op 0.97
bytes32 Buffer.toString(hex) + 0x 723.00 ns/op 775.00 ns/op 0.93
Object access 1 prop 0.38300 ns/op 0.40200 ns/op 0.95
Map access 1 prop 0.29400 ns/op 0.29600 ns/op 0.99
Object get x1000 17.520 ns/op 11.087 ns/op 1.58
Map get x1000 1.1690 ns/op 0.96700 ns/op 1.21
Object set x1000 124.07 ns/op 73.115 ns/op 1.70
Map set x1000 74.273 ns/op 49.851 ns/op 1.49
Return object 10000 times 0.36860 ns/op 0.43270 ns/op 0.85
Throw Error 10000 times 5.9614 us/op 6.3659 us/op 0.94
enrSubnets - fastDeserialize 64 bits 2.9200 us/op 2.7840 us/op 1.05
enrSubnets - ssz BitVector 64 bits 850.00 ns/op 799.00 ns/op 1.06
enrSubnets - fastDeserialize 4 bits 451.00 ns/op 384.00 ns/op 1.17
enrSubnets - ssz BitVector 4 bits 777.00 ns/op 829.00 ns/op 0.94
prioritizePeers score -10:0 att 32-0.1 sync 2-0 102.48 us/op 84.607 us/op 1.21
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 139.88 us/op 115.15 us/op 1.21
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 245.37 us/op 199.35 us/op 1.23
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 392.02 us/op 385.66 us/op 1.02
prioritizePeers score 0:0 att 64-1 sync 4-1 454.40 us/op 405.92 us/op 1.12
RateTracker 1000000 limit, 1 obj count per request 207.70 ns/op 187.20 ns/op 1.11
RateTracker 1000000 limit, 2 obj count per request 156.77 ns/op 138.30 ns/op 1.13
RateTracker 1000000 limit, 4 obj count per request 127.00 ns/op 113.52 ns/op 1.12
RateTracker 1000000 limit, 8 obj count per request 120.59 ns/op 101.26 ns/op 1.19
RateTracker with prune 5.0570 us/op 4.2760 us/op 1.18
array of 16000 items push then shift 3.0765 us/op 51.572 us/op 0.06
LinkedList of 16000 items push then shift 27.081 ns/op 12.383 ns/op 2.19
array of 16000 items push then pop 264.59 ns/op 218.17 ns/op 1.21
LinkedList of 16000 items push then pop 21.847 ns/op 12.039 ns/op 1.81
array of 24000 items push then shift 4.5651 us/op 77.334 us/op 0.06
LinkedList of 24000 items push then shift 29.040 ns/op 12.725 ns/op 2.28
array of 24000 items push then pop 207.43 ns/op 188.79 ns/op 1.10
LinkedList of 24000 items push then pop 21.701 ns/op 12.108 ns/op 1.79
intersect bitArray bitLen 8 11.771 ns/op 11.086 ns/op 1.06
intersect array and set length 8 188.77 ns/op 141.54 ns/op 1.33
intersect bitArray bitLen 128 62.003 ns/op 55.560 ns/op 1.12
intersect array and set length 128 2.5460 us/op 1.7868 us/op 1.42
Buffer.concat 32 items 1.9840 ns/op 1.7610 ns/op 1.13
pass gossip attestations to forkchoice per slot 3.5285 ms/op 5.2370 ms/op 0.67
computeDeltas 3.0840 ms/op 3.1849 ms/op 0.97
computeProposerBoostScoreFromBalances 921.40 us/op 806.44 us/op 1.14
altair processAttestation - 250000 vs - 7PWei normalcase 4.4373 ms/op 3.3591 ms/op 1.32
altair processAttestation - 250000 vs - 7PWei worstcase 6.0800 ms/op 5.1343 ms/op 1.18
altair processAttestation - setStatus - 1/6 committees join 205.22 us/op 173.32 us/op 1.18
altair processAttestation - setStatus - 1/3 committees join 396.11 us/op 335.12 us/op 1.18
altair processAttestation - setStatus - 1/2 committees join 550.60 us/op 479.56 us/op 1.15
altair processAttestation - setStatus - 2/3 committees join 710.00 us/op 623.76 us/op 1.14
altair processAttestation - setStatus - 4/5 committees join 997.35 us/op 881.00 us/op 1.13
altair processAttestation - setStatus - 100% committees join 1.1651 ms/op 1.0582 ms/op 1.10
altair processBlock - 250000 vs - 7PWei normalcase 27.994 ms/op 27.133 ms/op 1.03
altair processBlock - 250000 vs - 7PWei normalcase hashState 41.395 ms/op 34.507 ms/op 1.20
altair processBlock - 250000 vs - 7PWei worstcase 79.956 ms/op 79.772 ms/op 1.00
altair processBlock - 250000 vs - 7PWei worstcase hashState 104.32 ms/op 108.31 ms/op 0.96
phase0 processBlock - 250000 vs - 7PWei normalcase 4.0590 ms/op 3.6387 ms/op 1.12
phase0 processBlock - 250000 vs - 7PWei worstcase 47.043 ms/op 51.033 ms/op 0.92
altair processEth1Data - 250000 vs - 7PWei normalcase 788.15 us/op 703.50 us/op 1.12
Tree 40 250000 create 820.08 ms/op 667.34 ms/op 1.23
Tree 40 250000 get(125000) 289.95 ns/op 225.09 ns/op 1.29
Tree 40 250000 set(125000) 2.4366 us/op 2.0128 us/op 1.21
Tree 40 250000 toArray() 32.230 ms/op 25.739 ms/op 1.25
Tree 40 250000 iterate all - toArray() + loop 31.688 ms/op 25.106 ms/op 1.26
Tree 40 250000 iterate all - get(i) 111.51 ms/op 105.73 ms/op 1.05
MutableVector 250000 create 15.128 ms/op 13.013 ms/op 1.16
MutableVector 250000 get(125000) 14.999 ns/op 10.958 ns/op 1.37
MutableVector 250000 set(125000) 603.90 ns/op 496.08 ns/op 1.22
MutableVector 250000 toArray() 7.3161 ms/op 5.6030 ms/op 1.31
MutableVector 250000 iterate all - toArray() + loop 7.5495 ms/op 5.7844 ms/op 1.31
MutableVector 250000 iterate all - get(i) 3.4403 ms/op 2.7626 ms/op 1.25
Array 250000 create 6.7540 ms/op 5.5967 ms/op 1.21
Array 250000 clone - spread 3.7866 ms/op 3.2709 ms/op 1.16
Array 250000 get(125000) 1.5030 ns/op 1.5180 ns/op 0.99
Array 250000 set(125000) 1.5000 ns/op 1.5240 ns/op 0.98
Array 250000 iterate all - loop 170.24 us/op 156.09 us/op 1.09
effectiveBalanceIncrements clone Uint8Array 300000 87.694 us/op 60.318 us/op 1.45
effectiveBalanceIncrements clone MutableVector 300000 654.00 ns/op 693.00 ns/op 0.94
effectiveBalanceIncrements rw all Uint8Array 300000 253.96 us/op 247.33 us/op 1.03
effectiveBalanceIncrements rw all MutableVector 300000 152.60 ms/op 121.00 ms/op 1.26
phase0 afterProcessEpoch - 250000 vs - 7PWei 184.11 ms/op 200.15 ms/op 0.92
phase0 beforeProcessEpoch - 250000 vs - 7PWei 68.762 ms/op 55.664 ms/op 1.24
altair processEpoch - mainnet_e81889 601.26 ms/op 543.32 ms/op 1.11
mainnet_e81889 - altair beforeProcessEpoch 94.753 ms/op 115.85 ms/op 0.82
mainnet_e81889 - altair processJustificationAndFinalization 22.585 us/op 31.344 us/op 0.72
mainnet_e81889 - altair processInactivityUpdates 10.977 ms/op 8.5753 ms/op 1.28
mainnet_e81889 - altair processRewardsAndPenalties 174.57 ms/op 76.853 ms/op 2.27
mainnet_e81889 - altair processRegistryUpdates 3.4590 us/op 6.7190 us/op 0.51
mainnet_e81889 - altair processSlashings 979.00 ns/op 1.0090 us/op 0.97
mainnet_e81889 - altair processEth1DataReset 861.00 ns/op 601.00 ns/op 1.43
mainnet_e81889 - altair processEffectiveBalanceUpdates 3.0916 ms/op 2.0929 ms/op 1.48
mainnet_e81889 - altair processSlashingsReset 5.7880 us/op 9.1010 us/op 0.64
mainnet_e81889 - altair processRandaoMixesReset 5.7370 us/op 6.5700 us/op 0.87
mainnet_e81889 - altair processHistoricalRootsUpdate 1.0370 us/op 1.0710 us/op 0.97
mainnet_e81889 - altair processParticipationFlagUpdates 3.3710 us/op 5.0940 us/op 0.66
mainnet_e81889 - altair processSyncCommitteeUpdates 651.00 ns/op 1.0710 us/op 0.61
mainnet_e81889 - altair afterProcessEpoch 193.93 ms/op 220.72 ms/op 0.88
phase0 processEpoch - mainnet_e58758 528.19 ms/op 483.74 ms/op 1.09
mainnet_e58758 - phase0 beforeProcessEpoch 230.78 ms/op 171.74 ms/op 1.34
mainnet_e58758 - phase0 processJustificationAndFinalization 20.374 us/op 28.041 us/op 0.73
mainnet_e58758 - phase0 processRewardsAndPenalties 145.18 ms/op 96.719 ms/op 1.50
mainnet_e58758 - phase0 processRegistryUpdates 9.5410 us/op 7.7820 us/op 1.23
mainnet_e58758 - phase0 processSlashings 742.00 ns/op 1.0860 us/op 0.68
mainnet_e58758 - phase0 processEth1DataReset 749.00 ns/op 1.1470 us/op 0.65
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.3428 ms/op 1.7465 ms/op 1.34
mainnet_e58758 - phase0 processSlashingsReset 4.3880 us/op 8.2370 us/op 0.53
mainnet_e58758 - phase0 processRandaoMixesReset 6.1200 us/op 8.2790 us/op 0.74
mainnet_e58758 - phase0 processHistoricalRootsUpdate 889.00 ns/op 1.3310 us/op 0.67
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.6050 us/op 8.2800 us/op 0.68
mainnet_e58758 - phase0 afterProcessEpoch 160.62 ms/op 164.61 ms/op 0.98
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.5422 ms/op 1.9794 ms/op 1.28
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.0671 ms/op 2.2280 ms/op 1.38
altair processInactivityUpdates - 250000 normalcase 39.052 ms/op 33.032 ms/op 1.18
altair processInactivityUpdates - 250000 worstcase 47.559 ms/op 39.449 ms/op 1.21
phase0 processRegistryUpdates - 250000 normalcase 7.9740 us/op 15.949 us/op 0.50
phase0 processRegistryUpdates - 250000 badcase_full_deposits 408.03 us/op 708.30 us/op 0.58
phase0 processRegistryUpdates - 250000 worstcase 0.5 215.11 ms/op 172.10 ms/op 1.25
altair processRewardsAndPenalties - 250000 normalcase 92.429 ms/op 101.15 ms/op 0.91
altair processRewardsAndPenalties - 250000 worstcase 125.58 ms/op 73.175 ms/op 1.72
phase0 getAttestationDeltas - 250000 normalcase 12.505 ms/op 11.969 ms/op 1.04
phase0 getAttestationDeltas - 250000 worstcase 12.620 ms/op 11.496 ms/op 1.10
phase0 processSlashings - 250000 worstcase 5.5487 ms/op 5.3766 ms/op 1.03
altair processSyncCommitteeUpdates - 250000 280.31 ms/op 288.19 ms/op 0.97
BeaconState.hashTreeRoot - No change 469.00 ns/op 503.00 ns/op 0.93
BeaconState.hashTreeRoot - 1 full validator 62.028 us/op 70.005 us/op 0.89
BeaconState.hashTreeRoot - 32 full validator 645.71 us/op 710.98 us/op 0.91
BeaconState.hashTreeRoot - 512 full validator 5.8828 ms/op 6.8178 ms/op 0.86
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 78.446 us/op 87.613 us/op 0.90
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.1713 ms/op 1.2614 ms/op 0.93
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 15.526 ms/op 16.410 ms/op 0.95
BeaconState.hashTreeRoot - 1 balances 57.511 us/op 62.963 us/op 0.91
BeaconState.hashTreeRoot - 32 balances 630.65 us/op 616.21 us/op 1.02
BeaconState.hashTreeRoot - 512 balances 5.6940 ms/op 6.1055 ms/op 0.93
BeaconState.hashTreeRoot - 250000 balances 90.023 ms/op 100.51 ms/op 0.90
aggregationBits - 2048 els - zipIndexesInBitList 32.264 us/op 29.887 us/op 1.08
regular array get 100000 times 67.426 us/op 62.676 us/op 1.08
wrappedArray get 100000 times 67.408 us/op 61.447 us/op 1.10
arrayWithProxy get 100000 times 29.009 ms/op 32.163 ms/op 0.90
ssz.Root.equals 518.00 ns/op 468.00 ns/op 1.11
byteArrayEquals 517.00 ns/op 461.00 ns/op 1.12
shuffle list - 16384 els 11.060 ms/op 11.567 ms/op 0.96
shuffle list - 250000 els 166.04 ms/op 170.50 ms/op 0.97
processSlot - 1 slots 13.000 us/op 12.683 us/op 1.02
processSlot - 32 slots 1.7917 ms/op 1.9194 ms/op 0.93
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 371.38 us/op 379.45 us/op 0.98
getCommitteeAssignments - req 1 vs - 250000 vc 5.3346 ms/op 5.4527 ms/op 0.98
getCommitteeAssignments - req 100 vs - 250000 vc 7.3193 ms/op 7.9765 ms/op 0.92
getCommitteeAssignments - req 1000 vs - 250000 vc 7.7588 ms/op 8.6034 ms/op 0.90
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 9.8500 ns/op 7.8700 ns/op 1.25
state getBlockRootAtSlot - 250000 vs - 7PWei 1.1033 us/op 947.70 ns/op 1.16
computeProposers - vc 250000 17.306 ms/op 17.424 ms/op 0.99
computeEpochShuffling - vc 250000 169.66 ms/op 173.68 ms/op 0.98
getNextSyncCommittee - vc 250000 278.94 ms/op 284.46 ms/op 0.98

by benchmarkbot/action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nazarhussain @dapplion @g11tech