Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SHARDING_* fields from spec config #4572

Merged
merged 1 commit into from Sep 20, 2022

Conversation

dapplion
Copy link
Contributor

Motivation

Upstream spec no longer includes SHARDING_ fields. These are old legacy fields https://github.com/ethereum/consensus-specs/blob/dev/configs/mainnet.yaml

Description

  • Remove SHARDING_* fields from spec config

@dapplion dapplion requested a review from a team as a code owner September 20, 2022 11:06
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: b7c1548 Previous: 8709e3a Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.3718 ms/op 2.2726 ms/op 1.04
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 73.800 us/op 85.034 us/op 0.87
BLS verify - blst-native 1.8581 ms/op 1.8825 ms/op 0.99
BLS verifyMultipleSignatures 3 - blst-native 3.8044 ms/op 3.8568 ms/op 0.99
BLS verifyMultipleSignatures 8 - blst-native 8.1871 ms/op 8.3030 ms/op 0.99
BLS verifyMultipleSignatures 32 - blst-native 29.661 ms/op 30.109 ms/op 0.99
BLS aggregatePubkeys 32 - blst-native 39.179 us/op 39.878 us/op 0.98
BLS aggregatePubkeys 128 - blst-native 152.99 us/op 154.58 us/op 0.99
getAttestationsForBlock 90.433 ms/op 98.900 ms/op 0.91
isKnown best case - 1 super set check 471.00 ns/op 440.00 ns/op 1.07
isKnown normal case - 2 super set checks 456.00 ns/op 419.00 ns/op 1.09
isKnown worse case - 16 super set checks 457.00 ns/op 420.00 ns/op 1.09
CheckpointStateCache - add get delete 8.6060 us/op 9.4480 us/op 0.91
validate gossip signedAggregateAndProof - struct 4.2493 ms/op 4.3875 ms/op 0.97
validate gossip attestation - struct 2.0254 ms/op 2.0799 ms/op 0.97
pickEth1Vote - no votes 2.2501 ms/op 2.9606 ms/op 0.76
pickEth1Vote - max votes 20.002 ms/op 25.381 ms/op 0.79
pickEth1Vote - Eth1Data hashTreeRoot value x2048 11.442 ms/op 11.991 ms/op 0.95
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 21.191 ms/op 23.462 ms/op 0.90
pickEth1Vote - Eth1Data fastSerialize value x2048 1.5775 ms/op 1.6052 ms/op 0.98
pickEth1Vote - Eth1Data fastSerialize tree x2048 13.528 ms/op 16.664 ms/op 0.81
bytes32 toHexString 1.0560 us/op 1.2770 us/op 0.83
bytes32 Buffer.toString(hex) 721.00 ns/op 767.00 ns/op 0.94
bytes32 Buffer.toString(hex) from Uint8Array 960.00 ns/op 1.0340 us/op 0.93
bytes32 Buffer.toString(hex) + 0x 716.00 ns/op 789.00 ns/op 0.91
Object access 1 prop 0.37200 ns/op 0.42600 ns/op 0.87
Map access 1 prop 0.29400 ns/op 0.28900 ns/op 1.02
Object get x1000 17.904 ns/op 17.974 ns/op 1.00
Map get x1000 0.98700 ns/op 0.99200 ns/op 0.99
Object set x1000 121.16 ns/op 134.97 ns/op 0.90
Map set x1000 71.415 ns/op 84.185 ns/op 0.85
Return object 10000 times 0.37590 ns/op 0.37530 ns/op 1.00
Throw Error 10000 times 5.9322 us/op 5.9733 us/op 0.99
enrSubnets - fastDeserialize 64 bits 2.6860 us/op 3.2570 us/op 0.82
enrSubnets - ssz BitVector 64 bits 750.00 ns/op 834.00 ns/op 0.90
enrSubnets - fastDeserialize 4 bits 388.00 ns/op 431.00 ns/op 0.90
enrSubnets - ssz BitVector 4 bits 758.00 ns/op 858.00 ns/op 0.88
prioritizePeers score -10:0 att 32-0.1 sync 2-0 94.157 us/op 106.93 us/op 0.88
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 123.10 us/op 142.90 us/op 0.86
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 218.55 us/op 253.84 us/op 0.86
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 472.69 us/op 392.85 us/op 1.20
prioritizePeers score 0:0 att 64-1 sync 4-1 456.23 us/op 464.72 us/op 0.98
RateTracker 1000000 limit, 1 obj count per request 200.11 ns/op 214.54 ns/op 0.93
RateTracker 1000000 limit, 2 obj count per request 153.47 ns/op 167.47 ns/op 0.92
RateTracker 1000000 limit, 4 obj count per request 131.36 ns/op 146.13 ns/op 0.90
RateTracker 1000000 limit, 8 obj count per request 118.84 ns/op 132.82 ns/op 0.89
RateTracker with prune 4.2830 us/op 5.7180 us/op 0.75
array of 16000 items push then shift 3.1893 us/op 3.2262 us/op 0.99
LinkedList of 16000 items push then shift 17.477 ns/op 18.030 ns/op 0.97
array of 16000 items push then pop 250.17 ns/op 266.67 ns/op 0.94
LinkedList of 16000 items push then pop 16.529 ns/op 17.137 ns/op 0.96
array of 24000 items push then shift 4.5531 us/op 4.6542 us/op 0.98
LinkedList of 24000 items push then shift 20.780 ns/op 21.458 ns/op 0.97
array of 24000 items push then pop 205.43 ns/op 236.47 ns/op 0.87
LinkedList of 24000 items push then pop 18.250 ns/op 18.616 ns/op 0.98
intersect bitArray bitLen 8 11.756 ns/op 11.679 ns/op 1.01
intersect array and set length 8 166.87 ns/op 199.97 ns/op 0.83
intersect bitArray bitLen 128 62.047 ns/op 72.499 ns/op 0.86
intersect array and set length 128 2.2132 us/op 2.4437 us/op 0.91
Buffer.concat 32 items 1.8580 ns/op 1.9930 ns/op 0.93
pass gossip attestations to forkchoice per slot 3.5378 ms/op 3.6377 ms/op 0.97
computeDeltas 3.0609 ms/op 3.1617 ms/op 0.97
computeProposerBoostScoreFromBalances 908.35 us/op 914.51 us/op 0.99
altair processAttestation - 250000 vs - 7PWei normalcase 3.5562 ms/op 4.4580 ms/op 0.80
altair processAttestation - 250000 vs - 7PWei worstcase 5.9111 ms/op 6.7126 ms/op 0.88
altair processAttestation - setStatus - 1/6 committees join 216.25 us/op 228.91 us/op 0.94
altair processAttestation - setStatus - 1/3 committees join 410.65 us/op 425.20 us/op 0.97
altair processAttestation - setStatus - 1/2 committees join 578.32 us/op 594.43 us/op 0.97
altair processAttestation - setStatus - 2/3 committees join 737.96 us/op 801.28 us/op 0.92
altair processAttestation - setStatus - 4/5 committees join 1.0200 ms/op 1.0664 ms/op 0.96
altair processAttestation - setStatus - 100% committees join 1.2147 ms/op 1.2616 ms/op 0.96
altair processBlock - 250000 vs - 7PWei normalcase 26.603 ms/op 30.163 ms/op 0.88
altair processBlock - 250000 vs - 7PWei normalcase hashState 38.990 ms/op 37.941 ms/op 1.03
altair processBlock - 250000 vs - 7PWei worstcase 79.890 ms/op 93.205 ms/op 0.86
altair processBlock - 250000 vs - 7PWei worstcase hashState 98.699 ms/op 99.096 ms/op 1.00
phase0 processBlock - 250000 vs - 7PWei normalcase 3.2826 ms/op 4.2678 ms/op 0.77
phase0 processBlock - 250000 vs - 7PWei worstcase 45.720 ms/op 48.020 ms/op 0.95
altair processEth1Data - 250000 vs - 7PWei normalcase 739.72 us/op 1.0748 ms/op 0.69
Tree 40 250000 create 797.40 ms/op 1.1181 s/op 0.71
Tree 40 250000 get(125000) 287.38 ns/op 294.40 ns/op 0.98
Tree 40 250000 set(125000) 2.4045 us/op 3.5923 us/op 0.67
Tree 40 250000 toArray() 31.574 ms/op 33.267 ms/op 0.95
Tree 40 250000 iterate all - toArray() + loop 32.133 ms/op 32.901 ms/op 0.98
Tree 40 250000 iterate all - get(i) 109.23 ms/op 112.08 ms/op 0.97
MutableVector 250000 create 15.071 ms/op 16.934 ms/op 0.89
MutableVector 250000 get(125000) 13.117 ns/op 14.920 ns/op 0.88
MutableVector 250000 set(125000) 619.47 ns/op 907.45 ns/op 0.68
MutableVector 250000 toArray() 7.4779 ms/op 7.9888 ms/op 0.94
MutableVector 250000 iterate all - toArray() + loop 7.0612 ms/op 8.1623 ms/op 0.87
MutableVector 250000 iterate all - get(i) 3.2976 ms/op 3.4788 ms/op 0.95
Array 250000 create 6.2120 ms/op 7.3719 ms/op 0.84
Array 250000 clone - spread 2.7182 ms/op 5.7128 ms/op 0.48
Array 250000 get(125000) 1.1670 ns/op 1.7920 ns/op 0.65
Array 250000 set(125000) 1.1790 ns/op 1.7590 ns/op 0.67
Array 250000 iterate all - loop 167.88 us/op 170.56 us/op 0.98
effectiveBalanceIncrements clone Uint8Array 300000 73.900 us/op 93.430 us/op 0.79
effectiveBalanceIncrements clone MutableVector 300000 809.00 ns/op 1.3360 us/op 0.61
effectiveBalanceIncrements rw all Uint8Array 300000 252.46 us/op 254.72 us/op 0.99
effectiveBalanceIncrements rw all MutableVector 300000 163.07 ms/op 240.64 ms/op 0.68
phase0 afterProcessEpoch - 250000 vs - 7PWei 185.99 ms/op 202.99 ms/op 0.92
phase0 beforeProcessEpoch - 250000 vs - 7PWei 73.958 ms/op 77.585 ms/op 0.95
altair processEpoch - mainnet_e81889 506.69 ms/op 608.57 ms/op 0.83
mainnet_e81889 - altair beforeProcessEpoch 143.64 ms/op 150.38 ms/op 0.96
mainnet_e81889 - altair processJustificationAndFinalization 23.693 us/op 25.842 us/op 0.92
mainnet_e81889 - altair processInactivityUpdates 10.096 ms/op 10.876 ms/op 0.93
mainnet_e81889 - altair processRewardsAndPenalties 91.436 ms/op 97.267 ms/op 0.94
mainnet_e81889 - altair processRegistryUpdates 3.6640 us/op 4.5440 us/op 0.81
mainnet_e81889 - altair processSlashings 926.00 ns/op 1.0210 us/op 0.91
mainnet_e81889 - altair processEth1DataReset 899.00 ns/op 1.0870 us/op 0.83
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.4239 ms/op 2.3044 ms/op 1.05
mainnet_e81889 - altair processSlashingsReset 7.2870 us/op 7.0060 us/op 1.04
mainnet_e81889 - altair processRandaoMixesReset 5.5680 us/op 7.8360 us/op 0.71
mainnet_e81889 - altair processHistoricalRootsUpdate 862.00 ns/op 993.00 ns/op 0.87
mainnet_e81889 - altair processParticipationFlagUpdates 2.8740 us/op 4.2250 us/op 0.68
mainnet_e81889 - altair processSyncCommitteeUpdates 671.00 ns/op 861.00 ns/op 0.78
mainnet_e81889 - altair afterProcessEpoch 197.82 ms/op 200.51 ms/op 0.99
phase0 processEpoch - mainnet_e58758 530.79 ms/op 549.18 ms/op 0.97
mainnet_e58758 - phase0 beforeProcessEpoch 231.49 ms/op 247.21 ms/op 0.94
mainnet_e58758 - phase0 processJustificationAndFinalization 19.886 us/op 26.690 us/op 0.75
mainnet_e58758 - phase0 processRewardsAndPenalties 130.04 ms/op 146.34 ms/op 0.89
mainnet_e58758 - phase0 processRegistryUpdates 9.4990 us/op 12.111 us/op 0.78
mainnet_e58758 - phase0 processSlashings 810.00 ns/op 903.00 ns/op 0.90
mainnet_e58758 - phase0 processEth1DataReset 834.00 ns/op 952.00 ns/op 0.88
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.0884 ms/op 2.1789 ms/op 0.96
mainnet_e58758 - phase0 processSlashingsReset 4.5460 us/op 6.5810 us/op 0.69
mainnet_e58758 - phase0 processRandaoMixesReset 5.4960 us/op 7.6350 us/op 0.72
mainnet_e58758 - phase0 processHistoricalRootsUpdate 850.00 ns/op 1.0740 us/op 0.79
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.0530 us/op 6.5570 us/op 0.77
mainnet_e58758 - phase0 afterProcessEpoch 162.05 ms/op 162.71 ms/op 1.00
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.5471 ms/op 2.6840 ms/op 0.95
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.4888 ms/op 3.5223 ms/op 0.99
altair processInactivityUpdates - 250000 normalcase 41.687 ms/op 44.367 ms/op 0.94
altair processInactivityUpdates - 250000 worstcase 41.814 ms/op 54.059 ms/op 0.77
phase0 processRegistryUpdates - 250000 normalcase 8.6740 us/op 10.129 us/op 0.86
phase0 processRegistryUpdates - 250000 badcase_full_deposits 405.42 us/op 440.28 us/op 0.92
phase0 processRegistryUpdates - 250000 worstcase 0.5 208.92 ms/op 227.31 ms/op 0.92
altair processRewardsAndPenalties - 250000 normalcase 88.738 ms/op 136.34 ms/op 0.65
altair processRewardsAndPenalties - 250000 worstcase 133.23 ms/op 90.286 ms/op 1.48
phase0 getAttestationDeltas - 250000 normalcase 13.002 ms/op 16.316 ms/op 0.80
phase0 getAttestationDeltas - 250000 worstcase 13.218 ms/op 16.513 ms/op 0.80
phase0 processSlashings - 250000 worstcase 5.3449 ms/op 5.6272 ms/op 0.95
altair processSyncCommitteeUpdates - 250000 281.98 ms/op 300.73 ms/op 0.94
BeaconState.hashTreeRoot - No change 457.00 ns/op 480.00 ns/op 0.95
BeaconState.hashTreeRoot - 1 full validator 62.762 us/op 63.186 us/op 0.99
BeaconState.hashTreeRoot - 32 full validator 645.05 us/op 784.36 us/op 0.82
BeaconState.hashTreeRoot - 512 full validator 6.8720 ms/op 6.6026 ms/op 1.04
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 83.956 us/op 80.821 us/op 1.04
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.2038 ms/op 1.2353 ms/op 0.97
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 16.725 ms/op 17.137 ms/op 0.98
BeaconState.hashTreeRoot - 1 balances 72.584 us/op 53.144 us/op 1.37
BeaconState.hashTreeRoot - 32 balances 571.41 us/op 580.55 us/op 0.98
BeaconState.hashTreeRoot - 512 balances 5.8827 ms/op 6.3355 ms/op 0.93
BeaconState.hashTreeRoot - 250000 balances 91.046 ms/op 96.927 ms/op 0.94
aggregationBits - 2048 els - zipIndexesInBitList 33.406 us/op 43.217 us/op 0.77
regular array get 100000 times 67.414 us/op 68.193 us/op 0.99
wrappedArray get 100000 times 67.386 us/op 68.112 us/op 0.99
arrayWithProxy get 100000 times 31.320 ms/op 29.500 ms/op 1.06
ssz.Root.equals 507.00 ns/op 505.00 ns/op 1.00
byteArrayEquals 517.00 ns/op 490.00 ns/op 1.06
shuffle list - 16384 els 11.141 ms/op 11.193 ms/op 1.00
shuffle list - 250000 els 167.19 ms/op 169.36 ms/op 0.99
processSlot - 1 slots 13.019 us/op 13.208 us/op 0.99
processSlot - 32 slots 1.8841 ms/op 1.8552 ms/op 1.02
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 408.44 us/op 562.84 us/op 0.73
getCommitteeAssignments - req 1 vs - 250000 vc 5.3415 ms/op 5.5192 ms/op 0.97
getCommitteeAssignments - req 100 vs - 250000 vc 7.3261 ms/op 7.5594 ms/op 0.97
getCommitteeAssignments - req 1000 vs - 250000 vc 7.7694 ms/op 7.9836 ms/op 0.97
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 10.180 ns/op 10.230 ns/op 1.00
state getBlockRootAtSlot - 250000 vs - 7PWei 1.1889 us/op 1.4074 us/op 0.84
computeProposers - vc 250000 16.605 ms/op 18.051 ms/op 0.92
computeEpochShuffling - vc 250000 171.25 ms/op 173.49 ms/op 0.99
getNextSyncCommittee - vc 250000 276.09 ms/op 293.89 ms/op 0.94

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 34305f3 into unstable Sep 20, 2022
@wemeetagain wemeetagain deleted the dapplion/remove-sharding-fork branch September 20, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants