Use mix of local key manager and external signer for sim tests #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Base automatically changed from
nh/4276-assertions-participation-per-slot
to
unstable
September 23, 2022 07:40
Performance Report✔️ no performance regression detected Full benchmark results
|
g11tech
reviewed
Sep 23, 2022
| @@ -58,6 +58,9 @@ export const LodestarValidatorProcess: ValidatorConstructor = class LodestarVali | |||
| }); | |||
| this.secretKeys = validatorSecretKeys; | |||
|
|
|||
| // Split half of the keys to external signer | |||
| this.externalSigner = new ExternalSignerServer(this.secretKeys.slice(0, this.secretKeys.length / 2)); | |||
There was a problem hiding this comment.
can we define and set the ranges to be divided locally and externally as validables (and the default split as half/half)
There was a problem hiding this comment.
also this.rcConfig["externalSigner.url"] = this.externalSigner.url; isn't required for this using this external signer?
There was a problem hiding this comment.
also this.rcConfig["externalSigner.url"] = this.externalSigner.url; isn't required for this using this external signer?
oh ok since we now start keymanager to use this external signer
There was a problem hiding this comment.
@g11tech Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use mix of both local key manager and external signer for sim tests.
Resolves #4276