Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set lodestar version in agent version #4612

Merged
merged 1 commit into from Oct 5, 2022
Merged

Set lodestar version in agent version #4612

merged 1 commit into from Oct 5, 2022

Conversation

dapplion
Copy link
Contributor

Motivation

Most clients have already changed their agent string to lodestar

Description

  • Set lodestar version in agent version

Closes #4465

@dapplion dapplion requested a review from a team as a code owner September 29, 2022 15:41
g11tech
g11tech previously approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: f1d4885 Previous: 631b6e7 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.8921 ms/op 2.5178 ms/op 0.75
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 72.996 us/op 88.488 us/op 0.82
BLS verify - blst-native 1.8557 ms/op 2.7559 ms/op 0.67
BLS verifyMultipleSignatures 3 - blst-native 3.8039 ms/op 5.8292 ms/op 0.65
BLS verifyMultipleSignatures 8 - blst-native 8.1973 ms/op 12.634 ms/op 0.65
BLS verifyMultipleSignatures 32 - blst-native 29.778 ms/op 47.107 ms/op 0.63
BLS aggregatePubkeys 32 - blst-native 39.154 us/op 62.136 us/op 0.63
BLS aggregatePubkeys 128 - blst-native 153.08 us/op 242.02 us/op 0.63
getAttestationsForBlock 83.101 ms/op 120.39 ms/op 0.69
isKnown best case - 1 super set check 419.00 ns/op 527.00 ns/op 0.80
isKnown normal case - 2 super set checks 412.00 ns/op 510.00 ns/op 0.81
isKnown worse case - 16 super set checks 409.00 ns/op 510.00 ns/op 0.80
CheckpointStateCache - add get delete 8.7010 us/op 11.402 us/op 0.76
validate gossip signedAggregateAndProof - struct 4.2499 ms/op 6.4156 ms/op 0.66
validate gossip attestation - struct 2.0225 ms/op 3.1043 ms/op 0.65
pickEth1Vote - no votes 2.1671 ms/op 2.6895 ms/op 0.81
pickEth1Vote - max votes 19.315 ms/op 24.399 ms/op 0.79
pickEth1Vote - Eth1Data hashTreeRoot value x2048 10.912 ms/op 14.723 ms/op 0.74
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 19.390 ms/op 25.169 ms/op 0.77
pickEth1Vote - Eth1Data fastSerialize value x2048 1.4990 ms/op 1.8511 ms/op 0.81
pickEth1Vote - Eth1Data fastSerialize tree x2048 12.617 ms/op 15.722 ms/op 0.80
bytes32 toHexString 1.0240 us/op 1.3600 us/op 0.75
bytes32 Buffer.toString(hex) 718.00 ns/op 818.00 ns/op 0.88
bytes32 Buffer.toString(hex) from Uint8Array 941.00 ns/op 1.1120 us/op 0.85
bytes32 Buffer.toString(hex) + 0x 707.00 ns/op 850.00 ns/op 0.83
Object access 1 prop 0.34600 ns/op 0.46100 ns/op 0.75
Map access 1 prop 0.29100 ns/op 0.34500 ns/op 0.84
Object get x1000 18.427 ns/op 16.726 ns/op 1.10
Map get x1000 1.1160 ns/op 0.97300 ns/op 1.15
Object set x1000 117.81 ns/op 121.00 ns/op 0.97
Map set x1000 69.481 ns/op 83.230 ns/op 0.83
Return object 10000 times 0.37270 ns/op 0.42220 ns/op 0.88
Throw Error 10000 times 5.8192 us/op 8.2622 us/op 0.70
enrSubnets - fastDeserialize 64 bits 2.5450 us/op 3.2130 us/op 0.79
enrSubnets - ssz BitVector 64 bits 750.00 ns/op 882.00 ns/op 0.85
enrSubnets - fastDeserialize 4 bits 358.00 ns/op 506.00 ns/op 0.71
enrSubnets - ssz BitVector 4 bits 726.00 ns/op 914.00 ns/op 0.79
prioritizePeers score -10:0 att 32-0.1 sync 2-0 92.365 us/op 117.03 us/op 0.79
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 122.85 us/op 156.81 us/op 0.78
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 210.45 us/op 280.63 us/op 0.75
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 450.06 us/op 618.52 us/op 0.73
prioritizePeers score 0:0 att 64-1 sync 4-1 459.38 us/op 660.53 us/op 0.70
RateTracker 1000000 limit, 1 obj count per request 209.27 ns/op 223.97 ns/op 0.93
RateTracker 1000000 limit, 2 obj count per request 158.68 ns/op 167.83 ns/op 0.95
RateTracker 1000000 limit, 4 obj count per request 130.75 ns/op 138.81 ns/op 0.94
RateTracker 1000000 limit, 8 obj count per request 117.52 ns/op 122.47 ns/op 0.96
RateTracker with prune 4.2700 us/op 5.9220 us/op 0.72
array of 16000 items push then shift 3.0728 us/op 5.5657 us/op 0.55
LinkedList of 16000 items push then shift 17.347 ns/op 20.520 ns/op 0.85
array of 16000 items push then pop 233.39 ns/op 265.92 ns/op 0.88
LinkedList of 16000 items push then pop 16.490 ns/op 19.384 ns/op 0.85
array of 24000 items push then shift 4.5567 us/op 7.9826 us/op 0.57
LinkedList of 24000 items push then shift 20.194 ns/op 20.745 ns/op 0.97
array of 24000 items push then pop 199.03 ns/op 240.24 ns/op 0.83
LinkedList of 24000 items push then pop 17.746 ns/op 19.001 ns/op 0.93
intersect bitArray bitLen 8 11.491 ns/op 13.105 ns/op 0.88
intersect array and set length 8 162.93 ns/op 213.39 ns/op 0.76
intersect bitArray bitLen 128 72.094 ns/op 71.633 ns/op 1.01
intersect array and set length 128 2.2139 us/op 2.5736 us/op 0.86
Buffer.concat 32 items 1.8530 ns/op 2.2980 ns/op 0.81
pass gossip attestations to forkchoice per slot 6.4782 ms/op 5.0237 ms/op 1.29
computeDeltas 5.2849 ms/op 5.8283 ms/op 0.91
computeProposerBoostScoreFromBalances 907.88 us/op 906.21 us/op 1.00
altair processAttestation - 250000 vs - 7PWei normalcase 3.5891 ms/op 5.4242 ms/op 0.66
altair processAttestation - 250000 vs - 7PWei worstcase 5.5795 ms/op 7.7645 ms/op 0.72
altair processAttestation - setStatus - 1/6 committees join 209.62 us/op 254.87 us/op 0.82
altair processAttestation - setStatus - 1/3 committees join 401.67 us/op 467.44 us/op 0.86
altair processAttestation - setStatus - 1/2 committees join 556.80 us/op 670.30 us/op 0.83
altair processAttestation - setStatus - 2/3 committees join 716.32 us/op 874.48 us/op 0.82
altair processAttestation - setStatus - 4/5 committees join 986.14 us/op 1.2395 ms/op 0.80
altair processAttestation - setStatus - 100% committees join 1.1692 ms/op 1.5947 ms/op 0.73
altair processBlock - 250000 vs - 7PWei normalcase 27.432 ms/op 30.270 ms/op 0.91
altair processBlock - 250000 vs - 7PWei normalcase hashState 40.808 ms/op 44.464 ms/op 0.92
altair processBlock - 250000 vs - 7PWei worstcase 80.595 ms/op 115.71 ms/op 0.70
altair processBlock - 250000 vs - 7PWei worstcase hashState 109.38 ms/op 129.83 ms/op 0.84
phase0 processBlock - 250000 vs - 7PWei normalcase 3.3701 ms/op 4.5454 ms/op 0.74
phase0 processBlock - 250000 vs - 7PWei worstcase 45.703 ms/op 64.822 ms/op 0.71
altair processEth1Data - 250000 vs - 7PWei normalcase 791.16 us/op 1.1481 ms/op 0.69
Tree 40 250000 create 770.18 ms/op 1.1148 s/op 0.69
Tree 40 250000 get(125000) 284.36 ns/op 339.30 ns/op 0.84
Tree 40 250000 set(125000) 2.3386 us/op 3.7037 us/op 0.63
Tree 40 250000 toArray() 31.471 ms/op 36.401 ms/op 0.86
Tree 40 250000 iterate all - toArray() + loop 31.770 ms/op 38.208 ms/op 0.83
Tree 40 250000 iterate all - get(i) 111.83 ms/op 139.07 ms/op 0.80
MutableVector 250000 create 14.436 ms/op 18.449 ms/op 0.78
MutableVector 250000 get(125000) 14.933 ns/op 14.793 ns/op 1.01
MutableVector 250000 set(125000) 579.35 ns/op 1.0093 us/op 0.57
MutableVector 250000 toArray() 7.1171 ms/op 9.1026 ms/op 0.78
MutableVector 250000 iterate all - toArray() + loop 7.3934 ms/op 7.6148 ms/op 0.97
MutableVector 250000 iterate all - get(i) 3.4721 ms/op 3.5671 ms/op 0.97
Array 250000 create 6.5099 ms/op 7.1128 ms/op 0.92
Array 250000 clone - spread 3.5030 ms/op 3.2954 ms/op 1.06
Array 250000 get(125000) 1.4820 ns/op 1.4700 ns/op 1.01
Array 250000 set(125000) 1.4590 ns/op 1.5060 ns/op 0.97
Array 250000 iterate all - loop 170.54 us/op 146.63 us/op 1.16
effectiveBalanceIncrements clone Uint8Array 300000 82.020 us/op 105.21 us/op 0.78
effectiveBalanceIncrements clone MutableVector 300000 603.00 ns/op 1.0370 us/op 0.58
effectiveBalanceIncrements rw all Uint8Array 300000 252.31 us/op 310.03 us/op 0.81
effectiveBalanceIncrements rw all MutableVector 300000 155.47 ms/op 245.94 ms/op 0.63
phase0 afterProcessEpoch - 250000 vs - 7PWei 198.57 ms/op 198.76 ms/op 1.00
phase0 beforeProcessEpoch - 250000 vs - 7PWei 70.651 ms/op 78.604 ms/op 0.90
altair processEpoch - mainnet_e81889 573.40 ms/op 677.31 ms/op 0.85
mainnet_e81889 - altair beforeProcessEpoch 151.35 ms/op 191.62 ms/op 0.79
mainnet_e81889 - altair processJustificationAndFinalization 22.782 us/op 66.006 us/op 0.35
mainnet_e81889 - altair processInactivityUpdates 10.579 ms/op 13.444 ms/op 0.79
mainnet_e81889 - altair processRewardsAndPenalties 88.921 ms/op 107.34 ms/op 0.83
mainnet_e81889 - altair processRegistryUpdates 4.4910 us/op 16.249 us/op 0.28
mainnet_e81889 - altair processSlashings 989.00 ns/op 3.8470 us/op 0.26
mainnet_e81889 - altair processEth1DataReset 817.00 ns/op 4.1370 us/op 0.20
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.4210 ms/op 2.7409 ms/op 0.88
mainnet_e81889 - altair processSlashingsReset 6.1330 us/op 20.596 us/op 0.30
mainnet_e81889 - altair processRandaoMixesReset 6.0120 us/op 24.157 us/op 0.25
mainnet_e81889 - altair processHistoricalRootsUpdate 813.00 ns/op 4.3450 us/op 0.19
mainnet_e81889 - altair processParticipationFlagUpdates 3.3850 us/op 13.834 us/op 0.24
mainnet_e81889 - altair processSyncCommitteeUpdates 841.00 ns/op 3.2440 us/op 0.26
mainnet_e81889 - altair afterProcessEpoch 195.28 ms/op 214.42 ms/op 0.91
phase0 processEpoch - mainnet_e58758 513.06 ms/op 655.95 ms/op 0.78
mainnet_e58758 - phase0 beforeProcessEpoch 218.67 ms/op 323.02 ms/op 0.68
mainnet_e58758 - phase0 processJustificationAndFinalization 21.593 us/op 56.508 us/op 0.38
mainnet_e58758 - phase0 processRewardsAndPenalties 103.68 ms/op 90.012 ms/op 1.15
mainnet_e58758 - phase0 processRegistryUpdates 10.465 us/op 32.621 us/op 0.32
mainnet_e58758 - phase0 processSlashings 828.00 ns/op 3.5380 us/op 0.23
mainnet_e58758 - phase0 processEth1DataReset 900.00 ns/op 3.8230 us/op 0.24
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.8526 ms/op 2.1674 ms/op 0.85
mainnet_e58758 - phase0 processSlashingsReset 4.8600 us/op 16.933 us/op 0.29
mainnet_e58758 - phase0 processRandaoMixesReset 6.1510 us/op 24.873 us/op 0.25
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.0300 us/op 4.0910 us/op 0.25
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.0630 us/op 23.440 us/op 0.22
mainnet_e58758 - phase0 afterProcessEpoch 160.51 ms/op 178.63 ms/op 0.90
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.5399 ms/op 2.5436 ms/op 1.00
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.4884 ms/op 2.8807 ms/op 1.21
altair processInactivityUpdates - 250000 normalcase 40.368 ms/op 58.913 ms/op 0.69
altair processInactivityUpdates - 250000 worstcase 49.770 ms/op 52.648 ms/op 0.95
phase0 processRegistryUpdates - 250000 normalcase 7.6120 us/op 29.230 us/op 0.26
phase0 processRegistryUpdates - 250000 badcase_full_deposits 420.17 us/op 534.14 us/op 0.79
phase0 processRegistryUpdates - 250000 worstcase 0.5 214.86 ms/op 306.05 ms/op 0.70
altair processRewardsAndPenalties - 250000 normalcase 125.53 ms/op 150.68 ms/op 0.83
altair processRewardsAndPenalties - 250000 worstcase 83.919 ms/op 103.75 ms/op 0.81
phase0 getAttestationDeltas - 250000 normalcase 13.374 ms/op 14.988 ms/op 0.89
phase0 getAttestationDeltas - 250000 worstcase 13.705 ms/op 15.204 ms/op 0.90
phase0 processSlashings - 250000 worstcase 5.3741 ms/op 6.7230 ms/op 0.80
altair processSyncCommitteeUpdates - 250000 277.23 ms/op 356.24 ms/op 0.78
BeaconState.hashTreeRoot - No change 499.00 ns/op 755.00 ns/op 0.66
BeaconState.hashTreeRoot - 1 full validator 62.317 us/op 78.774 us/op 0.79
BeaconState.hashTreeRoot - 32 full validator 696.20 us/op 765.19 us/op 0.91
BeaconState.hashTreeRoot - 512 full validator 5.9337 ms/op 8.0122 ms/op 0.74
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 75.824 us/op 101.01 us/op 0.75
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.1552 ms/op 1.4244 ms/op 0.81
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 15.687 ms/op 18.623 ms/op 0.84
BeaconState.hashTreeRoot - 1 balances 58.521 us/op 73.398 us/op 0.80
BeaconState.hashTreeRoot - 32 balances 651.41 us/op 681.55 us/op 0.96
BeaconState.hashTreeRoot - 512 balances 5.6241 ms/op 6.1572 ms/op 0.91
BeaconState.hashTreeRoot - 250000 balances 94.200 ms/op 117.75 ms/op 0.80
aggregationBits - 2048 els - zipIndexesInBitList 28.088 us/op 40.901 us/op 0.69
regular array get 100000 times 67.421 us/op 60.941 us/op 1.11
wrappedArray get 100000 times 67.528 us/op 59.127 us/op 1.14
arrayWithProxy get 100000 times 28.995 ms/op 36.872 ms/op 0.79
ssz.Root.equals 457.00 ns/op 604.00 ns/op 0.76
byteArrayEquals 457.00 ns/op 603.00 ns/op 0.76
shuffle list - 16384 els 11.202 ms/op 12.578 ms/op 0.89
shuffle list - 250000 els 164.86 ms/op 178.11 ms/op 0.93
processSlot - 1 slots 11.860 us/op 18.611 us/op 0.64
processSlot - 32 slots 1.6986 ms/op 2.4800 ms/op 0.68
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 400.05 us/op 567.30 us/op 0.71
getCommitteeAssignments - req 1 vs - 250000 vc 5.3504 ms/op 5.5623 ms/op 0.96
getCommitteeAssignments - req 100 vs - 250000 vc 7.3309 ms/op 8.2358 ms/op 0.89
getCommitteeAssignments - req 1000 vs - 250000 vc 7.7777 ms/op 8.5726 ms/op 0.91
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 10.540 ns/op 11.440 ns/op 0.92
state getBlockRootAtSlot - 250000 vs - 7PWei 1.0685 us/op 1.4364 us/op 0.74
computeProposers - vc 250000 16.146 ms/op 21.070 ms/op 0.77
computeEpochShuffling - vc 250000 168.98 ms/op 186.96 ms/op 0.90
getNextSyncCommittee - vc 250000 272.12 ms/op 349.06 ms/op 0.78

by benchmarkbot/action

@dapplion dapplion merged commit 9a963b4 into unstable Oct 5, 2022
@dapplion dapplion deleted the dapplion/agentversion branch October 5, 2022 08:56
@dapplion dapplion mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoeths twoeths twoeths approved these changes

@g11tech g11tech g11tech left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify agent version for lodestar
3 participants
@dapplion @twoeths @g11tech