Tag relevant peer #4997
Merged
Tag relevant peer #4997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
|
I think this duplicates the work of ChainSafe/js-libp2p-gossipsub#380 the plan outlined here is to have the option to configure priority peers to prevent the connection manager pruning connections to high-value peers. in the interim we could just leave maxConnections and https://github.com/ChainSafe/lodestar/blob/unstable/packages/beacon-node/src/network/nodejs/util.ts#L73 as the default (both |
|
@maschad @tuyennhv Was thinking about this recently, I think we can do both this PR and ChainSafe/js-libp2p-gossipsub#380 While they both tag peers, I think each has its own merit. Tagging mesh peers in gossipsub is helpful for any users of gossipsub to avoid disconnecting these important peers. If both of these PRs were implemented, if libp2p peer manager were to disconnect a peer, hopefully both tags would work together to give better behavior:
|
|
@wemeetagain good point, I suppose as long as there isn't the prospect of a performance penalty as suggested here then I agree that having both tags would serve as a safeguard against this type of disconnection. |
|
thanks @wemeetagain @maschad for your feeback @dapplion also suggested to use we can also do both and add |
|
#5001 was merged which set
|
twoeths
force-pushed
the
tuyen/tag_relevant_peer_2
branch
from
f8ac6ea
to
a29edf4
Compare
wemeetagain
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
maxConnectionsoption in libp2p's connection managerfound it from #4623
Test result