Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update year on the chainsafe cli notice #5466

Merged
merged 1 commit into from May 5, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented May 5, 2023

Motivation

It's 2023 already

Description

Update year on the chainsafe cli notice

@nflaig nflaig requested a review from a team as a code owner May 5, 2023 08:45
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: db9d932 Previous: 227d436 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 786.89 us/op 878.15 us/op 0.90
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 44.344 us/op 45.268 us/op 0.98
BLS verify - blst-native 1.1688 ms/op 1.2144 ms/op 0.96
BLS verifyMultipleSignatures 3 - blst-native 2.3798 ms/op 2.4636 ms/op 0.97
BLS verifyMultipleSignatures 8 - blst-native 5.0968 ms/op 5.2924 ms/op 0.96
BLS verifyMultipleSignatures 32 - blst-native 18.411 ms/op 19.131 ms/op 0.96
BLS aggregatePubkeys 32 - blst-native 24.769 us/op 24.492 us/op 1.01
BLS aggregatePubkeys 128 - blst-native 96.484 us/op 94.313 us/op 1.02
getAttestationsForBlock 52.816 ms/op 53.002 ms/op 1.00
isKnown best case - 1 super set check 250.00 ns/op 250.00 ns/op 1.00
isKnown normal case - 2 super set checks 244.00 ns/op 240.00 ns/op 1.02
isKnown worse case - 16 super set checks 247.00 ns/op 239.00 ns/op 1.03
CheckpointStateCache - add get delete 4.8310 us/op 4.8490 us/op 1.00
validate gossip signedAggregateAndProof - struct 2.7119 ms/op 2.7395 ms/op 0.99
validate gossip attestation - struct 1.2788 ms/op 1.3082 ms/op 0.98
pickEth1Vote - no votes 1.2086 ms/op 1.2336 ms/op 0.98
pickEth1Vote - max votes 9.9738 ms/op 11.519 ms/op 0.87
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.7349 ms/op 8.9535 ms/op 0.98
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.526 ms/op 14.296 ms/op 1.02
pickEth1Vote - Eth1Data fastSerialize value x2048 626.79 us/op 603.80 us/op 1.04
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.8797 ms/op 7.4327 ms/op 1.06
bytes32 toHexString 481.00 ns/op 452.00 ns/op 1.06
bytes32 Buffer.toString(hex) 351.00 ns/op 322.00 ns/op 1.09
bytes32 Buffer.toString(hex) from Uint8Array 562.00 ns/op 527.00 ns/op 1.07
bytes32 Buffer.toString(hex) + 0x 351.00 ns/op 323.00 ns/op 1.09
Object access 1 prop 0.16400 ns/op 0.15400 ns/op 1.06
Map access 1 prop 0.16600 ns/op 0.15100 ns/op 1.10
Object get x1000 6.3610 ns/op 6.3660 ns/op 1.00
Map get x1000 0.60200 ns/op 0.59100 ns/op 1.02
Object set x1000 50.525 ns/op 50.626 ns/op 1.00
Map set x1000 43.121 ns/op 43.823 ns/op 0.98
Return object 10000 times 0.23060 ns/op 0.23230 ns/op 0.99
Throw Error 10000 times 4.1091 us/op 4.1707 us/op 0.99
fastMsgIdFn sha256 / 200 bytes 3.4230 us/op 3.4390 us/op 1.00
fastMsgIdFn h32 xxhash / 200 bytes 282.00 ns/op 272.00 ns/op 1.04
fastMsgIdFn h64 xxhash / 200 bytes 386.00 ns/op 381.00 ns/op 1.01
fastMsgIdFn sha256 / 1000 bytes 11.310 us/op 11.446 us/op 0.99
fastMsgIdFn h32 xxhash / 1000 bytes 407.00 ns/op 398.00 ns/op 1.02
fastMsgIdFn h64 xxhash / 1000 bytes 456.00 ns/op 452.00 ns/op 1.01
fastMsgIdFn sha256 / 10000 bytes 101.94 us/op 102.68 us/op 0.99
fastMsgIdFn h32 xxhash / 10000 bytes 1.8580 us/op 1.8700 us/op 0.99
fastMsgIdFn h64 xxhash / 10000 bytes 1.3110 us/op 1.3270 us/op 0.99
enrSubnets - fastDeserialize 64 bits 1.2510 us/op 1.2810 us/op 0.98
enrSubnets - ssz BitVector 64 bits 472.00 ns/op 485.00 ns/op 0.97
enrSubnets - fastDeserialize 4 bits 167.00 ns/op 165.00 ns/op 1.01
enrSubnets - ssz BitVector 4 bits 481.00 ns/op 482.00 ns/op 1.00
prioritizePeers score -10:0 att 32-0.1 sync 2-0 102.63 us/op 104.01 us/op 0.99
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 129.66 us/op 130.07 us/op 1.00
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 162.56 us/op 166.28 us/op 0.98
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 294.15 us/op 301.20 us/op 0.98
prioritizePeers score 0:0 att 64-1 sync 4-1 354.83 us/op 359.17 us/op 0.99
array of 16000 items push then shift 1.6355 us/op 1.6009 us/op 1.02
LinkedList of 16000 items push then shift 8.6910 ns/op 8.7260 ns/op 1.00
array of 16000 items push then pop 116.02 ns/op 81.616 ns/op 1.42
LinkedList of 16000 items push then pop 9.0250 ns/op 8.4500 ns/op 1.07
array of 24000 items push then shift 2.4601 us/op 2.3305 us/op 1.06
LinkedList of 24000 items push then shift 8.9580 ns/op 8.4310 ns/op 1.06
array of 24000 items push then pop 82.848 ns/op 72.644 ns/op 1.14
LinkedList of 24000 items push then pop 8.6630 ns/op 8.1910 ns/op 1.06
intersect bitArray bitLen 8 13.232 ns/op 12.873 ns/op 1.03
intersect array and set length 8 78.963 ns/op 75.333 ns/op 1.05
intersect bitArray bitLen 128 43.246 ns/op 42.664 ns/op 1.01
intersect array and set length 128 1.0554 us/op 1.0190 us/op 1.04
Buffer.concat 32 items 2.9100 us/op 2.9310 us/op 0.99
Uint8Array.set 32 items 2.9450 us/op 2.8710 us/op 1.03
pass gossip attestations to forkchoice per slot 3.1629 ms/op 2.6354 ms/op 1.20
computeDeltas 3.1465 ms/op 2.9526 ms/op 1.07
computeProposerBoostScoreFromBalances 1.8100 ms/op 2.6528 ms/op 0.68
altair processAttestation - 250000 vs - 7PWei normalcase 3.0069 ms/op 2.1890 ms/op 1.37
altair processAttestation - 250000 vs - 7PWei worstcase 3.8814 ms/op 3.2787 ms/op 1.18
altair processAttestation - setStatus - 1/6 committees join 153.45 us/op 142.85 us/op 1.07
altair processAttestation - setStatus - 1/3 committees join 287.78 us/op 283.04 us/op 1.02
altair processAttestation - setStatus - 1/2 committees join 400.48 us/op 377.94 us/op 1.06
altair processAttestation - setStatus - 2/3 committees join 489.44 us/op 469.11 us/op 1.04
altair processAttestation - setStatus - 4/5 committees join 662.84 us/op 657.35 us/op 1.01
altair processAttestation - setStatus - 100% committees join 805.62 us/op 763.21 us/op 1.06
altair processBlock - 250000 vs - 7PWei normalcase 17.886 ms/op 14.582 ms/op 1.23
altair processBlock - 250000 vs - 7PWei normalcase hashState 27.860 ms/op 24.095 ms/op 1.16
altair processBlock - 250000 vs - 7PWei worstcase 49.276 ms/op 47.167 ms/op 1.04
altair processBlock - 250000 vs - 7PWei worstcase hashState 70.145 ms/op 72.452 ms/op 0.97
phase0 processBlock - 250000 vs - 7PWei normalcase 2.1751 ms/op 2.0401 ms/op 1.07
phase0 processBlock - 250000 vs - 7PWei worstcase 30.108 ms/op 28.309 ms/op 1.06
altair processEth1Data - 250000 vs - 7PWei normalcase 481.95 us/op 461.37 us/op 1.04
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 9.0670 us/op 8.9330 us/op 1.02
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 23.270 us/op 28.684 us/op 0.81
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 9.0420 us/op 11.205 us/op 0.81
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 6.2410 us/op 8.7870 us/op 0.71
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 86.238 us/op 112.14 us/op 0.77
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 634.68 us/op 646.28 us/op 0.98
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 878.65 us/op 917.75 us/op 0.96
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 871.43 us/op 884.33 us/op 0.99
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.2970 ms/op 2.4261 ms/op 0.95
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.4759 ms/op 1.5803 ms/op 0.93
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 3.9344 ms/op 4.0559 ms/op 0.97
Tree 40 250000 create 294.81 ms/op 377.46 ms/op 0.78
Tree 40 250000 get(125000) 181.36 ns/op 198.62 ns/op 0.91
Tree 40 250000 set(125000) 910.00 ns/op 1.1550 us/op 0.79
Tree 40 250000 toArray() 19.271 ms/op 22.427 ms/op 0.86
Tree 40 250000 iterate all - toArray() + loop 17.806 ms/op 23.151 ms/op 0.77
Tree 40 250000 iterate all - get(i) 68.542 ms/op 77.494 ms/op 0.88
MutableVector 250000 create 10.982 ms/op 11.074 ms/op 0.99
MutableVector 250000 get(125000) 6.5540 ns/op 6.5630 ns/op 1.00
MutableVector 250000 set(125000) 246.60 ns/op 267.24 ns/op 0.92
MutableVector 250000 toArray() 2.8033 ms/op 3.5639 ms/op 0.79
MutableVector 250000 iterate all - toArray() + loop 2.8662 ms/op 3.5847 ms/op 0.80
MutableVector 250000 iterate all - get(i) 1.5215 ms/op 1.5710 ms/op 0.97
Array 250000 create 3.1981 ms/op 3.0927 ms/op 1.03
Array 250000 clone - spread 1.1752 ms/op 1.1989 ms/op 0.98
Array 250000 get(125000) 0.61000 ns/op 0.59000 ns/op 1.03
Array 250000 set(125000) 0.68200 ns/op 0.67400 ns/op 1.01
Array 250000 iterate all - loop 88.445 us/op 83.932 us/op 1.05
effectiveBalanceIncrements clone Uint8Array 300000 42.229 us/op 42.970 us/op 0.98
effectiveBalanceIncrements clone MutableVector 300000 368.00 ns/op 373.00 ns/op 0.99
effectiveBalanceIncrements rw all Uint8Array 300000 173.69 us/op 172.71 us/op 1.01
effectiveBalanceIncrements rw all MutableVector 300000 90.336 ms/op 87.002 ms/op 1.04
phase0 afterProcessEpoch - 250000 vs - 7PWei 117.95 ms/op 116.70 ms/op 1.01
phase0 beforeProcessEpoch - 250000 vs - 7PWei 50.095 ms/op 45.453 ms/op 1.10
altair processEpoch - mainnet_e81889 319.23 ms/op 336.50 ms/op 0.95
mainnet_e81889 - altair beforeProcessEpoch 53.155 ms/op 53.048 ms/op 1.00
mainnet_e81889 - altair processJustificationAndFinalization 18.406 us/op 17.008 us/op 1.08
mainnet_e81889 - altair processInactivityUpdates 5.5165 ms/op 6.7102 ms/op 0.82
mainnet_e81889 - altair processRewardsAndPenalties 66.781 ms/op 70.675 ms/op 0.94
mainnet_e81889 - altair processRegistryUpdates 3.1040 us/op 2.6900 us/op 1.15
mainnet_e81889 - altair processSlashings 516.00 ns/op 480.00 ns/op 1.07
mainnet_e81889 - altair processEth1DataReset 622.00 ns/op 567.00 ns/op 1.10
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2390 ms/op 1.2732 ms/op 0.97
mainnet_e81889 - altair processSlashingsReset 3.9530 us/op 4.5650 us/op 0.87
mainnet_e81889 - altair processRandaoMixesReset 4.6420 us/op 4.6800 us/op 0.99
mainnet_e81889 - altair processHistoricalRootsUpdate 945.00 ns/op 716.00 ns/op 1.32
mainnet_e81889 - altair processParticipationFlagUpdates 3.1590 us/op 2.6270 us/op 1.20
mainnet_e81889 - altair processSyncCommitteeUpdates 480.00 ns/op 522.00 ns/op 0.92
mainnet_e81889 - altair afterProcessEpoch 127.31 ms/op 122.21 ms/op 1.04
phase0 processEpoch - mainnet_e58758 355.05 ms/op 333.09 ms/op 1.07
mainnet_e58758 - phase0 beforeProcessEpoch 140.20 ms/op 122.55 ms/op 1.14
mainnet_e58758 - phase0 processJustificationAndFinalization 18.172 us/op 17.207 us/op 1.06
mainnet_e58758 - phase0 processRewardsAndPenalties 67.037 ms/op 54.827 ms/op 1.22
mainnet_e58758 - phase0 processRegistryUpdates 12.359 us/op 9.0970 us/op 1.36
mainnet_e58758 - phase0 processSlashings 800.00 ns/op 583.00 ns/op 1.37
mainnet_e58758 - phase0 processEth1DataReset 1.2410 us/op 610.00 ns/op 2.03
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1048 ms/op 1.0189 ms/op 1.08
mainnet_e58758 - phase0 processSlashingsReset 5.6710 us/op 3.2770 us/op 1.73
mainnet_e58758 - phase0 processRandaoMixesReset 7.4500 us/op 6.2850 us/op 1.19
mainnet_e58758 - phase0 processHistoricalRootsUpdate 919.00 ns/op 976.00 ns/op 0.94
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.2460 us/op 5.0060 us/op 1.05
mainnet_e58758 - phase0 afterProcessEpoch 111.43 ms/op 96.477 ms/op 1.15
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2809 ms/op 1.2741 ms/op 1.01
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.7802 ms/op 1.4684 ms/op 1.21
altair processInactivityUpdates - 250000 normalcase 22.322 ms/op 24.827 ms/op 0.90
altair processInactivityUpdates - 250000 worstcase 27.246 ms/op 26.967 ms/op 1.01
phase0 processRegistryUpdates - 250000 normalcase 10.257 us/op 7.9970 us/op 1.28
phase0 processRegistryUpdates - 250000 badcase_full_deposits 309.93 us/op 271.95 us/op 1.14
phase0 processRegistryUpdates - 250000 worstcase 0.5 140.95 ms/op 132.93 ms/op 1.06
altair processRewardsAndPenalties - 250000 normalcase 73.354 ms/op 68.710 ms/op 1.07
altair processRewardsAndPenalties - 250000 worstcase 82.990 ms/op 72.151 ms/op 1.15
phase0 getAttestationDeltas - 250000 normalcase 8.8252 ms/op 7.2847 ms/op 1.21
phase0 getAttestationDeltas - 250000 worstcase 9.6016 ms/op 7.5165 ms/op 1.28
phase0 processSlashings - 250000 worstcase 4.4435 ms/op 3.4687 ms/op 1.28
altair processSyncCommitteeUpdates - 250000 213.17 ms/op 187.98 ms/op 1.13
BeaconState.hashTreeRoot - No change 390.00 ns/op 316.00 ns/op 1.23
BeaconState.hashTreeRoot - 1 full validator 58.560 us/op 54.363 us/op 1.08
BeaconState.hashTreeRoot - 32 full validator 528.07 us/op 489.89 us/op 1.08
BeaconState.hashTreeRoot - 512 full validator 7.3275 ms/op 6.0331 ms/op 1.21
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 75.019 us/op 65.443 us/op 1.15
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.0180 ms/op 916.54 us/op 1.11
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 15.635 ms/op 12.183 ms/op 1.28
BeaconState.hashTreeRoot - 1 balances 54.937 us/op 52.602 us/op 1.04
BeaconState.hashTreeRoot - 32 balances 539.84 us/op 479.41 us/op 1.13
BeaconState.hashTreeRoot - 512 balances 5.3668 ms/op 4.6295 ms/op 1.16
BeaconState.hashTreeRoot - 250000 balances 89.415 ms/op 78.326 ms/op 1.14
aggregationBits - 2048 els - zipIndexesInBitList 27.002 us/op 16.834 us/op 1.60
regular array get 100000 times 35.904 us/op 43.961 us/op 0.82
wrappedArray get 100000 times 35.944 us/op 33.672 us/op 1.07
arrayWithProxy get 100000 times 17.447 ms/op 16.241 ms/op 1.07
ssz.Root.equals 662.00 ns/op 563.00 ns/op 1.18
byteArrayEquals 611.00 ns/op 553.00 ns/op 1.10
shuffle list - 16384 els 7.6739 ms/op 6.9508 ms/op 1.10
shuffle list - 250000 els 111.92 ms/op 102.60 ms/op 1.09
processSlot - 1 slots 10.347 us/op 9.4420 us/op 1.10
processSlot - 32 slots 1.4824 ms/op 1.4157 ms/op 1.05
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 40.216 ms/op 35.493 ms/op 1.13
getCommitteeAssignments - req 1 vs - 250000 vc 3.3092 ms/op 2.9857 ms/op 1.11
getCommitteeAssignments - req 100 vs - 250000 vc 4.3262 ms/op 4.2019 ms/op 1.03
getCommitteeAssignments - req 1000 vs - 250000 vc 5.1538 ms/op 4.5543 ms/op 1.13
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.5000 ns/op 4.6300 ns/op 1.19
state getBlockRootAtSlot - 250000 vs - 7PWei 962.88 ns/op 896.60 ns/op 1.07
computeProposers - vc 250000 12.328 ms/op 10.477 ms/op 1.18
computeEpochShuffling - vc 250000 113.08 ms/op 105.39 ms/op 1.07
getNextSyncCommittee - vc 250000 195.84 ms/op 173.24 ms/op 1.13
computeSigningRoot for AttestationData 15.385 us/op 13.531 us/op 1.14
hash AttestationData serialized data then Buffer.toString(base64) 2.5654 us/op 2.4610 us/op 1.04
toHexString serialized data 1.3666 us/op 1.0941 us/op 1.25
Buffer.toString(base64) 363.69 ns/op 312.53 ns/op 1.16

by benchmarkbot/action

Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great attention to details!

@wemeetagain wemeetagain merged commit cd7709b into unstable May 5, 2023
11 checks passed
@wemeetagain wemeetagain deleted the nflaig/update-cli-year branch May 5, 2023 15:47
@dapplion
Copy link
Contributor

dapplion commented May 8, 2023

Why there has to be a year there BTW?

@philknows
Copy link
Member

Why there has to be a year there BTW?

Not sure TBH... is this a requirement that was put in there from sometime back in the early days @wemeetagain ? Would prefer for it to be automated, but not a huge deal.

@nflaig
Copy link
Member Author

nflaig commented May 9, 2023

if we want to keep the year could also just do 2018-${new Date().getFullYear()}

@wemeetagain
Copy link
Member

Good idea!

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants