fix: modify minimal preset's field elements per blob to mainnet for dev runs #5484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value for dev runs
g11tech
changed the title
g11tech
changed the title
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
suggested changes
May 12, 2023
| @@ -44,6 +47,9 @@ else if (network) { | |||
| else if (process.argv[2] === "dev") { | |||
| process.env.LODESTAR_PRESET = "minimal"; | |||
| process.env.LODESTAR_NETWORK = "dev"; | |||
| // "c-kzg" has hardcoded the mainnet value, do not use presets | |||
| // eslint-disable-next-line @typescript-eslint/naming-convention | |||
| setActivePreset(PresetName.minimal, {FIELD_ELEMENTS_PER_BLOB: 4096}); | |||
There was a problem hiding this comment.
Adding this in the production code path just for a local test of us is pretty ugly. Please use presetFile functionality in that test to override the values on the test runtime only.
There was a problem hiding this comment.
this for running lodestar via --dev network flag on cli (mostly via prebuild/docker images), test override is a different file
There was a problem hiding this comment.
Could you detail more who / where this is necessary? Is someone else dependant on this fix?
There was a problem hiding this comment.
generally its used in ethereumjs sims for 4844 (https://github.com/ethereumjs/ethereumjs-monorepo/blob/master/packages/client/test/sim/4844.md) , also we would want our --dev network to be 4844 compatible with EL clients
dapplion
approved these changes
May 16, 2023
|
🎉 This PR is included in v1.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of by parts integration of free the blobs PR
For devnets started using cli in minimal and for the merge interop/inline tests, the
FIELD_ELEMENTS_PER_BLOBneeds to be set to4096which is the mainnet valuebecause all kzg libraries and ELs process the blobs on this size and is a hardcoded value in them. We only need minimal value for spec tests which does not use the cli path or will not be providing DEV_RUN flag on test setup