Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix dashboard job name variables #5579

Merged
merged 1 commit into from May 30, 2023
Merged

chore: fix dashboard job name variables #5579

merged 1 commit into from May 30, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented May 30, 2023

Motivation

Job name variables are broken for some dashboards.

Description

  • Remove job name variables on dashboards that do not use them
  • Correctly set default values
  • Update script to not set job name variable in __inputs

Follow up to

@nflaig nflaig requested a review from a team as a code owner May 30, 2023 09:11
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: c8c26c1 Previous: 8490369 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 614.02 us/op 497.32 us/op 1.23
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 48.805 us/op 45.225 us/op 1.08
BLS verify - blst-native 1.2346 ms/op 1.1990 ms/op 1.03
BLS verifyMultipleSignatures 3 - blst-native 2.5356 ms/op 2.4431 ms/op 1.04
BLS verifyMultipleSignatures 8 - blst-native 5.4753 ms/op 5.2412 ms/op 1.04
BLS verifyMultipleSignatures 32 - blst-native 19.893 ms/op 19.026 ms/op 1.05
BLS aggregatePubkeys 32 - blst-native 26.221 us/op 25.494 us/op 1.03
BLS aggregatePubkeys 128 - blst-native 102.55 us/op 99.038 us/op 1.04
getAttestationsForBlock 56.574 ms/op 60.243 ms/op 0.94
isKnown best case - 1 super set check 289.00 ns/op 263.00 ns/op 1.10
isKnown normal case - 2 super set checks 285.00 ns/op 263.00 ns/op 1.08
isKnown worse case - 16 super set checks 272.00 ns/op 260.00 ns/op 1.05
CheckpointStateCache - add get delete 6.3410 us/op 5.7350 us/op 1.11
validate gossip signedAggregateAndProof - struct 3.1225 ms/op 2.7782 ms/op 1.12
validate gossip attestation - struct 1.4178 ms/op 1.3178 ms/op 1.08
pickEth1Vote - no votes 1.3997 ms/op 1.3828 ms/op 1.01
pickEth1Vote - max votes 12.041 ms/op 10.783 ms/op 1.12
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.6459 ms/op 9.8935 ms/op 0.97
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 15.430 ms/op 16.273 ms/op 0.95
pickEth1Vote - Eth1Data fastSerialize value x2048 715.49 us/op 741.19 us/op 0.97
pickEth1Vote - Eth1Data fastSerialize tree x2048 8.6878 ms/op 5.7572 ms/op 1.51
bytes32 toHexString 544.00 ns/op 703.00 ns/op 0.77
bytes32 Buffer.toString(hex) 395.00 ns/op 429.00 ns/op 0.92
bytes32 Buffer.toString(hex) from Uint8Array 588.00 ns/op 613.00 ns/op 0.96
bytes32 Buffer.toString(hex) + 0x 381.00 ns/op 427.00 ns/op 0.89
Object access 1 prop 0.16800 ns/op 0.20400 ns/op 0.82
Map access 1 prop 0.16400 ns/op 0.16600 ns/op 0.99
Object get x1000 6.7220 ns/op 6.7580 ns/op 0.99
Map get x1000 0.58100 ns/op 0.61500 ns/op 0.94
Object set x1000 54.336 ns/op 68.331 ns/op 0.80
Map set x1000 44.849 ns/op 54.340 ns/op 0.83
Return object 10000 times 0.24590 ns/op 0.24640 ns/op 1.00
Throw Error 10000 times 4.2874 us/op 4.3296 us/op 0.99
fastMsgIdFn sha256 / 200 bytes 3.6250 us/op 3.5840 us/op 1.01
fastMsgIdFn h32 xxhash / 200 bytes 323.00 ns/op 328.00 ns/op 0.98
fastMsgIdFn h64 xxhash / 200 bytes 452.00 ns/op 479.00 ns/op 0.94
fastMsgIdFn sha256 / 1000 bytes 12.038 us/op 11.847 us/op 1.02
fastMsgIdFn h32 xxhash / 1000 bytes 447.00 ns/op 465.00 ns/op 0.96
fastMsgIdFn h64 xxhash / 1000 bytes 508.00 ns/op 570.00 ns/op 0.89
fastMsgIdFn sha256 / 10000 bytes 103.89 us/op 104.38 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 2.0070 us/op 1.9990 us/op 1.00
fastMsgIdFn h64 xxhash / 10000 bytes 1.3700 us/op 1.4680 us/op 0.93
enrSubnets - fastDeserialize 64 bits 1.3230 us/op 1.7630 us/op 0.75
enrSubnets - ssz BitVector 64 bits 474.00 ns/op 640.00 ns/op 0.74
enrSubnets - fastDeserialize 4 bits 176.00 ns/op 215.00 ns/op 0.82
enrSubnets - ssz BitVector 4 bits 483.00 ns/op 641.00 ns/op 0.75
prioritizePeers score -10:0 att 32-0.1 sync 2-0 106.17 us/op 116.91 us/op 0.91
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 155.95 us/op 164.50 us/op 0.95
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 177.65 us/op 197.32 us/op 0.90
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 354.11 us/op 375.24 us/op 0.94
prioritizePeers score 0:0 att 64-1 sync 4-1 377.45 us/op 454.58 us/op 0.83
array of 16000 items push then shift 1.6159 us/op 1.6856 us/op 0.96
LinkedList of 16000 items push then shift 8.7790 ns/op 9.5600 ns/op 0.92
array of 16000 items push then pop 101.09 ns/op 120.49 ns/op 0.84
LinkedList of 16000 items push then pop 8.4580 ns/op 9.1090 ns/op 0.93
array of 24000 items push then shift 2.4031 us/op 2.3736 us/op 1.01
LinkedList of 24000 items push then shift 9.0240 ns/op 9.5760 ns/op 0.94
array of 24000 items push then pop 84.767 ns/op 94.468 ns/op 0.90
LinkedList of 24000 items push then pop 8.8550 ns/op 9.0590 ns/op 0.98
intersect bitArray bitLen 8 13.551 ns/op 13.504 ns/op 1.00
intersect array and set length 8 75.922 ns/op 105.85 ns/op 0.72
intersect bitArray bitLen 128 44.627 ns/op 45.217 ns/op 0.99
intersect array and set length 128 1.0536 us/op 1.3050 us/op 0.81
Buffer.concat 32 items 2.6720 us/op 3.0030 us/op 0.89
Uint8Array.set 32 items 2.5330 us/op 2.4150 us/op 1.05
transfer serialized Status (84 B) 2.1060 us/op 2.2580 us/op 0.93
copy serialized Status (84 B) 1.7410 us/op 1.9210 us/op 0.91
transfer serialized SignedVoluntaryExit (112 B) 2.2070 us/op 2.4960 us/op 0.88
copy serialized SignedVoluntaryExit (112 B) 1.8010 us/op 1.9640 us/op 0.92
transfer serialized ProposerSlashing (416 B) 2.4320 us/op 2.9260 us/op 0.83
copy serialized ProposerSlashing (416 B) 2.1910 us/op 3.2060 us/op 0.68
transfer serialized Attestation (485 B) 2.5710 us/op 3.3390 us/op 0.77
copy serialized Attestation (485 B) 2.9360 us/op 3.1090 us/op 0.94
transfer serialized AttesterSlashing (33232 B) 2.8230 us/op 2.8370 us/op 1.00
copy serialized AttesterSlashing (33232 B) 6.7510 us/op 8.9810 us/op 0.75
transfer serialized Small SignedBeaconBlock (128000 B) 2.6830 us/op 3.6780 us/op 0.73
copy serialized Small SignedBeaconBlock (128000 B) 16.090 us/op 32.235 us/op 0.50
transfer serialized Avg SignedBeaconBlock (200000 B) 3.2900 us/op 3.6390 us/op 0.90
copy serialized Avg SignedBeaconBlock (200000 B) 21.520 us/op 32.741 us/op 0.66
transfer serialized BlobsSidecar (524380 B) 3.2550 us/op 3.9790 us/op 0.82
copy serialized BlobsSidecar (524380 B) 176.21 us/op 213.59 us/op 0.82
transfer serialized Big SignedBeaconBlock (1000000 B) 3.3570 us/op 3.9490 us/op 0.85
copy serialized Big SignedBeaconBlock (1000000 B) 298.37 us/op 366.68 us/op 0.81
pass gossip attestations to forkchoice per slot 2.4103 ms/op 2.4138 ms/op 1.00
computeDeltas 3.2523 ms/op 3.1568 ms/op 1.03
computeProposerBoostScoreFromBalances 1.7866 ms/op 1.7702 ms/op 1.01
altair processAttestation - 250000 vs - 7PWei normalcase 2.1866 ms/op 2.3706 ms/op 0.92
altair processAttestation - 250000 vs - 7PWei worstcase 3.4973 ms/op 3.3652 ms/op 1.04
altair processAttestation - setStatus - 1/6 committees join 143.20 us/op 140.85 us/op 1.02
altair processAttestation - setStatus - 1/3 committees join 281.71 us/op 284.81 us/op 0.99
altair processAttestation - setStatus - 1/2 committees join 384.04 us/op 369.74 us/op 1.04
altair processAttestation - setStatus - 2/3 committees join 485.47 us/op 458.18 us/op 1.06
altair processAttestation - setStatus - 4/5 committees join 661.11 us/op 661.12 us/op 1.00
altair processAttestation - setStatus - 100% committees join 826.61 us/op 745.14 us/op 1.11
altair processBlock - 250000 vs - 7PWei normalcase 19.281 ms/op 14.458 ms/op 1.33
altair processBlock - 250000 vs - 7PWei normalcase hashState 26.994 ms/op 25.233 ms/op 1.07
altair processBlock - 250000 vs - 7PWei worstcase 55.270 ms/op 46.349 ms/op 1.19
altair processBlock - 250000 vs - 7PWei worstcase hashState 72.723 ms/op 68.550 ms/op 1.06
phase0 processBlock - 250000 vs - 7PWei normalcase 2.6594 ms/op 2.3659 ms/op 1.12
phase0 processBlock - 250000 vs - 7PWei worstcase 34.172 ms/op 29.189 ms/op 1.17
altair processEth1Data - 250000 vs - 7PWei normalcase 639.10 us/op 487.47 us/op 1.31
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 9.9560 us/op 7.7250 us/op 1.29
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 31.587 us/op 22.694 us/op 1.39
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 10.400 us/op 9.0060 us/op 1.15
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 8.4670 us/op 6.9600 us/op 1.22
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 106.64 us/op 90.176 us/op 1.18
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 649.20 us/op 626.61 us/op 1.04
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 919.66 us/op 896.49 us/op 1.03
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 879.20 us/op 868.37 us/op 1.01
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.3078 ms/op 2.1902 ms/op 1.05
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.5801 ms/op 1.4941 ms/op 1.06
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.9193 ms/op 4.1218 ms/op 0.95
Tree 40 250000 create 306.20 ms/op 309.05 ms/op 0.99
Tree 40 250000 get(125000) 181.28 ns/op 176.44 ns/op 1.03
Tree 40 250000 set(125000) 1.0208 us/op 892.00 ns/op 1.14
Tree 40 250000 toArray() 18.186 ms/op 17.256 ms/op 1.05
Tree 40 250000 iterate all - toArray() + loop 19.801 ms/op 17.051 ms/op 1.16
Tree 40 250000 iterate all - get(i) 72.173 ms/op 65.847 ms/op 1.10
MutableVector 250000 create 11.872 ms/op 10.563 ms/op 1.12
MutableVector 250000 get(125000) 6.6450 ns/op 6.2540 ns/op 1.06
MutableVector 250000 set(125000) 271.00 ns/op 278.05 ns/op 0.97
MutableVector 250000 toArray() 3.4916 ms/op 3.0332 ms/op 1.15
MutableVector 250000 iterate all - toArray() + loop 3.6876 ms/op 2.8428 ms/op 1.30
MutableVector 250000 iterate all - get(i) 1.5600 ms/op 1.5162 ms/op 1.03
Array 250000 create 3.6964 ms/op 2.5604 ms/op 1.44
Array 250000 clone - spread 1.2310 ms/op 1.1122 ms/op 1.11
Array 250000 get(125000) 0.60900 ns/op 0.56100 ns/op 1.09
Array 250000 set(125000) 0.68000 ns/op 0.63000 ns/op 1.08
Array 250000 iterate all - loop 87.172 us/op 110.25 us/op 0.79
effectiveBalanceIncrements clone Uint8Array 300000 49.210 us/op 27.056 us/op 1.82
effectiveBalanceIncrements clone MutableVector 300000 375.00 ns/op 345.00 ns/op 1.09
effectiveBalanceIncrements rw all Uint8Array 300000 173.37 us/op 168.05 us/op 1.03
effectiveBalanceIncrements rw all MutableVector 300000 90.444 ms/op 81.407 ms/op 1.11
phase0 afterProcessEpoch - 250000 vs - 7PWei 119.56 ms/op 114.35 ms/op 1.05
phase0 beforeProcessEpoch - 250000 vs - 7PWei 46.585 ms/op 41.838 ms/op 1.11
altair processEpoch - mainnet_e81889 324.31 ms/op 305.75 ms/op 1.06
mainnet_e81889 - altair beforeProcessEpoch 48.745 ms/op 69.173 ms/op 0.70
mainnet_e81889 - altair processJustificationAndFinalization 16.259 us/op 18.213 us/op 0.89
mainnet_e81889 - altair processInactivityUpdates 5.2475 ms/op 6.3750 ms/op 0.82
mainnet_e81889 - altair processRewardsAndPenalties 73.012 ms/op 52.945 ms/op 1.38
mainnet_e81889 - altair processRegistryUpdates 2.2290 us/op 3.6140 us/op 0.62
mainnet_e81889 - altair processSlashings 465.00 ns/op 498.00 ns/op 0.93
mainnet_e81889 - altair processEth1DataReset 537.00 ns/op 548.00 ns/op 0.98
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2480 ms/op 1.2494 ms/op 1.00
mainnet_e81889 - altair processSlashingsReset 4.8270 us/op 4.7570 us/op 1.01
mainnet_e81889 - altair processRandaoMixesReset 4.3390 us/op 4.5270 us/op 0.96
mainnet_e81889 - altair processHistoricalRootsUpdate 710.00 ns/op 613.00 ns/op 1.16
mainnet_e81889 - altair processParticipationFlagUpdates 2.4820 us/op 2.4380 us/op 1.02
mainnet_e81889 - altair processSyncCommitteeUpdates 503.00 ns/op 880.00 ns/op 0.57
mainnet_e81889 - altair afterProcessEpoch 115.95 ms/op 126.56 ms/op 0.92
phase0 processEpoch - mainnet_e58758 326.16 ms/op 357.97 ms/op 0.91
mainnet_e58758 - phase0 beforeProcessEpoch 128.28 ms/op 140.42 ms/op 0.91
mainnet_e58758 - phase0 processJustificationAndFinalization 31.970 us/op 17.104 us/op 1.87
mainnet_e58758 - phase0 processRewardsAndPenalties 41.365 ms/op 65.821 ms/op 0.63
mainnet_e58758 - phase0 processRegistryUpdates 7.3070 us/op 8.0200 us/op 0.91
mainnet_e58758 - phase0 processSlashings 501.00 ns/op 489.00 ns/op 1.02
mainnet_e58758 - phase0 processEth1DataReset 606.00 ns/op 494.00 ns/op 1.23
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0265 ms/op 1.0617 ms/op 0.97
mainnet_e58758 - phase0 processSlashingsReset 3.0670 us/op 3.3670 us/op 0.91
mainnet_e58758 - phase0 processRandaoMixesReset 5.0290 us/op 4.4460 us/op 1.13
mainnet_e58758 - phase0 processHistoricalRootsUpdate 681.00 ns/op 588.00 ns/op 1.16
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.2650 us/op 3.8130 us/op 1.12
mainnet_e58758 - phase0 afterProcessEpoch 103.20 ms/op 97.858 ms/op 1.05
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2839 ms/op 1.2303 ms/op 1.04
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4664 ms/op 1.5625 ms/op 0.94
altair processInactivityUpdates - 250000 normalcase 23.900 ms/op 28.439 ms/op 0.84
altair processInactivityUpdates - 250000 worstcase 26.073 ms/op 29.266 ms/op 0.89
phase0 processRegistryUpdates - 250000 normalcase 8.6240 us/op 6.8990 us/op 1.25
phase0 processRegistryUpdates - 250000 badcase_full_deposits 272.22 us/op 268.72 us/op 1.01
phase0 processRegistryUpdates - 250000 worstcase 0.5 130.70 ms/op 130.13 ms/op 1.00
altair processRewardsAndPenalties - 250000 normalcase 58.282 ms/op 68.495 ms/op 0.85
altair processRewardsAndPenalties - 250000 worstcase 54.933 ms/op 72.642 ms/op 0.76
phase0 getAttestationDeltas - 250000 normalcase 7.0270 ms/op 6.8962 ms/op 1.02
phase0 getAttestationDeltas - 250000 worstcase 7.1246 ms/op 6.8561 ms/op 1.04
phase0 processSlashings - 250000 worstcase 3.6862 ms/op 3.5053 ms/op 1.05
altair processSyncCommitteeUpdates - 250000 184.25 ms/op 180.48 ms/op 1.02
BeaconState.hashTreeRoot - No change 264.00 ns/op 261.00 ns/op 1.01
BeaconState.hashTreeRoot - 1 full validator 49.440 us/op 52.156 us/op 0.95
BeaconState.hashTreeRoot - 32 full validator 486.61 us/op 474.31 us/op 1.03
BeaconState.hashTreeRoot - 512 full validator 5.1464 ms/op 5.7647 ms/op 0.89
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 59.664 us/op 61.876 us/op 0.96
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 901.19 us/op 899.15 us/op 1.00
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.006 ms/op 11.172 ms/op 0.99
BeaconState.hashTreeRoot - 1 balances 47.671 us/op 50.700 us/op 0.94
BeaconState.hashTreeRoot - 32 balances 444.15 us/op 463.54 us/op 0.96
BeaconState.hashTreeRoot - 512 balances 4.2697 ms/op 4.1975 ms/op 1.02
BeaconState.hashTreeRoot - 250000 balances 68.288 ms/op 70.520 ms/op 0.97
aggregationBits - 2048 els - zipIndexesInBitList 16.567 us/op 16.839 us/op 0.98
regular array get 100000 times 32.450 us/op 32.601 us/op 1.00
wrappedArray get 100000 times 32.431 us/op 32.552 us/op 1.00
arrayWithProxy get 100000 times 16.030 ms/op 16.305 ms/op 0.98
ssz.Root.equals 556.00 ns/op 569.00 ns/op 0.98
byteArrayEquals 542.00 ns/op 546.00 ns/op 0.99
shuffle list - 16384 els 6.7730 ms/op 7.0448 ms/op 0.96
shuffle list - 250000 els 97.533 ms/op 99.512 ms/op 0.98
processSlot - 1 slots 9.2120 us/op 8.8070 us/op 1.05
processSlot - 32 slots 1.2794 ms/op 1.3720 ms/op 0.93
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 33.248 ms/op 36.527 ms/op 0.91
getCommitteeAssignments - req 1 vs - 250000 vc 2.8585 ms/op 2.8883 ms/op 0.99
getCommitteeAssignments - req 100 vs - 250000 vc 4.0528 ms/op 4.0972 ms/op 0.99
getCommitteeAssignments - req 1000 vs - 250000 vc 4.4431 ms/op 4.3645 ms/op 1.02
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.3300 ns/op 4.7900 ns/op 0.90
state getBlockRootAtSlot - 250000 vs - 7PWei 1.0114 us/op 797.70 ns/op 1.27
computeProposers - vc 250000 10.501 ms/op 10.567 ms/op 0.99
computeEpochShuffling - vc 250000 100.02 ms/op 103.35 ms/op 0.97
getNextSyncCommittee - vc 250000 174.12 ms/op 172.99 ms/op 1.01
computeSigningRoot for AttestationData 14.033 us/op 12.757 us/op 1.10
hash AttestationData serialized data then Buffer.toString(base64) 2.4281 us/op 2.4535 us/op 0.99
toHexString serialized data 1.0761 us/op 1.0696 us/op 1.01
Buffer.toString(base64) 310.31 ns/op 319.15 ns/op 0.97

by benchmarkbot/action

@wemeetagain wemeetagain merged commit c3b92d7 into unstable May 30, 2023
11 checks passed
@wemeetagain wemeetagain deleted the nflaig/fix-dashboard-job-vars branch May 30, 2023 14:45
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nflaig @wemeetagain