Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update issue templates #5606

Merged
merged 3 commits into from
Jun 3, 2023
Merged

chore: update issue templates #5606

merged 3 commits into from
Jun 3, 2023

Conversation

philknows
Copy link
Member

Motivation

This PR is to more cleanly apply the call to actions for a user coming onto our repository looking for sources of help by clicking "New issue".

Description

This PR removes the markdown in the issue templates and directs users to ask questions in our "Discussions" section of the repo or to seek joining our Discord from the issue templates, rather than in the issues themselves.

This PR also updates the placeholder text in how to submit a bug report with properly defined steps based on this comment: #5539 (comment)

@philknows philknows requested a review from a team as a code owner June 3, 2023 17:40
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 3d2610e Previous: 2fbe6fa Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 873.88 us/op 522.40 us/op 1.67
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 45.925 us/op 45.860 us/op 1.00
BLS verify - blst-native 1.2070 ms/op 1.2258 ms/op 0.98
BLS verifyMultipleSignatures 3 - blst-native 2.4587 ms/op 2.4940 ms/op 0.99
BLS verifyMultipleSignatures 8 - blst-native 5.2934 ms/op 5.3790 ms/op 0.98
BLS verifyMultipleSignatures 32 - blst-native 19.052 ms/op 19.480 ms/op 0.98
BLS aggregatePubkeys 32 - blst-native 25.663 us/op 26.281 us/op 0.98
BLS aggregatePubkeys 128 - blst-native 99.634 us/op 101.22 us/op 0.98
getAttestationsForBlock 60.341 ms/op 53.857 ms/op 1.12
isKnown best case - 1 super set check 253.00 ns/op 265.00 ns/op 0.95
isKnown normal case - 2 super set checks 251.00 ns/op 251.00 ns/op 1.00
isKnown worse case - 16 super set checks 250.00 ns/op 253.00 ns/op 0.99
CheckpointStateCache - add get delete 4.8940 us/op 5.2050 us/op 0.94
validate gossip signedAggregateAndProof - struct 2.6622 ms/op 2.7949 ms/op 0.95
validate gossip attestation - struct 1.3231 ms/op 1.3443 ms/op 0.98
pickEth1Vote - no votes 1.2781 ms/op 1.2943 ms/op 0.99
pickEth1Vote - max votes 10.745 ms/op 10.595 ms/op 1.01
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.4176 ms/op 9.1826 ms/op 0.92
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 18.021 ms/op 13.978 ms/op 1.29
pickEth1Vote - Eth1Data fastSerialize value x2048 728.71 us/op 648.90 us/op 1.12
pickEth1Vote - Eth1Data fastSerialize tree x2048 9.2850 ms/op 4.8312 ms/op 1.92
bytes32 toHexString 477.00 ns/op 513.00 ns/op 0.93
bytes32 Buffer.toString(hex) 349.00 ns/op 364.00 ns/op 0.96
bytes32 Buffer.toString(hex) from Uint8Array 543.00 ns/op 582.00 ns/op 0.93
bytes32 Buffer.toString(hex) + 0x 356.00 ns/op 360.00 ns/op 0.99
Object access 1 prop 0.15400 ns/op 0.17900 ns/op 0.86
Map access 1 prop 0.15300 ns/op 0.16400 ns/op 0.93
Object get x1000 6.2950 ns/op 6.8630 ns/op 0.92
Map get x1000 0.58200 ns/op 0.55500 ns/op 1.05
Object set x1000 47.894 ns/op 54.502 ns/op 0.88
Map set x1000 40.507 ns/op 43.897 ns/op 0.92
Return object 10000 times 0.22190 ns/op 0.24300 ns/op 0.91
Throw Error 10000 times 4.0099 us/op 4.2298 us/op 0.95
fastMsgIdFn sha256 / 200 bytes 3.2360 us/op 3.5190 us/op 0.92
fastMsgIdFn h32 xxhash / 200 bytes 271.00 ns/op 293.00 ns/op 0.92
fastMsgIdFn h64 xxhash / 200 bytes 377.00 ns/op 410.00 ns/op 0.92
fastMsgIdFn sha256 / 1000 bytes 11.021 us/op 11.616 us/op 0.95
fastMsgIdFn h32 xxhash / 1000 bytes 386.00 ns/op 428.00 ns/op 0.90
fastMsgIdFn h64 xxhash / 1000 bytes 442.00 ns/op 482.00 ns/op 0.92
fastMsgIdFn sha256 / 10000 bytes 98.504 us/op 103.64 us/op 0.95
fastMsgIdFn h32 xxhash / 10000 bytes 1.8260 us/op 1.9620 us/op 0.93
fastMsgIdFn h64 xxhash / 10000 bytes 1.2960 us/op 1.3720 us/op 0.94
enrSubnets - fastDeserialize 64 bits 1.1860 us/op 1.2870 us/op 0.92
enrSubnets - ssz BitVector 64 bits 458.00 ns/op 489.00 ns/op 0.94
enrSubnets - fastDeserialize 4 bits 161.00 ns/op 174.00 ns/op 0.93
enrSubnets - ssz BitVector 4 bits 465.00 ns/op 494.00 ns/op 0.94
prioritizePeers score -10:0 att 32-0.1 sync 2-0 105.36 us/op 106.72 us/op 0.99
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 134.51 us/op 133.14 us/op 1.01
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 167.98 us/op 165.60 us/op 1.01
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 290.48 us/op 302.52 us/op 0.96
prioritizePeers score 0:0 att 64-1 sync 4-1 366.50 us/op 366.11 us/op 1.00
array of 16000 items push then shift 1.6328 us/op 1.6208 us/op 1.01
LinkedList of 16000 items push then shift 8.8740 ns/op 8.7090 ns/op 1.02
array of 16000 items push then pop 83.089 ns/op 74.267 ns/op 1.12
LinkedList of 16000 items push then pop 8.5510 ns/op 8.6630 ns/op 0.99
array of 24000 items push then shift 2.3518 us/op 2.3500 us/op 1.00
LinkedList of 24000 items push then shift 8.4870 ns/op 8.7670 ns/op 0.97
array of 24000 items push then pop 72.717 ns/op 78.499 ns/op 0.93
LinkedList of 24000 items push then pop 8.0200 ns/op 8.4300 ns/op 0.95
intersect bitArray bitLen 8 12.690 ns/op 13.324 ns/op 0.95
intersect array and set length 8 71.526 ns/op 78.246 ns/op 0.91
intersect bitArray bitLen 128 41.652 ns/op 43.825 ns/op 0.95
intersect array and set length 128 985.17 ns/op 1.0655 us/op 0.92
Buffer.concat 32 items 2.4660 us/op 2.8810 us/op 0.86
Uint8Array.set 32 items 3.1580 us/op 2.6610 us/op 1.19
transfer serialized Status (84 B) 2.3550 us/op 2.0480 us/op 1.15
copy serialized Status (84 B) 2.0200 us/op 1.7500 us/op 1.15
transfer serialized SignedVoluntaryExit (112 B) 2.4670 us/op 2.0960 us/op 1.18
copy serialized SignedVoluntaryExit (112 B) 2.1580 us/op 1.7810 us/op 1.21
transfer serialized ProposerSlashing (416 B) 3.4410 us/op 2.3710 us/op 1.45
copy serialized ProposerSlashing (416 B) 3.5750 us/op 2.5060 us/op 1.43
transfer serialized Attestation (485 B) 3.6290 us/op 3.0340 us/op 1.20
copy serialized Attestation (485 B) 3.4360 us/op 2.8620 us/op 1.20
transfer serialized AttesterSlashing (33232 B) 3.7070 us/op 2.7770 us/op 1.33
copy serialized AttesterSlashing (33232 B) 7.1600 us/op 5.3490 us/op 1.34
transfer serialized Small SignedBeaconBlock (128000 B) 3.4980 us/op 3.0870 us/op 1.13
copy serialized Small SignedBeaconBlock (128000 B) 15.537 us/op 13.306 us/op 1.17
transfer serialized Avg SignedBeaconBlock (200000 B) 3.5560 us/op 3.4270 us/op 1.04
copy serialized Avg SignedBeaconBlock (200000 B) 21.593 us/op 18.398 us/op 1.17
transfer serialized BlobsSidecar (524380 B) 3.4330 us/op 3.3080 us/op 1.04
copy serialized BlobsSidecar (524380 B) 69.270 us/op 161.13 us/op 0.43
transfer serialized Big SignedBeaconBlock (1000000 B) 3.4680 us/op 3.4810 us/op 1.00
copy serialized Big SignedBeaconBlock (1000000 B) 270.03 us/op 252.89 us/op 1.07
pass gossip attestations to forkchoice per slot 2.5736 ms/op 2.6902 ms/op 0.96
forkChoice updateHead vc 100000 bc 64 eq 0 1.9783 ms/op 2.1250 ms/op 0.93
forkChoice updateHead vc 600000 bc 64 eq 0 10.763 ms/op 11.877 ms/op 0.91
forkChoice updateHead vc 1000000 bc 64 eq 0 17.957 ms/op 22.595 ms/op 0.79
forkChoice updateHead vc 600000 bc 320 eq 0 15.947 ms/op 16.940 ms/op 0.94
forkChoice updateHead vc 600000 bc 1200 eq 0 77.296 ms/op 82.157 ms/op 0.94
forkChoice updateHead vc 600000 bc 64 eq 1000 19.937 ms/op 21.550 ms/op 0.93
forkChoice updateHead vc 600000 bc 64 eq 10000 22.365 ms/op 23.301 ms/op 0.96
forkChoice updateHead vc 600000 bc 64 eq 300000 30.612 ms/op 32.300 ms/op 0.95
computeDeltas 4.6285 ms/op 3.7145 ms/op 1.25
computeProposerBoostScoreFromBalances 1.7709 ms/op 1.8342 ms/op 0.97
altair processAttestation - 250000 vs - 7PWei normalcase 2.1574 ms/op 2.2842 ms/op 0.94
altair processAttestation - 250000 vs - 7PWei worstcase 3.2410 ms/op 4.6743 ms/op 0.69
altair processAttestation - setStatus - 1/6 committees join 135.30 us/op 149.80 us/op 0.90
altair processAttestation - setStatus - 1/3 committees join 267.92 us/op 288.45 us/op 0.93
altair processAttestation - setStatus - 1/2 committees join 373.21 us/op 379.90 us/op 0.98
altair processAttestation - setStatus - 2/3 committees join 475.93 us/op 477.35 us/op 1.00
altair processAttestation - setStatus - 4/5 committees join 627.01 us/op 673.86 us/op 0.93
altair processAttestation - setStatus - 100% committees join 750.54 us/op 778.71 us/op 0.96
altair processBlock - 250000 vs - 7PWei normalcase 21.664 ms/op 16.329 ms/op 1.33
altair processBlock - 250000 vs - 7PWei normalcase hashState 30.408 ms/op 28.390 ms/op 1.07
altair processBlock - 250000 vs - 7PWei worstcase 65.162 ms/op 49.849 ms/op 1.31
altair processBlock - 250000 vs - 7PWei worstcase hashState 82.898 ms/op 72.065 ms/op 1.15
phase0 processBlock - 250000 vs - 7PWei normalcase 1.8876 ms/op 2.2711 ms/op 0.83
phase0 processBlock - 250000 vs - 7PWei worstcase 28.474 ms/op 32.184 ms/op 0.88
altair processEth1Data - 250000 vs - 7PWei normalcase 445.20 us/op 673.47 us/op 0.66
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 11.288 us/op 13.976 us/op 0.81
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 31.619 us/op 44.388 us/op 0.71
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 13.108 us/op 18.028 us/op 0.73
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 10.908 us/op 12.133 us/op 0.90
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 121.96 us/op 123.59 us/op 0.99
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.2249 ms/op 748.75 us/op 1.64
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.6520 ms/op 1.3014 ms/op 1.27
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.6193 ms/op 1.2035 ms/op 1.35
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.1919 ms/op 3.9087 ms/op 0.56
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.5320 ms/op 2.4567 ms/op 1.03
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.9437 ms/op 6.1965 ms/op 0.64
Tree 40 250000 create 326.25 ms/op 674.34 ms/op 0.48
Tree 40 250000 get(125000) 177.03 ns/op 211.44 ns/op 0.84
Tree 40 250000 set(125000) 895.04 ns/op 1.4488 us/op 0.62
Tree 40 250000 toArray() 17.270 ms/op 27.384 ms/op 0.63
Tree 40 250000 iterate all - toArray() + loop 17.206 ms/op 27.072 ms/op 0.64
Tree 40 250000 iterate all - get(i) 67.510 ms/op 82.526 ms/op 0.82
MutableVector 250000 create 14.937 ms/op 13.666 ms/op 1.09
MutableVector 250000 get(125000) 6.5750 ns/op 7.1030 ns/op 0.93
MutableVector 250000 set(125000) 245.81 ns/op 462.31 ns/op 0.53
MutableVector 250000 toArray() 2.7852 ms/op 4.0761 ms/op 0.68
MutableVector 250000 iterate all - toArray() + loop 2.8012 ms/op 4.0973 ms/op 0.68
MutableVector 250000 iterate all - get(i) 1.5131 ms/op 1.6344 ms/op 0.93
Array 250000 create 2.4888 ms/op 3.9871 ms/op 0.62
Array 250000 clone - spread 1.1332 ms/op 1.7381 ms/op 0.65
Array 250000 get(125000) 0.55400 ns/op 1.4710 ns/op 0.38
Array 250000 set(125000) 0.62500 ns/op 1.1430 ns/op 0.55
Array 250000 iterate all - loop 83.538 us/op 93.101 us/op 0.90
effectiveBalanceIncrements clone Uint8Array 300000 25.576 us/op 62.321 us/op 0.41
effectiveBalanceIncrements clone MutableVector 300000 302.00 ns/op 443.00 ns/op 0.68
effectiveBalanceIncrements rw all Uint8Array 300000 161.95 us/op 179.48 us/op 0.90
effectiveBalanceIncrements rw all MutableVector 300000 74.315 ms/op 122.63 ms/op 0.61
phase0 afterProcessEpoch - 250000 vs - 7PWei 112.77 ms/op 132.78 ms/op 0.85
phase0 beforeProcessEpoch - 250000 vs - 7PWei 45.570 ms/op 44.583 ms/op 1.02
altair processEpoch - mainnet_e81889 348.84 ms/op 400.97 ms/op 0.87
mainnet_e81889 - altair beforeProcessEpoch 54.021 ms/op 85.907 ms/op 0.63
mainnet_e81889 - altair processJustificationAndFinalization 27.231 us/op 26.497 us/op 1.03
mainnet_e81889 - altair processInactivityUpdates 5.3288 ms/op 8.5535 ms/op 0.62
mainnet_e81889 - altair processRewardsAndPenalties 90.706 ms/op 73.573 ms/op 1.23
mainnet_e81889 - altair processRegistryUpdates 4.6550 us/op 6.8740 us/op 0.68
mainnet_e81889 - altair processSlashings 825.00 ns/op 1.3770 us/op 0.60
mainnet_e81889 - altair processEth1DataReset 816.00 ns/op 1.3820 us/op 0.59
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.2769 ms/op 1.5900 ms/op 1.43
mainnet_e81889 - altair processSlashingsReset 6.6880 us/op 9.1770 us/op 0.73
mainnet_e81889 - altair processRandaoMixesReset 10.317 us/op 12.931 us/op 0.80
mainnet_e81889 - altair processHistoricalRootsUpdate 1.2820 us/op 1.8850 us/op 0.68
mainnet_e81889 - altair processParticipationFlagUpdates 3.7510 us/op 8.1920 us/op 0.46
mainnet_e81889 - altair processSyncCommitteeUpdates 819.00 ns/op 828.00 ns/op 0.99
mainnet_e81889 - altair afterProcessEpoch 126.23 ms/op 154.65 ms/op 0.82
phase0 processEpoch - mainnet_e58758 399.81 ms/op 476.93 ms/op 0.84
mainnet_e58758 - phase0 beforeProcessEpoch 166.37 ms/op 216.31 ms/op 0.77
mainnet_e58758 - phase0 processJustificationAndFinalization 25.796 us/op 34.993 us/op 0.74
mainnet_e58758 - phase0 processRewardsAndPenalties 76.394 ms/op 84.693 ms/op 0.90
mainnet_e58758 - phase0 processRegistryUpdates 7.8070 us/op 19.168 us/op 0.41
mainnet_e58758 - phase0 processSlashings 881.00 ns/op 1.7350 us/op 0.51
mainnet_e58758 - phase0 processEth1DataReset 856.00 ns/op 1.7090 us/op 0.50
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.8729 ms/op 1.8808 ms/op 1.00
mainnet_e58758 - phase0 processSlashingsReset 5.7930 us/op 8.0910 us/op 0.72
mainnet_e58758 - phase0 processRandaoMixesReset 8.5420 us/op 8.3210 us/op 1.03
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.1670 us/op 1.2160 us/op 0.96
mainnet_e58758 - phase0 processParticipationRecordUpdates 6.4160 us/op 9.2110 us/op 0.70
mainnet_e58758 - phase0 afterProcessEpoch 95.681 ms/op 108.62 ms/op 0.88
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.1456 ms/op 1.3220 ms/op 0.87
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.6045 ms/op 2.0880 ms/op 0.77
altair processInactivityUpdates - 250000 normalcase 33.045 ms/op 25.212 ms/op 1.31
altair processInactivityUpdates - 250000 worstcase 32.507 ms/op 21.285 ms/op 1.53
phase0 processRegistryUpdates - 250000 normalcase 11.676 us/op 7.9510 us/op 1.47
phase0 processRegistryUpdates - 250000 badcase_full_deposits 467.00 us/op 305.16 us/op 1.53
phase0 processRegistryUpdates - 250000 worstcase 0.5 105.58 ms/op 131.86 ms/op 0.80
altair processRewardsAndPenalties - 250000 normalcase 80.397 ms/op 65.317 ms/op 1.23
altair processRewardsAndPenalties - 250000 worstcase 78.978 ms/op 71.896 ms/op 1.10
phase0 getAttestationDeltas - 250000 normalcase 6.4823 ms/op 7.1754 ms/op 0.90
phase0 getAttestationDeltas - 250000 worstcase 6.6274 ms/op 7.1329 ms/op 0.93
phase0 processSlashings - 250000 worstcase 3.6221 ms/op 3.6614 ms/op 0.99
altair processSyncCommitteeUpdates - 250000 175.49 ms/op 186.28 ms/op 0.94
BeaconState.hashTreeRoot - No change 255.00 ns/op 352.00 ns/op 0.72
BeaconState.hashTreeRoot - 1 full validator 63.585 us/op 54.563 us/op 1.17
BeaconState.hashTreeRoot - 32 full validator 571.34 us/op 507.51 us/op 1.13
BeaconState.hashTreeRoot - 512 full validator 6.2776 ms/op 6.2891 ms/op 1.00
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 69.514 us/op 67.987 us/op 1.02
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 945.46 us/op 944.45 us/op 1.00
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.309 ms/op 12.189 ms/op 0.93
BeaconState.hashTreeRoot - 1 balances 47.973 us/op 48.692 us/op 0.99
BeaconState.hashTreeRoot - 32 balances 586.47 us/op 455.28 us/op 1.29
BeaconState.hashTreeRoot - 512 balances 5.3253 ms/op 4.2205 ms/op 1.26
BeaconState.hashTreeRoot - 250000 balances 83.376 ms/op 74.872 ms/op 1.11
aggregationBits - 2048 els - zipIndexesInBitList 15.868 us/op 16.825 us/op 0.94
regular array get 100000 times 31.350 us/op 33.413 us/op 0.94
wrappedArray get 100000 times 31.449 us/op 33.443 us/op 0.94
arrayWithProxy get 100000 times 15.977 ms/op 17.642 ms/op 0.91
ssz.Root.equals 523.00 ns/op 608.00 ns/op 0.86
byteArrayEquals 511.00 ns/op 576.00 ns/op 0.89
shuffle list - 16384 els 6.6481 ms/op 7.1263 ms/op 0.93
shuffle list - 250000 els 97.300 ms/op 103.47 ms/op 0.94
processSlot - 1 slots 8.9000 us/op 9.3760 us/op 0.95
processSlot - 32 slots 1.3435 ms/op 1.4401 ms/op 0.93
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 43.690 ms/op 35.075 ms/op 1.25
getCommitteeAssignments - req 1 vs - 250000 vc 2.9365 ms/op 3.0159 ms/op 0.97
getCommitteeAssignments - req 100 vs - 250000 vc 4.1587 ms/op 4.2539 ms/op 0.98
getCommitteeAssignments - req 1000 vs - 250000 vc 4.5347 ms/op 4.5677 ms/op 0.99
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.6400 ns/op 4.8600 ns/op 0.95
state getBlockRootAtSlot - 250000 vs - 7PWei 793.47 ns/op 1.0642 us/op 0.75
computeProposers - vc 250000 10.107 ms/op 11.699 ms/op 0.86
computeEpochShuffling - vc 250000 101.97 ms/op 105.15 ms/op 0.97
getNextSyncCommittee - vc 250000 175.66 ms/op 175.47 ms/op 1.00
computeSigningRoot for AttestationData 13.518 us/op 13.930 us/op 0.97
hash AttestationData serialized data then Buffer.toString(base64) 2.3218 us/op 2.6133 us/op 0.89
toHexString serialized data 1.0189 us/op 1.0737 us/op 0.95
Buffer.toString(base64) 310.50 ns/op 332.23 ns/op 0.93

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 2f2bc46 into unstable Jun 3, 2023
11 checks passed
@wemeetagain wemeetagain deleted the philknows/update-issue-template branch June 3, 2023 18:14
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philknows @wemeetagain