Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix lint-grafana-dashboard.mjs id assertion #5673

Merged
merged 1 commit into from
Jun 20, 2023
Merged

chore: fix lint-grafana-dashboard.mjs id assertion #5673

merged 1 commit into from
Jun 20, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jun 20, 2023

No description provided.

@nflaig nflaig requested a review from a team as a code owner June 20, 2023 11:09
@github-actions
Copy link
Contributor

Performance Report

鉁旓笍 no performance regression detected

Full benchmark results
Benchmark suite Current: ea71bac Previous: e8b53ea Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 732.39 us/op 921.89 us/op 0.79
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 52.277 us/op 56.651 us/op 0.92
BLS verify - blst-native 1.2192 ms/op 1.3217 ms/op 0.92
BLS verifyMultipleSignatures 3 - blst-native 2.4793 ms/op 2.5808 ms/op 0.96
BLS verifyMultipleSignatures 8 - blst-native 5.2994 ms/op 5.5333 ms/op 0.96
BLS verifyMultipleSignatures 32 - blst-native 19.391 ms/op 19.998 ms/op 0.97
BLS aggregatePubkeys 32 - blst-native 25.846 us/op 27.011 us/op 0.96
BLS aggregatePubkeys 128 - blst-native 99.572 us/op 104.80 us/op 0.95
getAttestationsForBlock 60.574 ms/op 79.768 ms/op 0.76
isKnown best case - 1 super set check 256.00 ns/op 293.00 ns/op 0.87
isKnown normal case - 2 super set checks 246.00 ns/op 263.00 ns/op 0.94
isKnown worse case - 16 super set checks 251.00 ns/op 262.00 ns/op 0.96
CheckpointStateCache - add get delete 5.5480 us/op 6.3250 us/op 0.88
validate gossip signedAggregateAndProof - struct 2.7584 ms/op 2.9209 ms/op 0.94
validate gossip attestation - struct 1.3166 ms/op 1.3924 ms/op 0.95
pickEth1Vote - no votes 1.2298 ms/op 1.4829 ms/op 0.83
pickEth1Vote - max votes 8.8920 ms/op 14.803 ms/op 0.60
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.6166 ms/op 10.556 ms/op 0.82
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.014 ms/op 19.207 ms/op 0.73
pickEth1Vote - Eth1Data fastSerialize value x2048 632.50 us/op 848.71 us/op 0.75
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.5510 ms/op 6.0929 ms/op 0.75
bytes32 toHexString 486.00 ns/op 694.00 ns/op 0.70
bytes32 Buffer.toString(hex) 349.00 ns/op 444.00 ns/op 0.79
bytes32 Buffer.toString(hex) from Uint8Array 543.00 ns/op 663.00 ns/op 0.82
bytes32 Buffer.toString(hex) + 0x 344.00 ns/op 443.00 ns/op 0.78
Object access 1 prop 0.17100 ns/op 0.21100 ns/op 0.81
Map access 1 prop 0.15700 ns/op 0.17300 ns/op 0.91
Object get x1000 6.8410 ns/op 7.3460 ns/op 0.93
Map get x1000 0.52600 ns/op 0.75300 ns/op 0.70
Object set x1000 51.332 ns/op 87.623 ns/op 0.59
Map set x1000 42.937 ns/op 63.548 ns/op 0.68
Return object 10000 times 0.23510 ns/op 0.28590 ns/op 0.82
Throw Error 10000 times 4.2636 us/op 4.6221 us/op 0.92
fastMsgIdFn sha256 / 200 bytes 3.6310 us/op 3.8960 us/op 0.93
fastMsgIdFn h32 xxhash / 200 bytes 310.00 ns/op 339.00 ns/op 0.91
fastMsgIdFn h64 xxhash / 200 bytes 453.00 ns/op 528.00 ns/op 0.86
fastMsgIdFn sha256 / 1000 bytes 11.461 us/op 12.487 us/op 0.92
fastMsgIdFn h32 xxhash / 1000 bytes 437.00 ns/op 475.00 ns/op 0.92
fastMsgIdFn h64 xxhash / 1000 bytes 515.00 ns/op 606.00 ns/op 0.85
fastMsgIdFn sha256 / 10000 bytes 103.97 us/op 109.31 us/op 0.95
fastMsgIdFn h32 xxhash / 10000 bytes 1.9980 us/op 2.1440 us/op 0.93
fastMsgIdFn h64 xxhash / 10000 bytes 1.4730 us/op 1.5520 us/op 0.95
enrSubnets - fastDeserialize 64 bits 1.3530 us/op 1.9270 us/op 0.70
enrSubnets - ssz BitVector 64 bits 513.00 ns/op 643.00 ns/op 0.80
enrSubnets - fastDeserialize 4 bits 184.00 ns/op 226.00 ns/op 0.81
enrSubnets - ssz BitVector 4 bits 485.00 ns/op 648.00 ns/op 0.75
prioritizePeers score -10:0 att 32-0.1 sync 2-0 108.60 us/op 145.79 us/op 0.74
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 150.28 us/op 172.91 us/op 0.87
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 169.50 us/op 205.62 us/op 0.82
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 347.02 us/op 386.63 us/op 0.90
prioritizePeers score 0:0 att 64-1 sync 4-1 426.37 us/op 500.19 us/op 0.85
array of 16000 items push then shift 1.6707 us/op 1.8535 us/op 0.90
LinkedList of 16000 items push then shift 8.9460 ns/op 10.110 ns/op 0.88
array of 16000 items push then pop 97.136 ns/op 121.61 ns/op 0.80
LinkedList of 16000 items push then pop 8.6160 ns/op 9.2150 ns/op 0.93
array of 24000 items push then shift 2.3908 us/op 2.4988 us/op 0.96
LinkedList of 24000 items push then shift 8.8600 ns/op 11.360 ns/op 0.78
array of 24000 items push then pop 74.806 ns/op 86.821 ns/op 0.86
LinkedList of 24000 items push then pop 8.4970 ns/op 8.8980 ns/op 0.95
intersect bitArray bitLen 8 14.231 ns/op 14.011 ns/op 1.02
intersect array and set length 8 85.464 ns/op 96.530 ns/op 0.89
intersect bitArray bitLen 128 44.443 ns/op 46.953 ns/op 0.95
intersect array and set length 128 1.0573 us/op 1.2835 us/op 0.82
Buffer.concat 32 items 2.9730 us/op 3.1400 us/op 0.95
Uint8Array.set 32 items 2.5800 us/op 3.1140 us/op 0.83
transfer serialized Status (84 B) 1.9790 us/op 2.4560 us/op 0.81
copy serialized Status (84 B) 1.7360 us/op 1.9870 us/op 0.87
transfer serialized SignedVoluntaryExit (112 B) 2.1430 us/op 2.6670 us/op 0.80
copy serialized SignedVoluntaryExit (112 B) 1.7550 us/op 2.0980 us/op 0.84
transfer serialized ProposerSlashing (416 B) 2.8580 us/op 3.6680 us/op 0.78
copy serialized ProposerSlashing (416 B) 2.9070 us/op 3.2110 us/op 0.91
transfer serialized Attestation (485 B) 2.7690 us/op 3.1610 us/op 0.88
copy serialized Attestation (485 B) 2.6940 us/op 3.1750 us/op 0.85
transfer serialized AttesterSlashing (33232 B) 2.7400 us/op 2.7600 us/op 0.99
copy serialized AttesterSlashing (33232 B) 5.6020 us/op 6.9710 us/op 0.80
transfer serialized Small SignedBeaconBlock (128000 B) 3.1130 us/op 2.9930 us/op 1.04
copy serialized Small SignedBeaconBlock (128000 B) 16.142 us/op 19.963 us/op 0.81
transfer serialized Avg SignedBeaconBlock (200000 B) 3.3430 us/op 3.6180 us/op 0.92
copy serialized Avg SignedBeaconBlock (200000 B) 24.141 us/op 32.807 us/op 0.74
transfer serialized BlobsSidecar (524380 B) 3.2550 us/op 4.6270 us/op 0.70
copy serialized BlobsSidecar (524380 B) 148.08 us/op 125.75 us/op 1.18
transfer serialized Big SignedBeaconBlock (1000000 B) 3.3900 us/op 4.3890 us/op 0.77
copy serialized Big SignedBeaconBlock (1000000 B) 275.40 us/op 368.58 us/op 0.75
pass gossip attestations to forkchoice per slot 2.6688 ms/op 3.0327 ms/op 0.88
forkChoice updateHead vc 100000 bc 64 eq 0 2.1093 ms/op 2.2564 ms/op 0.93
forkChoice updateHead vc 600000 bc 64 eq 0 12.028 ms/op 13.558 ms/op 0.89
forkChoice updateHead vc 1000000 bc 64 eq 0 22.475 ms/op 24.486 ms/op 0.92
forkChoice updateHead vc 600000 bc 320 eq 0 17.762 ms/op 18.166 ms/op 0.98
forkChoice updateHead vc 600000 bc 1200 eq 0 83.275 ms/op 88.482 ms/op 0.94
forkChoice updateHead vc 600000 bc 64 eq 1000 21.049 ms/op 21.657 ms/op 0.97
forkChoice updateHead vc 600000 bc 64 eq 10000 22.882 ms/op 24.196 ms/op 0.95
forkChoice updateHead vc 600000 bc 64 eq 300000 30.895 ms/op 39.136 ms/op 0.79
computeDeltas 3.3197 ms/op 3.5413 ms/op 0.94
computeProposerBoostScoreFromBalances 1.8001 ms/op 1.9115 ms/op 0.94
altair processAttestation - 250000 vs - 7PWei normalcase 3.0059 ms/op 4.1368 ms/op 0.73
altair processAttestation - 250000 vs - 7PWei worstcase 4.0134 ms/op 5.8221 ms/op 0.69
altair processAttestation - setStatus - 1/6 committees join 155.14 us/op 160.71 us/op 0.97
altair processAttestation - setStatus - 1/3 committees join 296.89 us/op 306.63 us/op 0.97
altair processAttestation - setStatus - 1/2 committees join 377.00 us/op 387.02 us/op 0.97
altair processAttestation - setStatus - 2/3 committees join 481.31 us/op 496.64 us/op 0.97
altair processAttestation - setStatus - 4/5 committees join 672.03 us/op 687.81 us/op 0.98
altair processAttestation - setStatus - 100% committees join 789.04 us/op 799.36 us/op 0.99
altair processBlock - 250000 vs - 7PWei normalcase 19.011 ms/op 18.823 ms/op 1.01
altair processBlock - 250000 vs - 7PWei normalcase hashState 26.956 ms/op 30.805 ms/op 0.88
altair processBlock - 250000 vs - 7PWei worstcase 51.102 ms/op 54.247 ms/op 0.94
altair processBlock - 250000 vs - 7PWei worstcase hashState 73.552 ms/op 74.940 ms/op 0.98
phase0 processBlock - 250000 vs - 7PWei normalcase 2.4351 ms/op 2.0320 ms/op 1.20
phase0 processBlock - 250000 vs - 7PWei worstcase 31.146 ms/op 28.972 ms/op 1.08
altair processEth1Data - 250000 vs - 7PWei normalcase 626.86 us/op 451.52 us/op 1.39
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 8.4440 us/op 7.5330 us/op 1.12
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 24.240 us/op 27.918 us/op 0.87
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 11.293 us/op 12.257 us/op 0.92
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 9.3280 us/op 9.3390 us/op 1.00
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 107.37 us/op 113.40 us/op 0.95
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 732.76 us/op 1.0294 ms/op 0.71
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 912.22 us/op 1.7271 ms/op 0.53
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 897.53 us/op 1.3238 ms/op 0.68
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.4691 ms/op 2.2473 ms/op 1.10
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.5637 ms/op 2.1553 ms/op 0.73
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.8323 ms/op 3.5845 ms/op 1.07
Tree 40 250000 create 300.59 ms/op 319.90 ms/op 0.94
Tree 40 250000 get(125000) 179.39 ns/op 184.79 ns/op 0.97
Tree 40 250000 set(125000) 943.81 ns/op 913.64 ns/op 1.03
Tree 40 250000 toArray() 17.158 ms/op 17.304 ms/op 0.99
Tree 40 250000 iterate all - toArray() + loop 17.179 ms/op 17.128 ms/op 1.00
Tree 40 250000 iterate all - get(i) 67.774 ms/op 68.348 ms/op 0.99
MutableVector 250000 create 10.394 ms/op 13.915 ms/op 0.75
MutableVector 250000 get(125000) 6.1520 ns/op 6.6080 ns/op 0.93
MutableVector 250000 set(125000) 241.81 ns/op 269.01 ns/op 0.90
MutableVector 250000 toArray() 2.7133 ms/op 2.7552 ms/op 0.98
MutableVector 250000 iterate all - toArray() + loop 2.8024 ms/op 3.0777 ms/op 0.91
MutableVector 250000 iterate all - get(i) 1.4585 ms/op 1.5404 ms/op 0.95
Array 250000 create 2.4666 ms/op 2.5338 ms/op 0.97
Array 250000 clone - spread 1.1885 ms/op 1.1007 ms/op 1.08
Array 250000 get(125000) 0.56700 ns/op 0.54800 ns/op 1.03
Array 250000 set(125000) 0.63200 ns/op 0.62300 ns/op 1.01
Array 250000 iterate all - loop 104.64 us/op 108.42 us/op 0.97
effectiveBalanceIncrements clone Uint8Array 300000 30.812 us/op 26.651 us/op 1.16
effectiveBalanceIncrements clone MutableVector 300000 366.00 ns/op 339.00 ns/op 1.08
effectiveBalanceIncrements rw all Uint8Array 300000 161.78 us/op 171.60 us/op 0.94
effectiveBalanceIncrements rw all MutableVector 300000 81.865 ms/op 78.764 ms/op 1.04
phase0 afterProcessEpoch - 250000 vs - 7PWei 111.86 ms/op 113.58 ms/op 0.98
phase0 beforeProcessEpoch - 250000 vs - 7PWei 37.237 ms/op 43.548 ms/op 0.86
altair processEpoch - mainnet_e81889 300.83 ms/op 355.97 ms/op 0.85
mainnet_e81889 - altair beforeProcessEpoch 49.643 ms/op 51.513 ms/op 0.96
mainnet_e81889 - altair processJustificationAndFinalization 17.993 us/op 24.924 us/op 0.72
mainnet_e81889 - altair processInactivityUpdates 5.1136 ms/op 5.3804 ms/op 0.95
mainnet_e81889 - altair processRewardsAndPenalties 69.258 ms/op 78.584 ms/op 0.88
mainnet_e81889 - altair processRegistryUpdates 2.3890 us/op 3.2520 us/op 0.73
mainnet_e81889 - altair processSlashings 500.00 ns/op 586.00 ns/op 0.85
mainnet_e81889 - altair processEth1DataReset 517.00 ns/op 760.00 ns/op 0.68
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2083 ms/op 1.3017 ms/op 0.93
mainnet_e81889 - altair processSlashingsReset 4.8590 us/op 6.0900 us/op 0.80
mainnet_e81889 - altair processRandaoMixesReset 4.6220 us/op 7.5310 us/op 0.61
mainnet_e81889 - altair processHistoricalRootsUpdate 707.00 ns/op 1.8740 us/op 0.38
mainnet_e81889 - altair processParticipationFlagUpdates 2.4740 us/op 3.3460 us/op 0.74
mainnet_e81889 - altair processSyncCommitteeUpdates 557.00 ns/op 954.00 ns/op 0.58
mainnet_e81889 - altair afterProcessEpoch 114.13 ms/op 133.05 ms/op 0.86
phase0 processEpoch - mainnet_e58758 313.93 ms/op 417.71 ms/op 0.75
mainnet_e58758 - phase0 beforeProcessEpoch 120.55 ms/op 169.23 ms/op 0.71
mainnet_e58758 - phase0 processJustificationAndFinalization 16.643 us/op 21.086 us/op 0.79
mainnet_e58758 - phase0 processRewardsAndPenalties 56.009 ms/op 71.248 ms/op 0.79
mainnet_e58758 - phase0 processRegistryUpdates 7.8350 us/op 11.159 us/op 0.70
mainnet_e58758 - phase0 processSlashings 518.00 ns/op 846.00 ns/op 0.61
mainnet_e58758 - phase0 processEth1DataReset 504.00 ns/op 896.00 ns/op 0.56
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 944.02 us/op 1.0439 ms/op 0.90
mainnet_e58758 - phase0 processSlashingsReset 3.3180 us/op 7.5940 us/op 0.44
mainnet_e58758 - phase0 processRandaoMixesReset 4.6280 us/op 7.7160 us/op 0.60
mainnet_e58758 - phase0 processHistoricalRootsUpdate 736.00 ns/op 1.3960 us/op 0.53
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.8790 us/op 5.7670 us/op 0.67
mainnet_e58758 - phase0 afterProcessEpoch 93.492 ms/op 112.20 ms/op 0.83
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.1939 ms/op 1.7186 ms/op 0.69
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4312 ms/op 2.2055 ms/op 0.65
altair processInactivityUpdates - 250000 normalcase 23.235 ms/op 37.895 ms/op 0.61
altair processInactivityUpdates - 250000 worstcase 21.305 ms/op 35.504 ms/op 0.60
phase0 processRegistryUpdates - 250000 normalcase 6.3370 us/op 16.837 us/op 0.38
phase0 processRegistryUpdates - 250000 badcase_full_deposits 246.20 us/op 388.44 us/op 0.63
phase0 processRegistryUpdates - 250000 worstcase 0.5 111.47 ms/op 153.76 ms/op 0.72
altair processRewardsAndPenalties - 250000 normalcase 58.407 ms/op 85.077 ms/op 0.69
altair processRewardsAndPenalties - 250000 worstcase 59.595 ms/op 102.38 ms/op 0.58
phase0 getAttestationDeltas - 250000 normalcase 6.3236 ms/op 12.363 ms/op 0.51
phase0 getAttestationDeltas - 250000 worstcase 6.5918 ms/op 13.790 ms/op 0.48
phase0 processSlashings - 250000 worstcase 3.4891 ms/op 7.0691 ms/op 0.49
altair processSyncCommitteeUpdates - 250000 170.29 ms/op 268.54 ms/op 0.63
BeaconState.hashTreeRoot - No change 261.00 ns/op 657.00 ns/op 0.40
BeaconState.hashTreeRoot - 1 full validator 50.419 us/op 61.179 us/op 0.82
BeaconState.hashTreeRoot - 32 full validator 491.56 us/op 684.81 us/op 0.72
BeaconState.hashTreeRoot - 512 full validator 5.3969 ms/op 8.1559 ms/op 0.66
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 60.884 us/op 79.832 us/op 0.76
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 875.66 us/op 1.0022 ms/op 0.87
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.030 ms/op 13.289 ms/op 0.83
BeaconState.hashTreeRoot - 1 balances 48.487 us/op 54.672 us/op 0.89
BeaconState.hashTreeRoot - 32 balances 443.03 us/op 532.13 us/op 0.83
BeaconState.hashTreeRoot - 512 balances 4.2850 ms/op 4.8114 ms/op 0.89
BeaconState.hashTreeRoot - 250000 balances 74.218 ms/op 87.685 ms/op 0.85
aggregationBits - 2048 els - zipIndexesInBitList 15.262 us/op 20.031 us/op 0.76
regular array get 100000 times 32.312 us/op 43.445 us/op 0.74
wrappedArray get 100000 times 32.288 us/op 41.518 us/op 0.78
arrayWithProxy get 100000 times 15.292 ms/op 17.377 ms/op 0.88
ssz.Root.equals 535.00 ns/op 656.00 ns/op 0.82
byteArrayEquals 526.00 ns/op 639.00 ns/op 0.82
shuffle list - 16384 els 6.7209 ms/op 7.4640 ms/op 0.90
shuffle list - 250000 els 98.595 ms/op 108.87 ms/op 0.91
processSlot - 1 slots 8.3880 us/op 10.811 us/op 0.78
processSlot - 32 slots 1.2744 ms/op 1.7366 ms/op 0.73
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 32.653 ms/op 38.918 ms/op 0.84
getCommitteeAssignments - req 1 vs - 250000 vc 2.7982 ms/op 2.9868 ms/op 0.94
getCommitteeAssignments - req 100 vs - 250000 vc 3.9617 ms/op 4.2344 ms/op 0.94
getCommitteeAssignments - req 1000 vs - 250000 vc 4.3570 ms/op 4.6187 ms/op 0.94
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.5700 ns/op 5.4900 ns/op 0.83
state getBlockRootAtSlot - 250000 vs - 7PWei 907.34 ns/op 874.77 ns/op 1.04
computeProposers - vc 250000 10.457 ms/op 11.744 ms/op 0.89
computeEpochShuffling - vc 250000 97.326 ms/op 111.74 ms/op 0.87
getNextSyncCommittee - vc 250000 170.97 ms/op 193.11 ms/op 0.89
computeSigningRoot for AttestationData 13.245 us/op 14.701 us/op 0.90
hash AttestationData serialized data then Buffer.toString(base64) 2.3092 us/op 2.6064 us/op 0.89
toHexString serialized data 1.0247 us/op 1.2127 us/op 0.84
Buffer.toString(base64) 303.46 ns/op 345.31 ns/op 0.88

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 4bbe595 into unstable Jun 20, 2023
11 checks passed
@wemeetagain wemeetagain deleted the nflaig-patch-1 branch June 20, 2023 12:49
@wemeetagain
Copy link
Member

馃帀 This PR is included in v1.10.0 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nflaig @wemeetagain @dapplion