Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevEpochBlockProposalSummary typo #5707

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix: prevEpochBlockProposalSummary typo #5707

merged 1 commit into from
Jun 26, 2023

Conversation

dapplion
Copy link
Contributor

Motivation

Should register proposal summaries to prevEpochBlockProposalSummary, not prevEpochAttestationSummary

@dapplion dapplion requested a review from a team as a code owner June 26, 2023 09:03
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: f0d8d35 Previous: f5d12a8 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 655.45 us/op 598.89 us/op 1.09
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 47.817 us/op 57.417 us/op 0.83
BLS verify - blst-native 1.2565 ms/op 1.2633 ms/op 0.99
BLS verifyMultipleSignatures 3 - blst-native 2.5816 ms/op 2.5398 ms/op 1.02
BLS verifyMultipleSignatures 8 - blst-native 5.4790 ms/op 5.3910 ms/op 1.02
BLS verifyMultipleSignatures 32 - blst-native 19.766 ms/op 19.518 ms/op 1.01
BLS aggregatePubkeys 32 - blst-native 26.181 us/op 26.558 us/op 0.99
BLS aggregatePubkeys 128 - blst-native 102.32 us/op 103.67 us/op 0.99
getAttestationsForBlock 56.025 ms/op 61.260 ms/op 0.91
isKnown best case - 1 super set check 272.00 ns/op 279.00 ns/op 0.97
isKnown normal case - 2 super set checks 263.00 ns/op 276.00 ns/op 0.95
isKnown worse case - 16 super set checks 272.00 ns/op 267.00 ns/op 1.02
CheckpointStateCache - add get delete 5.5080 us/op 5.6170 us/op 0.98
validate gossip signedAggregateAndProof - struct 2.8596 ms/op 2.8075 ms/op 1.02
validate gossip attestation - struct 1.3472 ms/op 1.3328 ms/op 1.01
pickEth1Vote - no votes 1.3187 ms/op 1.3730 ms/op 0.96
pickEth1Vote - max votes 11.645 ms/op 11.814 ms/op 0.99
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.3363 ms/op 9.8277 ms/op 0.95
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 15.585 ms/op 15.791 ms/op 0.99
pickEth1Vote - Eth1Data fastSerialize value x2048 735.42 us/op 787.34 us/op 0.93
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.2396 ms/op 6.6871 ms/op 0.78
bytes32 toHexString 544.00 ns/op 590.00 ns/op 0.92
bytes32 Buffer.toString(hex) 415.00 ns/op 394.00 ns/op 1.05
bytes32 Buffer.toString(hex) from Uint8Array 575.00 ns/op 641.00 ns/op 0.90
bytes32 Buffer.toString(hex) + 0x 386.00 ns/op 397.00 ns/op 0.97
Object access 1 prop 0.20600 ns/op 0.19200 ns/op 1.07
Map access 1 prop 0.18000 ns/op 0.17000 ns/op 1.06
Object get x1000 7.4190 ns/op 6.6090 ns/op 1.12
Map get x1000 0.72400 ns/op 0.60500 ns/op 1.20
Object set x1000 65.489 ns/op 56.496 ns/op 1.16
Map set x1000 51.150 ns/op 45.751 ns/op 1.12
Return object 10000 times 0.25080 ns/op 0.24240 ns/op 1.03
Throw Error 10000 times 4.4491 us/op 4.3690 us/op 1.02
fastMsgIdFn sha256 / 200 bytes 3.6010 us/op 3.5150 us/op 1.02
fastMsgIdFn h32 xxhash / 200 bytes 301.00 ns/op 311.00 ns/op 0.97
fastMsgIdFn h64 xxhash / 200 bytes 423.00 ns/op 458.00 ns/op 0.92
fastMsgIdFn sha256 / 1000 bytes 11.875 us/op 11.763 us/op 1.01
fastMsgIdFn h32 xxhash / 1000 bytes 447.00 ns/op 443.00 ns/op 1.01
fastMsgIdFn h64 xxhash / 1000 bytes 498.00 ns/op 542.00 ns/op 0.92
fastMsgIdFn sha256 / 10000 bytes 106.08 us/op 103.92 us/op 1.02
fastMsgIdFn h32 xxhash / 10000 bytes 1.9950 us/op 1.9990 us/op 1.00
fastMsgIdFn h64 xxhash / 10000 bytes 1.4490 us/op 1.4730 us/op 0.98
enrSubnets - fastDeserialize 64 bits 1.4450 us/op 1.4240 us/op 1.01
enrSubnets - ssz BitVector 64 bits 566.00 ns/op 609.00 ns/op 0.93
enrSubnets - fastDeserialize 4 bits 209.00 ns/op 204.00 ns/op 1.02
enrSubnets - ssz BitVector 4 bits 604.00 ns/op 590.00 ns/op 1.02
prioritizePeers score -10:0 att 32-0.1 sync 2-0 125.78 us/op 116.33 us/op 1.08
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 169.15 us/op 159.58 us/op 1.06
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 186.41 us/op 180.35 us/op 1.03
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 345.88 us/op 352.86 us/op 0.98
prioritizePeers score 0:0 att 64-1 sync 4-1 412.94 us/op 417.57 us/op 0.99
array of 16000 items push then shift 1.7770 us/op 1.6686 us/op 1.06
LinkedList of 16000 items push then shift 9.2730 ns/op 9.0720 ns/op 1.02
array of 16000 items push then pop 105.31 ns/op 119.10 ns/op 0.88
LinkedList of 16000 items push then pop 8.9440 ns/op 8.9990 ns/op 0.99
array of 24000 items push then shift 2.4833 us/op 2.3905 us/op 1.04
LinkedList of 24000 items push then shift 9.5920 ns/op 9.2030 ns/op 1.04
array of 24000 items push then pop 88.732 ns/op 81.382 ns/op 1.09
LinkedList of 24000 items push then pop 9.1710 ns/op 8.9370 ns/op 1.03
intersect bitArray bitLen 8 17.030 ns/op 13.485 ns/op 1.26
intersect array and set length 8 87.800 ns/op 85.289 ns/op 1.03
intersect bitArray bitLen 128 45.998 ns/op 44.463 ns/op 1.03
intersect array and set length 128 1.2498 us/op 1.1320 us/op 1.10
Buffer.concat 32 items 2.9390 us/op 2.9940 us/op 0.98
Uint8Array.set 32 items 3.0940 us/op 2.7350 us/op 1.13
transfer serialized Status (84 B) 2.2260 us/op 2.2030 us/op 1.01
copy serialized Status (84 B) 1.8860 us/op 1.8280 us/op 1.03
transfer serialized SignedVoluntaryExit (112 B) 2.2290 us/op 2.3490 us/op 0.95
copy serialized SignedVoluntaryExit (112 B) 1.8100 us/op 1.9900 us/op 0.91
transfer serialized ProposerSlashing (416 B) 2.6900 us/op 3.3370 us/op 0.81
copy serialized ProposerSlashing (416 B) 2.7040 us/op 3.0270 us/op 0.89
transfer serialized Attestation (485 B) 2.8110 us/op 2.6420 us/op 1.06
copy serialized Attestation (485 B) 3.2950 us/op 2.8100 us/op 1.17
transfer serialized AttesterSlashing (33232 B) 2.9420 us/op 3.0790 us/op 0.96
copy serialized AttesterSlashing (33232 B) 9.3570 us/op 5.8300 us/op 1.60
transfer serialized Small SignedBeaconBlock (128000 B) 3.2320 us/op 2.8290 us/op 1.14
copy serialized Small SignedBeaconBlock (128000 B) 18.857 us/op 14.523 us/op 1.30
transfer serialized Avg SignedBeaconBlock (200000 B) 3.9740 us/op 3.1230 us/op 1.27
copy serialized Avg SignedBeaconBlock (200000 B) 26.768 us/op 19.106 us/op 1.40
transfer serialized BlobsSidecar (524380 B) 3.7360 us/op 3.1710 us/op 1.18
copy serialized BlobsSidecar (524380 B) 159.55 us/op 127.82 us/op 1.25
transfer serialized Big SignedBeaconBlock (1000000 B) 3.9210 us/op 3.5500 us/op 1.10
copy serialized Big SignedBeaconBlock (1000000 B) 216.73 us/op 246.71 us/op 0.88
pass gossip attestations to forkchoice per slot 3.0237 ms/op 2.6819 ms/op 1.13
forkChoice updateHead vc 100000 bc 64 eq 0 2.4791 ms/op 2.0815 ms/op 1.19
forkChoice updateHead vc 600000 bc 64 eq 0 14.342 ms/op 11.630 ms/op 1.23
forkChoice updateHead vc 1000000 bc 64 eq 0 20.996 ms/op 21.977 ms/op 0.96
forkChoice updateHead vc 600000 bc 320 eq 0 18.607 ms/op 16.631 ms/op 1.12
forkChoice updateHead vc 600000 bc 1200 eq 0 96.279 ms/op 82.067 ms/op 1.17
forkChoice updateHead vc 600000 bc 64 eq 1000 23.277 ms/op 20.712 ms/op 1.12
forkChoice updateHead vc 600000 bc 64 eq 10000 24.419 ms/op 22.765 ms/op 1.07
forkChoice updateHead vc 600000 bc 64 eq 300000 44.603 ms/op 31.201 ms/op 1.43
computeDeltas 3.9686 ms/op 3.2630 ms/op 1.22
computeProposerBoostScoreFromBalances 1.9587 ms/op 1.7758 ms/op 1.10
altair processAttestation - 250000 vs - 7PWei normalcase 3.0299 ms/op 2.3120 ms/op 1.31
altair processAttestation - 250000 vs - 7PWei worstcase 4.3198 ms/op 3.4024 ms/op 1.27
altair processAttestation - setStatus - 1/6 committees join 166.30 us/op 142.77 us/op 1.16
altair processAttestation - setStatus - 1/3 committees join 316.33 us/op 274.98 us/op 1.15
altair processAttestation - setStatus - 1/2 committees join 425.99 us/op 375.37 us/op 1.13
altair processAttestation - setStatus - 2/3 committees join 518.16 us/op 463.81 us/op 1.12
altair processAttestation - setStatus - 4/5 committees join 773.47 us/op 679.04 us/op 1.14
altair processAttestation - setStatus - 100% committees join 819.21 us/op 761.45 us/op 1.08
altair processBlock - 250000 vs - 7PWei normalcase 19.816 ms/op 17.744 ms/op 1.12
altair processBlock - 250000 vs - 7PWei normalcase hashState 26.216 ms/op 27.525 ms/op 0.95
altair processBlock - 250000 vs - 7PWei worstcase 53.518 ms/op 49.667 ms/op 1.08
altair processBlock - 250000 vs - 7PWei worstcase hashState 78.489 ms/op 73.708 ms/op 1.06
phase0 processBlock - 250000 vs - 7PWei normalcase 2.7888 ms/op 1.9894 ms/op 1.40
phase0 processBlock - 250000 vs - 7PWei worstcase 34.037 ms/op 28.994 ms/op 1.17
altair processEth1Data - 250000 vs - 7PWei normalcase 710.80 us/op 487.81 us/op 1.46
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 14.980 us/op 8.3730 us/op 1.79
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 39.312 us/op 24.594 us/op 1.60
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 17.660 us/op 10.450 us/op 1.69
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 12.173 us/op 7.7850 us/op 1.56
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 135.38 us/op 95.787 us/op 1.41
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.0175 ms/op 637.78 us/op 1.60
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.2597 ms/op 924.88 us/op 1.36
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.1299 ms/op 874.61 us/op 1.29
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.4818 ms/op 2.3686 ms/op 1.47
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.1241 ms/op 1.5781 ms/op 1.35
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 6.1637 ms/op 4.2187 ms/op 1.46
Tree 40 250000 create 785.51 ms/op 339.16 ms/op 2.32
Tree 40 250000 get(125000) 214.61 ns/op 198.05 ns/op 1.08
Tree 40 250000 set(125000) 2.7998 us/op 1.0315 us/op 2.71
Tree 40 250000 toArray() 25.857 ms/op 26.719 ms/op 0.97
Tree 40 250000 iterate all - toArray() + loop 24.767 ms/op 21.562 ms/op 1.15
Tree 40 250000 iterate all - get(i) 81.886 ms/op 71.706 ms/op 1.14
MutableVector 250000 create 13.889 ms/op 10.698 ms/op 1.30
MutableVector 250000 get(125000) 6.8230 ns/op 6.5030 ns/op 1.05
MutableVector 250000 set(125000) 398.78 ns/op 258.58 ns/op 1.54
MutableVector 250000 toArray() 4.6616 ms/op 2.9148 ms/op 1.60
MutableVector 250000 iterate all - toArray() + loop 4.6517 ms/op 3.0535 ms/op 1.52
MutableVector 250000 iterate all - get(i) 1.6407 ms/op 1.5297 ms/op 1.07
Array 250000 create 4.5168 ms/op 2.7748 ms/op 1.63
Array 250000 clone - spread 1.4900 ms/op 1.2422 ms/op 1.20
Array 250000 get(125000) 1.0720 ns/op 0.63300 ns/op 1.69
Array 250000 set(125000) 1.7250 ns/op 0.70300 ns/op 2.45
Array 250000 iterate all - loop 95.100 us/op 84.631 us/op 1.12
effectiveBalanceIncrements clone Uint8Array 300000 59.072 us/op 35.597 us/op 1.66
effectiveBalanceIncrements clone MutableVector 300000 396.00 ns/op 368.00 ns/op 1.08
effectiveBalanceIncrements rw all Uint8Array 300000 175.57 us/op 173.50 us/op 1.01
effectiveBalanceIncrements rw all MutableVector 300000 144.66 ms/op 87.676 ms/op 1.65
phase0 afterProcessEpoch - 250000 vs - 7PWei 139.17 ms/op 119.56 ms/op 1.16
phase0 beforeProcessEpoch - 250000 vs - 7PWei 54.885 ms/op 41.093 ms/op 1.34
altair processEpoch - mainnet_e81889 354.09 ms/op 339.58 ms/op 1.04
mainnet_e81889 - altair beforeProcessEpoch 73.826 ms/op 70.493 ms/op 1.05
mainnet_e81889 - altair processJustificationAndFinalization 24.435 us/op 19.117 us/op 1.28
mainnet_e81889 - altair processInactivityUpdates 6.3345 ms/op 6.0615 ms/op 1.05
mainnet_e81889 - altair processRewardsAndPenalties 71.525 ms/op 54.846 ms/op 1.30
mainnet_e81889 - altair processRegistryUpdates 5.9820 us/op 2.6220 us/op 2.28
mainnet_e81889 - altair processSlashings 950.00 ns/op 599.00 ns/op 1.59
mainnet_e81889 - altair processEth1DataReset 803.00 ns/op 702.00 ns/op 1.14
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3070 ms/op 1.2679 ms/op 1.03
mainnet_e81889 - altair processSlashingsReset 5.9460 us/op 4.9670 us/op 1.20
mainnet_e81889 - altair processRandaoMixesReset 7.2950 us/op 4.4610 us/op 1.64
mainnet_e81889 - altair processHistoricalRootsUpdate 1.6550 us/op 1.1060 us/op 1.50
mainnet_e81889 - altair processParticipationFlagUpdates 3.4000 us/op 3.3620 us/op 1.01
mainnet_e81889 - altair processSyncCommitteeUpdates 1.1240 us/op 947.00 ns/op 1.19
mainnet_e81889 - altair afterProcessEpoch 136.85 ms/op 121.32 ms/op 1.13
phase0 processEpoch - mainnet_e58758 466.30 ms/op 365.61 ms/op 1.28
mainnet_e58758 - phase0 beforeProcessEpoch 222.36 ms/op 153.39 ms/op 1.45
mainnet_e58758 - phase0 processJustificationAndFinalization 37.933 us/op 24.813 us/op 1.53
mainnet_e58758 - phase0 processRewardsAndPenalties 72.252 ms/op 74.836 ms/op 0.97
mainnet_e58758 - phase0 processRegistryUpdates 18.064 us/op 10.662 us/op 1.69
mainnet_e58758 - phase0 processSlashings 1.7980 us/op 722.00 ns/op 2.49
mainnet_e58758 - phase0 processEth1DataReset 1.1990 us/op 835.00 ns/op 1.44
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.8642 ms/op 1.1497 ms/op 1.62
mainnet_e58758 - phase0 processSlashingsReset 9.3440 us/op 4.4240 us/op 2.11
mainnet_e58758 - phase0 processRandaoMixesReset 11.136 us/op 5.2350 us/op 2.13
mainnet_e58758 - phase0 processHistoricalRootsUpdate 2.1320 us/op 907.00 ns/op 2.35
mainnet_e58758 - phase0 processParticipationRecordUpdates 11.172 us/op 5.8460 us/op 1.91
mainnet_e58758 - phase0 afterProcessEpoch 114.73 ms/op 104.89 ms/op 1.09
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3721 ms/op 1.2908 ms/op 1.06
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.6750 ms/op 1.6286 ms/op 1.03
altair processInactivityUpdates - 250000 normalcase 28.033 ms/op 28.401 ms/op 0.99
altair processInactivityUpdates - 250000 worstcase 29.449 ms/op 26.550 ms/op 1.11
phase0 processRegistryUpdates - 250000 normalcase 9.2680 us/op 8.6580 us/op 1.07
phase0 processRegistryUpdates - 250000 badcase_full_deposits 281.08 us/op 308.54 us/op 0.91
phase0 processRegistryUpdates - 250000 worstcase 0.5 132.94 ms/op 136.59 ms/op 0.97
altair processRewardsAndPenalties - 250000 normalcase 67.764 ms/op 72.651 ms/op 0.93
altair processRewardsAndPenalties - 250000 worstcase 67.046 ms/op 78.477 ms/op 0.85
phase0 getAttestationDeltas - 250000 normalcase 7.5032 ms/op 8.1412 ms/op 0.92
phase0 getAttestationDeltas - 250000 worstcase 6.9688 ms/op 7.1905 ms/op 0.97
phase0 processSlashings - 250000 worstcase 3.4949 ms/op 3.7932 ms/op 0.92
altair processSyncCommitteeUpdates - 250000 188.08 ms/op 206.91 ms/op 0.91
BeaconState.hashTreeRoot - No change 360.00 ns/op 286.00 ns/op 1.26
BeaconState.hashTreeRoot - 1 full validator 58.544 us/op 60.488 us/op 0.97
BeaconState.hashTreeRoot - 32 full validator 624.33 us/op 550.57 us/op 1.13
BeaconState.hashTreeRoot - 512 full validator 7.3714 ms/op 6.0805 ms/op 1.21
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 73.284 us/op 72.791 us/op 1.01
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 978.06 us/op 1.0236 ms/op 0.96
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 14.167 ms/op 16.653 ms/op 0.85
BeaconState.hashTreeRoot - 1 balances 52.689 us/op 56.707 us/op 0.93
BeaconState.hashTreeRoot - 32 balances 478.51 us/op 497.97 us/op 0.96
BeaconState.hashTreeRoot - 512 balances 4.8902 ms/op 5.3809 ms/op 0.91
BeaconState.hashTreeRoot - 250000 balances 81.232 ms/op 84.618 ms/op 0.96
aggregationBits - 2048 els - zipIndexesInBitList 21.924 us/op 26.695 us/op 0.82
regular array get 100000 times 47.456 us/op 35.248 us/op 1.35
wrappedArray get 100000 times 34.537 us/op 34.737 us/op 0.99
arrayWithProxy get 100000 times 16.797 ms/op 16.871 ms/op 1.00
ssz.Root.equals 626.00 ns/op 676.00 ns/op 0.93
byteArrayEquals 611.00 ns/op 625.00 ns/op 0.98
shuffle list - 16384 els 7.2055 ms/op 7.1752 ms/op 1.00
shuffle list - 250000 els 107.30 ms/op 105.35 ms/op 1.02
processSlot - 1 slots 9.3880 us/op 10.248 us/op 0.92
processSlot - 32 slots 1.4334 ms/op 1.4447 ms/op 0.99
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 36.231 ms/op 41.442 ms/op 0.87
getCommitteeAssignments - req 1 vs - 250000 vc 2.9715 ms/op 3.1291 ms/op 0.95
getCommitteeAssignments - req 100 vs - 250000 vc 4.2145 ms/op 4.4472 ms/op 0.95
getCommitteeAssignments - req 1000 vs - 250000 vc 4.6046 ms/op 5.1463 ms/op 0.89
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.0500 ns/op 6.0100 ns/op 0.84
state getBlockRootAtSlot - 250000 vs - 7PWei 592.23 ns/op 798.60 ns/op 0.74
computeProposers - vc 250000 10.782 ms/op 11.582 ms/op 0.93
computeEpochShuffling - vc 250000 104.91 ms/op 124.90 ms/op 0.84
getNextSyncCommittee - vc 250000 180.11 ms/op 200.33 ms/op 0.90
computeSigningRoot for AttestationData 13.222 us/op 16.590 us/op 0.80
hash AttestationData serialized data then Buffer.toString(base64) 2.5219 us/op 2.6370 us/op 0.96
toHexString serialized data 1.3488 us/op 1.7403 us/op 0.78
Buffer.toString(base64) 369.18 ns/op 403.62 ns/op 0.91

by benchmarkbot/action

@dapplion dapplion changed the title Fix prevEpochBlockProposalSummary typo fix: prevEpochBlockProposalSummary typo Jun 26, 2023
@wemeetagain wemeetagain merged commit 6be401d into unstable Jun 26, 2023
12 of 13 checks passed
@wemeetagain wemeetagain deleted the dapplion/typo-prevEpochBlockProposalSummary branch June 26, 2023 16:31
@philknows philknows added this to the v1.9.1 milestone Jun 28, 2023
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dapplion @wemeetagain @philknows