Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore ALREADY_KNOWN gossip block error #5714

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix: ignore ALREADY_KNOWN gossip block error #5714

merged 1 commit into from
Jun 27, 2023

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jun 27, 2023

Motivation

  • After v1.9.0, unknown block root maybe downloaded before gossip block comes:
Downloaded unknown block root=0xd6726e2f9ca882c728f81b4a6f7580327576c03d9bbd7051ec0a7868671743ca, pendingBlocks=1, parentInForkchoice=true
Received gossip block slot=5942197, root=0xd672…43ca, curentSlot=5942197, peerId=16Uiu2HAm2GTP413xneJPzKQa9C8M3JzTh18RUrVuKajjrQe1o468, delaySec=0.7290000915527344, recvToVal=0.02499985694885254

then node may show this error

Error receiving block slot=5942197, peer=16Uiu2HAm2GTP413xneJPzKQa9C8M3JzTh18RUrVuKajjrQe1o468 code=BLOCK_ERROR_ALREADY_KNOWN, root=0xd6726e2f9ca882c728f81b4a6f7580327576c03d9bbd7051ec0a7868671743ca

Description

  • Use ignoreIfKnown flag when processing gossip block

@twoeths twoeths requested a review from a team as a code owner June 27, 2023 08:49
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 4ddda4e Previous: 00877ee Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 620.52 us/op 879.30 us/op 0.71
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 48.108 us/op 49.170 us/op 0.98
BLS verify - blst-native 1.2495 ms/op 1.2939 ms/op 0.97
BLS verifyMultipleSignatures 3 - blst-native 2.7272 ms/op 2.6465 ms/op 1.03
BLS verifyMultipleSignatures 8 - blst-native 5.5002 ms/op 5.7218 ms/op 0.96
BLS verifyMultipleSignatures 32 - blst-native 19.917 ms/op 20.510 ms/op 0.97
BLS aggregatePubkeys 32 - blst-native 26.815 us/op 27.357 us/op 0.98
BLS aggregatePubkeys 128 - blst-native 104.81 us/op 106.22 us/op 0.99
getAttestationsForBlock 63.672 ms/op 65.826 ms/op 0.97
isKnown best case - 1 super set check 268.00 ns/op 271.00 ns/op 0.99
isKnown normal case - 2 super set checks 268.00 ns/op 262.00 ns/op 1.02
isKnown worse case - 16 super set checks 267.00 ns/op 259.00 ns/op 1.03
CheckpointStateCache - add get delete 6.2010 us/op 5.6960 us/op 1.09
validate gossip signedAggregateAndProof - struct 2.9231 ms/op 2.9246 ms/op 1.00
validate gossip attestation - struct 1.3855 ms/op 1.3874 ms/op 1.00
pickEth1Vote - no votes 1.4196 ms/op 1.3520 ms/op 1.05
pickEth1Vote - max votes 11.370 ms/op 11.524 ms/op 0.99
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.2381 ms/op 9.1975 ms/op 1.00
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 17.743 ms/op 17.913 ms/op 0.99
pickEth1Vote - Eth1Data fastSerialize value x2048 664.65 us/op 698.90 us/op 0.95
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.5151 ms/op 4.8236 ms/op 0.94
bytes32 toHexString 512.00 ns/op 515.00 ns/op 0.99
bytes32 Buffer.toString(hex) 355.00 ns/op 386.00 ns/op 0.92
bytes32 Buffer.toString(hex) from Uint8Array 557.00 ns/op 577.00 ns/op 0.97
bytes32 Buffer.toString(hex) + 0x 369.00 ns/op 369.00 ns/op 1.00
Object access 1 prop 0.16800 ns/op 0.17700 ns/op 0.95
Map access 1 prop 0.17200 ns/op 0.17000 ns/op 1.01
Object get x1000 6.9590 ns/op 6.7890 ns/op 1.03
Map get x1000 0.57900 ns/op 0.65700 ns/op 0.88
Object set x1000 55.352 ns/op 55.773 ns/op 0.99
Map set x1000 44.638 ns/op 45.140 ns/op 0.99
Return object 10000 times 0.24210 ns/op 0.24750 ns/op 0.98
Throw Error 10000 times 4.3800 us/op 4.4315 us/op 0.99
fastMsgIdFn sha256 / 200 bytes 3.4610 us/op 3.6520 us/op 0.95
fastMsgIdFn h32 xxhash / 200 bytes 307.00 ns/op 298.00 ns/op 1.03
fastMsgIdFn h64 xxhash / 200 bytes 411.00 ns/op 440.00 ns/op 0.93
fastMsgIdFn sha256 / 1000 bytes 11.801 us/op 12.109 us/op 0.97
fastMsgIdFn h32 xxhash / 1000 bytes 436.00 ns/op 437.00 ns/op 1.00
fastMsgIdFn h64 xxhash / 1000 bytes 479.00 ns/op 495.00 ns/op 0.97
fastMsgIdFn sha256 / 10000 bytes 106.32 us/op 108.16 us/op 0.98
fastMsgIdFn h32 xxhash / 10000 bytes 1.9960 us/op 2.0080 us/op 0.99
fastMsgIdFn h64 xxhash / 10000 bytes 1.4450 us/op 1.4520 us/op 1.00
enrSubnets - fastDeserialize 64 bits 1.4050 us/op 1.3810 us/op 1.02
enrSubnets - ssz BitVector 64 bits 552.00 ns/op 529.00 ns/op 1.04
enrSubnets - fastDeserialize 4 bits 205.00 ns/op 186.00 ns/op 1.10
enrSubnets - ssz BitVector 4 bits 584.00 ns/op 541.00 ns/op 1.08
prioritizePeers score -10:0 att 32-0.1 sync 2-0 122.52 us/op 97.275 us/op 1.26
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 181.66 us/op 148.71 us/op 1.22
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 191.00 us/op 191.34 us/op 1.00
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 363.10 us/op 339.30 us/op 1.07
prioritizePeers score 0:0 att 64-1 sync 4-1 422.34 us/op 413.11 us/op 1.02
array of 16000 items push then shift 1.8192 us/op 1.6968 us/op 1.07
LinkedList of 16000 items push then shift 10.106 ns/op 9.6110 ns/op 1.05
array of 16000 items push then pop 123.45 ns/op 97.315 ns/op 1.27
LinkedList of 16000 items push then pop 10.895 ns/op 8.9260 ns/op 1.22
array of 24000 items push then shift 2.8848 us/op 2.5020 us/op 1.15
LinkedList of 24000 items push then shift 12.797 ns/op 10.922 ns/op 1.17
array of 24000 items push then pop 105.98 ns/op 92.037 ns/op 1.15
LinkedList of 24000 items push then pop 9.4970 ns/op 9.6220 ns/op 0.99
intersect bitArray bitLen 8 14.445 ns/op 13.754 ns/op 1.05
intersect array and set length 8 101.82 ns/op 78.756 ns/op 1.29
intersect bitArray bitLen 128 47.433 ns/op 44.660 ns/op 1.06
intersect array and set length 128 1.3297 us/op 1.1958 us/op 1.11
Buffer.concat 32 items 2.9700 us/op 2.8370 us/op 1.05
Uint8Array.set 32 items 2.8750 us/op 2.4730 us/op 1.16
transfer serialized Status (84 B) 2.3830 us/op 2.2390 us/op 1.06
copy serialized Status (84 B) 2.1640 us/op 1.8380 us/op 1.18
transfer serialized SignedVoluntaryExit (112 B) 2.5600 us/op 2.2270 us/op 1.15
copy serialized SignedVoluntaryExit (112 B) 2.1500 us/op 1.7550 us/op 1.23
transfer serialized ProposerSlashing (416 B) 3.3950 us/op 2.9600 us/op 1.15
copy serialized ProposerSlashing (416 B) 3.4570 us/op 2.9630 us/op 1.17
transfer serialized Attestation (485 B) 2.8750 us/op 2.9640 us/op 0.97
copy serialized Attestation (485 B) 2.5620 us/op 3.0870 us/op 0.83
transfer serialized AttesterSlashing (33232 B) 2.7280 us/op 3.1390 us/op 0.87
copy serialized AttesterSlashing (33232 B) 8.4750 us/op 5.9630 us/op 1.42
transfer serialized Small SignedBeaconBlock (128000 B) 3.1060 us/op 3.0470 us/op 1.02
copy serialized Small SignedBeaconBlock (128000 B) 25.313 us/op 15.478 us/op 1.64
transfer serialized Avg SignedBeaconBlock (200000 B) 3.3350 us/op 3.3050 us/op 1.01
copy serialized Avg SignedBeaconBlock (200000 B) 39.197 us/op 21.197 us/op 1.85
transfer serialized BlobsSidecar (524380 B) 3.8270 us/op 3.2370 us/op 1.18
copy serialized BlobsSidecar (524380 B) 228.26 us/op 182.34 us/op 1.25
transfer serialized Big SignedBeaconBlock (1000000 B) 4.0880 us/op 3.3660 us/op 1.21
copy serialized Big SignedBeaconBlock (1000000 B) 393.81 us/op 245.68 us/op 1.60
pass gossip attestations to forkchoice per slot 3.1487 ms/op 2.7988 ms/op 1.13
forkChoice updateHead vc 100000 bc 64 eq 0 2.2626 ms/op 2.1837 ms/op 1.04
forkChoice updateHead vc 600000 bc 64 eq 0 17.047 ms/op 11.552 ms/op 1.48
forkChoice updateHead vc 1000000 bc 64 eq 0 20.663 ms/op 21.423 ms/op 0.96
forkChoice updateHead vc 600000 bc 320 eq 0 18.003 ms/op 17.271 ms/op 1.04
forkChoice updateHead vc 600000 bc 1200 eq 0 92.408 ms/op 83.833 ms/op 1.10
forkChoice updateHead vc 600000 bc 64 eq 1000 22.585 ms/op 21.593 ms/op 1.05
forkChoice updateHead vc 600000 bc 64 eq 10000 23.572 ms/op 23.108 ms/op 1.02
forkChoice updateHead vc 600000 bc 64 eq 300000 45.830 ms/op 31.933 ms/op 1.44
computeDeltas 3.2402 ms/op 4.1604 ms/op 0.78
computeProposerBoostScoreFromBalances 1.8561 ms/op 1.8376 ms/op 1.01
altair processAttestation - 250000 vs - 7PWei normalcase 3.3572 ms/op 2.3838 ms/op 1.41
altair processAttestation - 250000 vs - 7PWei worstcase 4.2011 ms/op 3.4827 ms/op 1.21
altair processAttestation - setStatus - 1/6 committees join 156.70 us/op 146.03 us/op 1.07
altair processAttestation - setStatus - 1/3 committees join 302.21 us/op 289.31 us/op 1.04
altair processAttestation - setStatus - 1/2 committees join 402.62 us/op 386.03 us/op 1.04
altair processAttestation - setStatus - 2/3 committees join 483.51 us/op 483.77 us/op 1.00
altair processAttestation - setStatus - 4/5 committees join 690.70 us/op 695.56 us/op 0.99
altair processAttestation - setStatus - 100% committees join 793.45 us/op 805.61 us/op 0.98
altair processBlock - 250000 vs - 7PWei normalcase 20.571 ms/op 18.211 ms/op 1.13
altair processBlock - 250000 vs - 7PWei normalcase hashState 27.363 ms/op 30.284 ms/op 0.90
altair processBlock - 250000 vs - 7PWei worstcase 59.846 ms/op 55.140 ms/op 1.09
altair processBlock - 250000 vs - 7PWei worstcase hashState 78.511 ms/op 87.302 ms/op 0.90
phase0 processBlock - 250000 vs - 7PWei normalcase 2.2971 ms/op 2.0565 ms/op 1.12
phase0 processBlock - 250000 vs - 7PWei worstcase 29.830 ms/op 29.755 ms/op 1.00
altair processEth1Data - 250000 vs - 7PWei normalcase 538.28 us/op 477.44 us/op 1.13
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 9.6710 us/op 9.1170 us/op 1.06
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 26.936 us/op 33.962 us/op 0.79
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 12.103 us/op 8.4770 us/op 1.43
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 7.6860 us/op 6.4360 us/op 1.19
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 117.47 us/op 78.008 us/op 1.51
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 805.04 us/op 1.1617 ms/op 0.69
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 924.03 us/op 904.41 us/op 1.02
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 994.79 us/op 1.5993 ms/op 0.62
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.4341 ms/op 2.3633 ms/op 1.03
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.1295 ms/op 1.7824 ms/op 1.19
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.2159 ms/op 4.0175 ms/op 1.05
Tree 40 250000 create 325.18 ms/op 331.74 ms/op 0.98
Tree 40 250000 get(125000) 196.53 ns/op 196.93 ns/op 1.00
Tree 40 250000 set(125000) 1.0525 us/op 1.0196 us/op 1.03
Tree 40 250000 toArray() 22.880 ms/op 21.082 ms/op 1.09
Tree 40 250000 iterate all - toArray() + loop 25.443 ms/op 21.474 ms/op 1.18
Tree 40 250000 iterate all - get(i) 79.417 ms/op 74.856 ms/op 1.06
MutableVector 250000 create 12.062 ms/op 13.914 ms/op 0.87
MutableVector 250000 get(125000) 6.5560 ns/op 6.7870 ns/op 0.97
MutableVector 250000 set(125000) 264.04 ns/op 262.35 ns/op 1.01
MutableVector 250000 toArray() 3.4708 ms/op 3.0607 ms/op 1.13
MutableVector 250000 iterate all - toArray() + loop 3.8440 ms/op 3.4133 ms/op 1.13
MutableVector 250000 iterate all - get(i) 1.5843 ms/op 1.6087 ms/op 0.98
Array 250000 create 2.8547 ms/op 2.9831 ms/op 0.96
Array 250000 clone - spread 1.2110 ms/op 1.1706 ms/op 1.03
Array 250000 get(125000) 0.61800 ns/op 0.59300 ns/op 1.04
Array 250000 set(125000) 0.67600 ns/op 0.63400 ns/op 1.07
Array 250000 iterate all - loop 111.85 us/op 108.35 us/op 1.03
effectiveBalanceIncrements clone Uint8Array 300000 33.896 us/op 28.340 us/op 1.20
effectiveBalanceIncrements clone MutableVector 300000 378.00 ns/op 353.00 ns/op 1.07
effectiveBalanceIncrements rw all Uint8Array 300000 173.81 us/op 172.77 us/op 1.01
effectiveBalanceIncrements rw all MutableVector 300000 104.71 ms/op 82.069 ms/op 1.28
phase0 afterProcessEpoch - 250000 vs - 7PWei 124.16 ms/op 118.83 ms/op 1.04
phase0 beforeProcessEpoch - 250000 vs - 7PWei 42.505 ms/op 44.518 ms/op 0.95
altair processEpoch - mainnet_e81889 366.12 ms/op 370.02 ms/op 0.99
mainnet_e81889 - altair beforeProcessEpoch 73.308 ms/op 71.608 ms/op 1.02
mainnet_e81889 - altair processJustificationAndFinalization 21.263 us/op 21.745 us/op 0.98
mainnet_e81889 - altair processInactivityUpdates 7.8511 ms/op 8.0515 ms/op 0.98
mainnet_e81889 - altair processRewardsAndPenalties 80.284 ms/op 75.748 ms/op 1.06
mainnet_e81889 - altair processRegistryUpdates 3.4540 us/op 3.7600 us/op 0.92
mainnet_e81889 - altair processSlashings 495.00 ns/op 901.00 ns/op 0.55
mainnet_e81889 - altair processEth1DataReset 1.4860 us/op 883.00 ns/op 1.68
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.9066 ms/op 1.5486 ms/op 1.23
mainnet_e81889 - altair processSlashingsReset 7.5360 us/op 5.5940 us/op 1.35
mainnet_e81889 - altair processRandaoMixesReset 6.9530 us/op 8.7260 us/op 0.80
mainnet_e81889 - altair processHistoricalRootsUpdate 946.00 ns/op 2.3300 us/op 0.41
mainnet_e81889 - altair processParticipationFlagUpdates 3.2840 us/op 4.2150 us/op 0.78
mainnet_e81889 - altair processSyncCommitteeUpdates 458.00 ns/op 1.2550 us/op 0.36
mainnet_e81889 - altair afterProcessEpoch 132.99 ms/op 132.50 ms/op 1.00
phase0 processEpoch - mainnet_e58758 406.46 ms/op 388.80 ms/op 1.05
mainnet_e58758 - phase0 beforeProcessEpoch 167.51 ms/op 160.07 ms/op 1.05
mainnet_e58758 - phase0 processJustificationAndFinalization 19.224 us/op 28.274 us/op 0.68
mainnet_e58758 - phase0 processRewardsAndPenalties 73.512 ms/op 75.436 ms/op 0.97
mainnet_e58758 - phase0 processRegistryUpdates 9.2210 us/op 14.593 us/op 0.63
mainnet_e58758 - phase0 processSlashings 655.00 ns/op 894.00 ns/op 0.73
mainnet_e58758 - phase0 processEth1DataReset 640.00 ns/op 791.00 ns/op 0.81
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.3614 ms/op 1.9336 ms/op 0.70
mainnet_e58758 - phase0 processSlashingsReset 6.7920 us/op 7.1190 us/op 0.95
mainnet_e58758 - phase0 processRandaoMixesReset 7.2800 us/op 8.1190 us/op 0.90
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.6620 us/op 1.2050 us/op 1.38
mainnet_e58758 - phase0 processParticipationRecordUpdates 7.5080 us/op 6.8700 us/op 1.09
mainnet_e58758 - phase0 afterProcessEpoch 106.58 ms/op 102.45 ms/op 1.04
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.6492 ms/op 1.6489 ms/op 1.00
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.0341 ms/op 1.9258 ms/op 1.06
altair processInactivityUpdates - 250000 normalcase 28.539 ms/op 26.027 ms/op 1.10
altair processInactivityUpdates - 250000 worstcase 27.322 ms/op 29.828 ms/op 0.92
phase0 processRegistryUpdates - 250000 normalcase 8.2760 us/op 12.295 us/op 0.67
phase0 processRegistryUpdates - 250000 badcase_full_deposits 350.06 us/op 311.49 us/op 1.12
phase0 processRegistryUpdates - 250000 worstcase 0.5 146.38 ms/op 154.77 ms/op 0.95
altair processRewardsAndPenalties - 250000 normalcase 70.056 ms/op 76.495 ms/op 0.92
altair processRewardsAndPenalties - 250000 worstcase 73.651 ms/op 75.510 ms/op 0.98
phase0 getAttestationDeltas - 250000 normalcase 7.5421 ms/op 7.3389 ms/op 1.03
phase0 getAttestationDeltas - 250000 worstcase 7.2829 ms/op 9.1034 ms/op 0.80
phase0 processSlashings - 250000 worstcase 3.6974 ms/op 3.7339 ms/op 0.99
altair processSyncCommitteeUpdates - 250000 193.08 ms/op 194.41 ms/op 0.99
BeaconState.hashTreeRoot - No change 341.00 ns/op 353.00 ns/op 0.97
BeaconState.hashTreeRoot - 1 full validator 52.834 us/op 59.429 us/op 0.89
BeaconState.hashTreeRoot - 32 full validator 553.41 us/op 568.38 us/op 0.97
BeaconState.hashTreeRoot - 512 full validator 5.4680 ms/op 6.5437 ms/op 0.84
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 71.173 us/op 70.565 us/op 1.01
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 977.37 us/op 1.0065 ms/op 0.97
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 15.414 ms/op 12.726 ms/op 1.21
BeaconState.hashTreeRoot - 1 balances 55.783 us/op 58.342 us/op 0.96
BeaconState.hashTreeRoot - 32 balances 520.94 us/op 537.03 us/op 0.97
BeaconState.hashTreeRoot - 512 balances 4.9237 ms/op 5.3667 ms/op 0.92
BeaconState.hashTreeRoot - 250000 balances 77.413 ms/op 87.226 ms/op 0.89
aggregationBits - 2048 els - zipIndexesInBitList 17.033 us/op 24.273 us/op 0.70
regular array get 100000 times 33.904 us/op 36.964 us/op 0.92
wrappedArray get 100000 times 33.812 us/op 46.048 us/op 0.73
arrayWithProxy get 100000 times 16.207 ms/op 16.631 ms/op 0.97
ssz.Root.equals 569.00 ns/op 624.00 ns/op 0.91
byteArrayEquals 566.00 ns/op 621.00 ns/op 0.91
shuffle list - 16384 els 7.0717 ms/op 7.7135 ms/op 0.92
shuffle list - 250000 els 104.61 ms/op 109.68 ms/op 0.95
processSlot - 1 slots 9.7730 us/op 10.776 us/op 0.91
processSlot - 32 slots 1.4070 ms/op 1.7822 ms/op 0.79
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 40.364 ms/op 45.000 ms/op 0.90
getCommitteeAssignments - req 1 vs - 250000 vc 3.2767 ms/op 3.1966 ms/op 1.03
getCommitteeAssignments - req 100 vs - 250000 vc 4.4889 ms/op 4.6284 ms/op 0.97
getCommitteeAssignments - req 1000 vs - 250000 vc 4.9145 ms/op 5.1554 ms/op 0.95
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.5300 ns/op 5.5400 ns/op 1.00
state getBlockRootAtSlot - 250000 vs - 7PWei 1.1205 us/op 859.08 ns/op 1.30
computeProposers - vc 250000 12.819 ms/op 12.549 ms/op 1.02
computeEpochShuffling - vc 250000 124.48 ms/op 122.97 ms/op 1.01
getNextSyncCommittee - vc 250000 211.50 ms/op 210.34 ms/op 1.01
computeSigningRoot for AttestationData 15.204 us/op 16.493 us/op 0.92
hash AttestationData serialized data then Buffer.toString(base64) 2.8009 us/op 2.8748 us/op 0.97
toHexString serialized data 1.6082 us/op 1.7098 us/op 0.94
Buffer.toString(base64) 374.73 ns/op 402.06 ns/op 0.93

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 2f687cf into unstable Jun 27, 2023
12 checks passed
@wemeetagain wemeetagain deleted the tuyen/gossip_block_ignore_if_known branch June 27, 2023 12:23
@philknows philknows added this to the v1.9.1 milestone Jun 28, 2023
philknows pushed a commit that referenced this pull request Jun 28, 2023
@twoeths @philknows
fix: ignore ALREADY_KNOWN gossip block error (#5714)
67a2b72
@philknows philknows mentioned this pull request Jun 28, 2023
Merged
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.1 🎉

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

@nflaig nflaig mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twoeths @wemeetagain @philknows