feat: add basic broadcast validation to the block publishing #5762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
changed the title
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
previously approved these changes
Jul 20, 2023
There was a problem hiding this comment.
This PR changes current behaviour that ignores broadcastValidation, to rejecting calls with values != consensus. I'm not sure if it's an strictly improvement, but I can see the reasoning why. Do you think there value in merging a throw before the full actual implementation?
added a flag to enforce strictness (mostly for dev purposes) I agree will push follow up PRs on this tracking here: currently default broadCastValdaton requested by valdator s |
g11tech
force-pushed
the
g11tech/broadcast-val
branch
from
42867d5
to
880522a
Compare
wemeetagain
requested changes
Jul 24, 2023
| @@ -44,6 +44,13 @@ export type BlockHeaderResponse = { | |||
| header: phase0.SignedBeaconBlockHeader; | |||
| }; | |||
|
|
|||
| export enum BroadcastValidation { | |||
| none = "none", | |||
There was a problem hiding this comment.
according to the beacon APIs this shouldn't exist
There was a problem hiding this comment.
none is what our current case is, just added it for convenience and incase one doesn't want to actually do any validations before publishing... may be we can remove it later
wemeetagain
reviewed
Jul 26, 2023
| } | ||
| break; | ||
| } | ||
| case routes.beacon.BroadcastValidation.consensus: { |
There was a problem hiding this comment.
I think this PR should implement the different broadcast validations
There was a problem hiding this comment.
would prefer to do followups unless you feel strongly about this
wemeetagain
reviewed
Jul 27, 2023
wemeetagain
approved these changes
Aug 2, 2023
|
🎉 This PR is included in v1.11.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement
broadcast_validationto block publishing ethereum/beacon-APIs#317Part of - BroadcastValidations tracer #5761
TODO:
noneparam as default (expose via a cli option), primarily to support block publishing via fallback beacon nodesconsensusvals